Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0047989 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Web POS | minor | have not tried | 2021-11-04 13:34 | 2021-11-16 16:00 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | shuehner | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | RR22Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0047989: Remove obsolete storeserver related code from posterminal | |||||||
| Description | Posterminal module still retains some code related to the obsolete storeserver project. As that is long obsolete it should be cleaned up. | |||||||
| Steps To Reproduce | grep -Iir storeserver | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||||||||||||||||||||
|
|||||||||||||||||||||||||||||||||
 Relationships |
|
Notes |
|
|
(0132845) shuehner (administrator) 2021-11-04 13:35 |
Blocking 47987 as POSLoginHandler overrides API to be removed from backoffice. |
|
(0132846) hgbot (developer) 2021-11-04 13:38 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/618 [^] |
|
(0133119) hgbot (developer) 2021-11-16 16:00 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: a8b154d85e1698ff900965003139f78a823e42d4 Author: Stefan Huehner <stefan.huehner@openbravo.com> Date: 2021-11-16T14:44:57+01:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/a8b154d85e1698ff900965003139f78a823e42d4 [^] Related to ISSUE-47989 Remove storeserver code from POSLoginHandler POSLoginHandler was overriding a flag from backoffice LoginHandler to not block WebPOS logins in a storeserver (where ERP logins are blocked). Remove that as obsolete code in preparation of removing the related backoffice code also (in 47987) --- M src/org/openbravo/retail/posterminal/POSLoginHandler.java --- |
|
(0133120) hgbot (developer) 2021-11-16 16:00 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: 1ea8241f90f19a270edc47833a9e7a8aabc515c9 Author: Stefan Huehner <stefan.huehner@openbravo.com> Date: 2021-11-16T14:44:57+01:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/1ea8241f90f19a270edc47833a9e7a8aabc515c9 [^] Related to ISSUE-47989 Remove obsolete storeserver code - AssociateOrderLines remove code conditional on isThisAStoreServer() which cannot be true anymore. After that nothing special left in the overriden exec so remove the whole method. - PaidReceipts remove code conditional on isThisAStoreServer() - PaidReceiptsFilter remove code conditional on isThisAStoreServer() Remove overriden exec method as does nothing special anymore - PendingOrderLines same, remove code conditional on isThisAStoreServer() and the whole exec method. --- M src/org/openbravo/retail/posterminal/AssociateOrderLines.java M src/org/openbravo/retail/posterminal/PaidReceipts.java M src/org/openbravo/retail/posterminal/PaidReceiptsFilter.java M src/org/openbravo/retail/posterminal/master/PendingOrderLines.java --- |
|
(0133121) hgbot (developer) 2021-11-16 16:00 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: 1040b00223cd35ce20298a28e47f8b15bb8d20fd Author: Stefan Huehner <stefan.huehner@openbravo.com> Date: 2021-11-16T14:45:04+01:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/1040b00223cd35ce20298a28e47f8b15bb8d20fd [^] Fixes ISSUE-47989 Remove more obsolete storeserver code Remove code conditional behind isMultiServerEnabled() which was only used in obsolete storeserver. Keep the json result property 'servers' in the two calls using it (initActions,preLogin) as js cleanup is separate step. --- M src/org/openbravo/retail/posterminal/LoginUtilsServlet.java --- |
|
(0133122) hgbot (developer) 2021-11-16 16:00 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/618 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2021-11-04 13:34 | shuehner | New Issue | |
| 2021-11-04 13:34 | shuehner | Assigned To | => shuehner |
| 2021-11-04 13:34 | shuehner | Triggers an Emergency Pack | => No |
| 2021-11-04 13:34 | shuehner | Relationship added | blocks 0047987 |
| 2021-11-04 13:35 | shuehner | Note Added: 0132845 | |
| 2021-11-04 13:38 | hgbot | Note Added: 0132846 | |
| 2021-11-06 10:41 | shuehner | Issue cloned | 0047998 |
| 2021-11-06 11:34 | shuehner | Issue cloned | 0048000 |
| 2021-11-06 11:34 | shuehner | Relationship added | blocks 0048000 |
| 2021-11-10 10:02 | shuehner | Status | new => scheduled |
| 2021-11-16 14:35 | shuehner | Relationship added | blocks 0048072 |
| 2021-11-16 14:35 | shuehner | Relationship added | blocks 0048073 |
| 2021-11-16 16:00 | hgbot | Note Added: 0133119 | |
| 2021-11-16 16:00 | hgbot | Note Added: 0133120 | |
| 2021-11-16 16:00 | hgbot | Resolution | open => fixed |
| 2021-11-16 16:00 | hgbot | Status | scheduled => closed |
| 2021-11-16 16:00 | hgbot | Fixed in Version | => RR22Q1 |
| 2021-11-16 16:00 | hgbot | Note Added: 0133121 | |
| 2021-11-16 16:00 | hgbot | Note Added: 0133122 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |