Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0047989Retail ModulesWeb POSpublic2021-11-04 13:342021-11-16 16:00
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR22Q1 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0047989: Remove obsolete storeserver related code from posterminal
DescriptionPosterminal module still retains some code related to the obsolete storeserver project.

As that is long obsolete it should be cleaned up.
Steps To Reproducegrep -Iir storeserver
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0047987 closed shuehner Openbravo ERP Remove obsolete storeserver related code from backoffice 
blocks defect 0048000 closed shuehner Retail Modules Remove obsolete storeserver related code from mobile.core 
blocks defect 0048072 closed shuehner Retail Modules Remove leftover isMultiServer and 'servers' references from posterminal 
blocks defect 0048073 closed shuehner Retail Modules Remove leftover isMultiServer and 'servers' references from mobile.core 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-11-04 13:34shuehnerNew Issue
2021-11-04 13:34shuehnerAssigned To => shuehner
2021-11-04 13:34shuehnerOBNetwork customer => No
2021-11-04 13:34shuehnerTriggers an Emergency Pack => No
2021-11-04 13:34shuehnerRelationship addedblocks 0047987
2021-11-04 13:35shuehnerNote Added: 0132845
2021-11-04 13:38hgbotMerge Request Status => open
2021-11-04 13:38hgbotNote Added: 0132846
2021-11-06 10:41shuehnerIssue cloned0047998
2021-11-06 11:34shuehnerIssue cloned0048000
2021-11-06 11:34shuehnerRelationship addedblocks 0048000
2021-11-10 10:02shuehnerStatusnew => scheduled
2021-11-11 07:43hgbotMerge Request Statusopen => approved
2021-11-11 07:46hgbotMerge Request Statusapproved => open
2021-11-16 14:35shuehnerRelationship addedblocks 0048072
2021-11-16 14:35shuehnerRelationship addedblocks 0048073
2021-11-16 15:45hgbotMerge Request Statusopen => approved
2021-11-16 16:00hgbotNote Added: 0133119
2021-11-16 16:00hgbotNote Added: 0133120
2021-11-16 16:00hgbotResolutionopen => fixed
2021-11-16 16:00hgbotStatusscheduled => closed
2021-11-16 16:00hgbotFixed in Version => RR22Q1
2021-11-16 16:00hgbotNote Added: 0133121
2021-11-16 16:00hgbotNote Added: 0133122

Notes
(0132845)
shuehner   
2021-11-04 13:35   
Blocking 47987 as POSLoginHandler overrides API to be removed from backoffice.
(0132846)
hgbot   
2021-11-04 13:38   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/618 [^]
(0133119)
hgbot   
2021-11-16 16:00   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: a8b154d85e1698ff900965003139f78a823e42d4
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 2021-11-16T14:44:57+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/a8b154d85e1698ff900965003139f78a823e42d4 [^]

Related to ISSUE-47989 Remove storeserver code from POSLoginHandler

POSLoginHandler was overriding a flag from backoffice LoginHandler to
not block WebPOS logins in a storeserver (where ERP logins are blocked).

Remove that as obsolete code in preparation of removing the related
backoffice code also (in 47987)

---
M src/org/openbravo/retail/posterminal/POSLoginHandler.java
---
(0133120)
hgbot   
2021-11-16 16:00   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 1ea8241f90f19a270edc47833a9e7a8aabc515c9
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 2021-11-16T14:44:57+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/1ea8241f90f19a270edc47833a9e7a8aabc515c9 [^]

Related to ISSUE-47989 Remove obsolete storeserver code

- AssociateOrderLines remove code conditional on isThisAStoreServer()
  which cannot be true anymore. After that nothing special left in the
  overriden exec so remove the whole method.
- PaidReceipts remove code conditional on isThisAStoreServer()
- PaidReceiptsFilter remove code conditional on isThisAStoreServer()
  Remove overriden exec method as does nothing special anymore
- PendingOrderLines same, remove code conditional on
  isThisAStoreServer() and the whole exec method.

---
M src/org/openbravo/retail/posterminal/AssociateOrderLines.java
M src/org/openbravo/retail/posterminal/PaidReceipts.java
M src/org/openbravo/retail/posterminal/PaidReceiptsFilter.java
M src/org/openbravo/retail/posterminal/master/PendingOrderLines.java
---
(0133121)
hgbot   
2021-11-16 16:00   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 1040b00223cd35ce20298a28e47f8b15bb8d20fd
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 2021-11-16T14:45:04+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/1040b00223cd35ce20298a28e47f8b15bb8d20fd [^]

Fixes ISSUE-47989 Remove more obsolete storeserver code

Remove code conditional behind isMultiServerEnabled() which was only
used in obsolete storeserver.
Keep the json result property 'servers' in the two calls using it
(initActions,preLogin) as js cleanup is separate step.

---
M src/org/openbravo/retail/posterminal/LoginUtilsServlet.java
---
(0133122)
hgbot   
2021-11-16 16:00   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/618 [^]