Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0048073 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Web POS | minor | have not tried | 2021-11-16 14:34 | 2021-12-02 14:49 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | shuehner | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | RR22Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | approved | |||||||
| Review Assigned To | ||||||||
| OBNetwork customer | No | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0048073: Remove leftover isMultiServer and 'servers' references from mobile.core | |||||||
| Description | This is follow up to issue 47989. This tracks the changes inside mobile.core module. After issue 47989 the 'servers' list send from the backend to the frontend will b e always empty. That allows to: - Remove it from the responses - Cleanup code/comments reading (empty) response and setting in localStorage - Remove code reading servers from localStorage and setting it in 'servers' list - Cleanup code calling isMultiServer (which is servers.size >1) - cleanup & remove method RequestRouter.ignoreManifestLoadError() (always false) | |||||||
| Steps To Reproduce | - | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||
|
|||||||||||||||
 Relationships |
|
Notes |
|
|
(0133480) hgbot (developer) 2021-12-02 12:14 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/306 [^] |
|
(0133486) hgbot (developer) 2021-12-02 14:49 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^] Changeset: 22b380bc38ee850fb29ea5fd1f67863f039a58be Author: Stefan Huehner <stefan.huehner@openbravo.com> Date: 2021-11-30T15:31:17+01:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/22b380bc38ee850fb29ea5fd1f67863f039a58be [^] Related to ISSUE-48073: Cleanup related to storeserver removal Issue 47989 removed server-side code to populate the 'servers' list in the reply of LoginUtilsServlet (it is always empty) This follows up cleanup up code now obsolete: - ob-terminal-model.js update comment to not mention servers list anymore - ob-requestrouter.js Remove code reading 'servers' from localStorage which is not set anymore by either ob-terminal-model.js (or login-model.js in posterminal). With no server being added to the list the servers list will only contain the single entry name: 'Default'. --- M web/org.openbravo.mobile.core/source/data/ob-requestrouter.js M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js --- |
|
(0133487) hgbot (developer) 2021-12-02 14:49 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^] Changeset: 62ffc4781dd717e4f901514b751b364ffe8d0fe9 Author: Stefan Huehner <stefan.huehner@openbravo.com> Date: 2021-11-30T15:45:13+01:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/62ffc4781dd717e4f901514b751b364ffe8d0fe9 [^] Related to ISSUE-48073: More code-cleanup related to storeserver removal - loginOnCentralServer does nothing with isMultiServer() = false always Also the only call from posterminal is removed in 48072 Delete the method - That allows to also delete the now unused callCentralServer and callServer methods --- M web/org.openbravo.mobile.core/source/utils/ob-utilities.js --- |
|
(0133488) hgbot (developer) 2021-12-02 14:49 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^] Changeset: 4555984b799ed4703fc1ad753115e394f59fecf7 Author: Stefan Huehner <stefan.huehner@openbravo.com> Date: 2021-12-02T14:30:15+01:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/4555984b799ed4703fc1ad753115e394f59fecf7 [^] Fixes ISSUE-48073: More code-cleanup related to storeserver removal - ignoreManifestLoadError delete function as will always return false and only user is removed in issue 48072 - isMultiServer() will always return false now with only a single name: 'Default' entry present in OB.RR.RequestRouter.servers list - Cleanup any usage of that function - checkFireOnlineNotification does nothing after this cleanup remove the function and the single call into it - Cleaning up setInterval(offlinePing) make the preference OBMOBC_RequestRouterPingTime obsolete. Remove it entirely. --- M src-db/database/sourcedata/AD_REF_LIST.xml M web/org.openbravo.mobile.core/source/data/ob-requestrouter.js --- |
|
(0133489) hgbot (developer) 2021-12-02 14:49 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/306 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2021-11-16 14:34 | shuehner | New Issue | |
| 2021-11-16 14:34 | shuehner | Assigned To | => Retail |
| 2021-11-16 14:34 | shuehner | OBNetwork customer | => No |
| 2021-11-16 14:34 | shuehner | Triggers an Emergency Pack | => No |
| 2021-11-16 14:34 | shuehner | Issue generated from | 0048072 |
| 2021-11-16 14:34 | shuehner | Relationship added | depends on 0048072 |
| 2021-11-16 14:35 | shuehner | Relationship added | depends on 0047989 |
| 2021-12-02 12:14 | hgbot | Merge Request Status | => open |
| 2021-12-02 12:14 | hgbot | Note Added: 0133480 | |
| 2021-12-02 14:20 | hgbot | Merge Request Status | open => approved |
| 2021-12-02 14:45 | shuehner | Assigned To | Retail => shuehner |
| 2021-12-02 14:49 | hgbot | Note Added: 0133486 | |
| 2021-12-02 14:49 | hgbot | Note Added: 0133487 | |
| 2021-12-02 14:49 | hgbot | Resolution | open => fixed |
| 2021-12-02 14:49 | hgbot | Status | new => closed |
| 2021-12-02 14:49 | hgbot | Fixed in Version | => RR22Q1 |
| 2021-12-02 14:49 | hgbot | Note Added: 0133488 | |
| 2021-12-02 14:49 | hgbot | Note Added: 0133489 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |