Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0048072 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Web POS | minor | have not tried | 2021-11-16 14:34 | 2021-12-02 14:49 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | shuehner | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | RR22Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0048072: Remove leftover isMultiServer and 'servers' references from posterminal | |||||||
| Description | This is follow up to issue 47989. This tracks the changes inside posterminal module. After issue 47989 the 'servers' list send from the backend to the frontend will b e always empty. That allows to: - Remove it from the responses - Cleanup code/comments reading (empty) response and setting in localStorage - Remove code reading servers from localStorage and setting it in 'servers' list - Cleanup code calling isMultiServer (which is servers.size >1) - cleanup & remove method RequestRouter.ignoreManifestLoadError() (always false) | |||||||
| Steps To Reproduce | - | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||||||||||||||||
|
||||||||||||||||||||||
 Relationships |
|
Notes |
|
|
(0133481) hgbot (developer) 2021-12-02 12:21 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/649 [^] |
|
(0133482) hgbot (developer) 2021-12-02 14:49 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/649 [^] |
|
(0133483) hgbot (developer) 2021-12-02 14:49 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: 26b404d903f3d6c90d732c43ca96fe77bf945458 Author: Stefan Huehner <stefan.huehner@openbravo.com> Date: 2021-12-02T14:31:48+01:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/26b404d903f3d6c90d732c43ca96fe77bf945458 [^] Related to ISSUE-48072: Cleanup related to storeserver removal Issue 47989 removed server-side code to populate the 'servers' list in the reply of LoginUtilsServlet (it is always empty) This follows up to remove setting the empty list and updates a client side config to not mention it anymore (when storing the response data in the localStorage). --- M src/org/openbravo/retail/posterminal/LoginUtilsServlet.java M web/org.openbravo.retail.posterminal/js/login/model/login-model.js --- |
|
(0133484) hgbot (developer) 2021-12-02 14:49 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: abb576db733a70e0406544417fe519e436dc6633 Author: Stefan Huehner <stefan.huehner@openbravo.com> Date: 2021-12-02T14:31:48+01:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/abb576db733a70e0406544417fe519e436dc6633 [^] Related to ISSUE-48072: More unused code removal related to storeserver With changes from 47989 and 47073 the isMultiServer() function from mobile.core will always return false. Cleanup code made obsolete by this: - calling loginOnCentralServer() behind this condition - call to RequestRouter.ignoreManifestLoadError() which also will only return false --- M web/org.openbravo.retail.posterminal/js/login/model/login-model.js --- |
|
(0133485) hgbot (developer) 2021-12-02 14:49 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: 68be8ed2aefbca8c33cd2622350c35e7ff86eb57 Author: Stefan Huehner <stefan.huehner@openbravo.com> Date: 2021-12-02T14:31:48+01:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/68be8ed2aefbca8c33cd2622350c35e7ff86eb57 [^] Fixes ISSUE-48072: More unused code removal related to storeserver In backoffice button inside the WebPOS skip searching for mainServer from servers list. Without storeserver the this.url is the correct url to use already (as will be just the same server) --- M web/org.openbravo.retail.posterminal/js/components/menu.js --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2021-11-16 14:34 | shuehner | New Issue | |
| 2021-11-16 14:34 | shuehner | Assigned To | => Retail |
| 2021-11-16 14:34 | shuehner | Triggers an Emergency Pack | => No |
| 2021-11-16 14:34 | shuehner | Issue cloned | 0048073 |
| 2021-11-16 14:34 | shuehner | Relationship added | blocks 0048073 |
| 2021-11-16 14:35 | shuehner | Relationship added | depends on 0047989 |
| 2021-12-02 12:21 | hgbot | Note Added: 0133481 | |
| 2021-12-02 14:45 | shuehner | Relationship added | related to 0048190 |
| 2021-12-02 14:45 | shuehner | Assigned To | Retail => shuehner |
| 2021-12-02 14:49 | hgbot | Note Added: 0133482 | |
| 2021-12-02 14:49 | hgbot | Note Added: 0133483 | |
| 2021-12-02 14:49 | hgbot | Note Added: 0133484 | |
| 2021-12-02 14:49 | hgbot | Resolution | open => fixed |
| 2021-12-02 14:49 | hgbot | Status | new => closed |
| 2021-12-02 14:49 | hgbot | Fixed in Version | => RR22Q1 |
| 2021-12-02 14:49 | hgbot | Note Added: 0133485 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |