Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048072Retail ModulesWeb POSpublic2021-11-16 14:342021-12-02 14:49
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR22Q1 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0048072: Remove leftover isMultiServer and 'servers' references from posterminal
DescriptionThis is follow up to issue 47989.
This tracks the changes inside posterminal module.

After issue 47989 the 'servers' list send from the backend to the frontend will b e always empty.

That allows to:
- Remove it from the responses
- Cleanup code/comments reading (empty) response and setting in localStorage
- Remove code reading servers from localStorage and setting it in 'servers' list
- Cleanup code calling isMultiServer (which is servers.size >1)
- cleanup & remove method RequestRouter.ignoreManifestLoadError() (always false)
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0048190 closed shuehner api-change related to storeserver code-cleanup 
depends on defect 0047989 closed shuehner Remove obsolete storeserver related code from posterminal 
blocks defect 0048073 closed shuehner Remove leftover isMultiServer and 'servers' references from mobile.core 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-11-16 14:34shuehnerNew Issue
2021-11-16 14:34shuehnerAssigned To => Retail
2021-11-16 14:34shuehnerOBNetwork customer => No
2021-11-16 14:34shuehnerTriggers an Emergency Pack => No
2021-11-16 14:34shuehnerIssue cloned0048073
2021-11-16 14:34shuehnerRelationship addedblocks 0048073
2021-11-16 14:35shuehnerRelationship addeddepends on 0047989
2021-12-02 12:21hgbotMerge Request Status => open
2021-12-02 12:21hgbotNote Added: 0133481
2021-12-02 14:14hgbotMerge Request Statusopen => approved
2021-12-02 14:45shuehnerRelationship addedrelated to 0048190
2021-12-02 14:45shuehnerAssigned ToRetail => shuehner
2021-12-02 14:49hgbotNote Added: 0133482
2021-12-02 14:49hgbotNote Added: 0133483
2021-12-02 14:49hgbotNote Added: 0133484
2021-12-02 14:49hgbotResolutionopen => fixed
2021-12-02 14:49hgbotStatusnew => closed
2021-12-02 14:49hgbotFixed in Version => RR22Q1
2021-12-02 14:49hgbotNote Added: 0133485

Notes
(0133481)
hgbot   
2021-12-02 12:21   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/649 [^]
(0133482)
hgbot   
2021-12-02 14:49   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/649 [^]
(0133483)
hgbot   
2021-12-02 14:49   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 26b404d903f3d6c90d732c43ca96fe77bf945458
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 2021-12-02T14:31:48+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/26b404d903f3d6c90d732c43ca96fe77bf945458 [^]

Related to ISSUE-48072: Cleanup related to storeserver removal

Issue 47989 removed server-side code to populate the 'servers' list in
the reply of LoginUtilsServlet (it is always empty)

This follows up to remove setting the empty list and updates a client
side config to not mention it anymore (when storing the response data in
the localStorage).

---
M src/org/openbravo/retail/posterminal/LoginUtilsServlet.java
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
---
(0133484)
hgbot   
2021-12-02 14:49   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: abb576db733a70e0406544417fe519e436dc6633
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 2021-12-02T14:31:48+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/abb576db733a70e0406544417fe519e436dc6633 [^]

Related to ISSUE-48072: More unused code removal related to storeserver

With changes from 47989 and 47073 the isMultiServer() function from
mobile.core will always return false.
Cleanup code made obsolete by this:
- calling loginOnCentralServer() behind this condition
- call to RequestRouter.ignoreManifestLoadError() which
  also will only return false

---
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
---
(0133485)
hgbot   
2021-12-02 14:49   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 68be8ed2aefbca8c33cd2622350c35e7ff86eb57
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 2021-12-02T14:31:48+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/68be8ed2aefbca8c33cd2622350c35e7ff86eb57 [^]

Fixes ISSUE-48072: More unused code removal related to storeserver

In backoffice button inside the WebPOS skip searching for mainServer
from servers list. Without storeserver the this.url is the correct url
to use already (as will be just the same server)

---
M web/org.openbravo.retail.posterminal/js/components/menu.js
---