Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0047987 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | minor | have not tried | 2021-11-04 12:58 | 2022-01-10 08:37 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | shuehner | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | PR22Q2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0047987: Remove obsolete storeserver related code from backoffice | |||||||
| Description | Login flow still has some code to 'Restrict backoffice access for storeservers'. Storeserver is long obsolete so that code should be removed as cleanup. | |||||||
| Steps To Reproduce | in backoffice workspace grep -Iir storeserver | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||||||||||||
|
|||||||||||||||||||||||||
 Relationships |
|
Notes |
|
|
(0132880) hgbot (developer) 2021-11-06 11:47 |
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/451 [^] |
|
(0134156) hgbot (developer) 2022-01-10 08:37 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: 34da82586f3de4ae8ec2c2b22d34e5d12825c927 Author: Stefan Huehner <stefan.huehner@openbravo.com> Date: 10-01-2022 08:12:58 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/34da82586f3de4ae8ec2c2b22d34e5d12825c927 [^] Fixes ISSUE-47987 Remove obsolete storeserver code This removes obsolete code leftover from the storeserver project. Specifically the isLoginAccessRestrictedInStoreServer() code which allowed to prevent backoffice logins in a storeserver. As the isThisAStoreServer() condition cannot be true any it is just dead code - LoginHandler remove all code conditional on isThisAStoreServer() - Also remove vars.removeSessionValue("OnlySystemAdminAccess") as that session value name is not referenced anywhere else at all so it seems to have no purpose. - Remove the "RestrictErpAccessInStoreServer" preference completely and also it being cached in CachedPreferences - Finally remove the ServerControllerHandler and ServerController logic as it was only useful in context of the storeserver project. --- M modules/org.openbravo.client.application/src/org/openbravo/client/application/CachedPreference.java M src-db/database/sourcedata/AD_REF_LIST.xml M src/org/openbravo/base/secureApp/LoginHandler.java R src/org/openbravo/server/ServerController.java R src/org/openbravo/server/ServerControllerHandler.java --- |
|
(0134157) hgbot (developer) 2022-01-10 08:37 |
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/451 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2021-11-04 12:58 | shuehner | New Issue | |
| 2021-11-04 12:58 | shuehner | Assigned To | => shuehner |
| 2021-11-04 12:58 | shuehner | Modules | => Core |
| 2021-11-04 12:58 | shuehner | Triggers an Emergency Pack | => No |
| 2021-11-04 13:34 | shuehner | Relationship added | depends on 0047989 |
| 2021-11-06 11:34 | shuehner | Relationship added | depends on 0048000 |
| 2021-11-06 11:47 | hgbot | Note Added: 0132880 | |
| 2022-01-10 07:56 | alostale | Relationship added | depends on 0048363 |
| 2022-01-10 08:37 | hgbot | Resolution | open => fixed |
| 2022-01-10 08:37 | hgbot | Status | new => closed |
| 2022-01-10 08:37 | hgbot | Fixed in Version | => PR22Q2 |
| 2022-01-10 08:37 | hgbot | Note Added: 0134156 | |
| 2022-01-10 08:37 | hgbot | Note Added: 0134157 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |