Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0036756

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Web POS

major

always

2017-08-31 11:10

2017-09-15 13:03

Reporter

umartirena

View Status

public

Assigned To

ranjith_qualiantech_com

Priority

immediate

Resolution

fixed

Fixed in Version

RR17Q4

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

OBPS

Support ticket

48236

Regression level

Production - Confirmed Stable

Regression date

2015-10-26

Regression introduced in release

RR16Q2

Regression introduced by commit

https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/diff/6c588264876f/web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js [^]

Triggers an Emergency Pack

No

Summary

0036756: Caller variable sent as parameter to OBPOS_CheckPaymentApproval hook has changed

Description

Caller variable sent as parameter to OBPOS_CheckPaymentApproval hook has changed.

Now, the following code executed inside the hook, that previously was working, fails:

args.caller.doShowPopup({
      popup: 'bpartnerselector',
      args: {
        bp: args.context.get('order').get('bp'),
        caller: args.caller
      }
    });

Steps To Reproduce

In a RR17Q3 add the following hook programatically:

OB.UTIL.HookManager.registerHook('OBPOS_CheckPaymentApproval', function (args, callbacks) {
  OB.UTIL.HookManager.callbackExecutor(args, callbacks);
    args.caller.doShowPopup({
      popup: 'bpartnerselector',
      args: {
        bp: args.context.get('order').get('bp'),
        caller: args.caller
      }
    });
});

Login to web pos.
Add a product.
Click on Total Amount Button.
The following javascript issue is raised:

8d29ca2….js:79406 Uncaught TypeError: args.caller.doShowPopup is not a function
    at 8d29ca2….js:79406
    at G.d.callbackExecutor (8d29ca2….js:12190)
    at 8d29ca2….js:75205
    at G.d.callbackExecutor (8d29ca2….js:12190)
    at callback (8d29ca2….js:24956)
    at 8d29ca2….js:24962
    at G.d.callbackExecutor (8d29ca2….js:12190)
    at G.d.executeHooks (8d29ca2….js:12179)
    at G.d.checkPaymentApproval (8d29ca2….js:53189)
    at 8d29ca2….js:53177

Proposed Solution

Find attached patch

Tags

No tags attached.

toolbarLeftFix.diff [^] (858 bytes) 2017-08-31 11:10 [Show Content] [Hide Content]

diff --git a/web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js b/web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
--- a/web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
+++ b/web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
@@ -501,12 +501,12 @@
             me.doClearUserInput();
           });
         } else {
-          me.model.completePayment(this);
+          me.model.completePayment(me);
           me.doClearUserInput();
         }
         OB.UTIL.SynchronizationHelper.finished(synchId, 'toolbarButtonTabTap');
       }, function (trx, error) {
-        me.model.completePayment(this);
+        me.model.completePayment(me);
         me.doClearUserInput();
         OB.UTIL.SynchronizationHelper.finished(synchId, 'toolbarButtonTabTap');
       });

Relationships [ Relation Graph ] [ Dependency Graph ]

depends on	backport	0036867	RR17Q3.1	closed	ranjith_qualiantech_com	Caller variable sent as parameter to OBPOS_CheckPaymentApproval hook has changed
depends on	backport	0036868	RR17Q2.4	closed	ranjith_qualiantech_com	Caller variable sent as parameter to OBPOS_CheckPaymentApproval hook has changed

Notes
(0098887) hgbot (developer) 2017-09-07 13:58	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: e4725c9784813538d6fccd23287f074f04e0f50c Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Thu Sep 07 17:26:59 2017 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e4725c9784813538d6fccd23287f074f04e0f50c [^] Fixed issue 36756 : Caller reference changes to Toal Amount Button * For OBPOS_PrePaymentHook & OBPOS_PrePaymentApproval, caller reference is changed to Total Amount Button --- M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js ---

Issue History
Date Modified	Username	Field	Change
2017-08-31 11:10	umartirena	New Issue
2017-08-31 11:10	umartirena	Assigned To	=> Retail
2017-08-31 11:10	umartirena	File Added: toolbarLeftFix.diff
2017-08-31 11:10	umartirena	OBNetwork customer	=> No
2017-08-31 11:10	umartirena	Regression level	=> Production - Confirmed Stable
2017-08-31 11:10	umartirena	Regression date	=> 2015-10-26
2017-08-31 11:10	umartirena	Regression introduced in release	=> RR16Q2
2017-08-31 11:10	umartirena	Regression introduced by commit	=> https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/diff/6c588264876f/web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js [^]
2017-08-31 11:10	umartirena	Triggers an Emergency Pack	=> No
2017-08-31 12:44	umartirena	OBNetwork customer	No => Yes
2017-08-31 12:49	ngarcia	Support ticket	=> 48236
2017-08-31 12:49	ngarcia	Resolution time	=> 1505944800
2017-08-31 12:49	ngarcia	Priority	high => immediate
2017-08-31 12:49	ngarcia	Issue Monitored: networkb
2017-08-31 14:12	ngarcia	Issue Monitored: ngarcia
2017-09-07 11:28	ranjith_qualiantech_com	Assigned To	Retail => ranjith_qualiantech_com
2017-09-07 11:28	ranjith_qualiantech_com	Status	new => scheduled
2017-09-07 13:58	hgbot	Checkin
2017-09-07 13:58	hgbot	Note Added: 0098887
2017-09-07 13:58	hgbot	Status	scheduled => resolved
2017-09-07 13:58	hgbot	Resolution	open => fixed
2017-09-07 13:58	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e4725c9784813538d6fccd23287f074f04e0f50c [^]
2017-09-15 13:01	marvintm	Review Assigned To	=> marvintm
2017-09-15 13:01	marvintm	Status	resolved => closed
2017-09-15 13:01	marvintm	Fixed in Version	=> RR17Q4
2017-09-15 13:02	marvintm	Status	closed => new
2017-09-15 13:02	marvintm	Resolution	fixed => open
2017-09-15 13:02	marvintm	Fixed in Version	RR17Q4 =>
2017-09-15 13:03	marvintm	Status	new => scheduled
2017-09-15 13:03	marvintm	Status	scheduled => resolved
2017-09-15 13:03	marvintm	Fixed in Version	=> RR17Q4
2017-09-15 13:03	marvintm	Resolution	open => fixed
2017-09-15 13:03	marvintm	Status	resolved => closed

Copyright © 2000 - 2009 MantisBT Group