Anonymous | Login
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Retail Modules] Web POSmajoralways2017-08-31 11:102017-10-31 09:18
ReporterumartirenaView Statuspublic 
Assigned Toranjith_qualiantech_com 
PriorityimmediateResolutionfixedFixed in VersionRR17Q2.4
StatusclosedFix in branchFixed in SCM revisiona7ce3e4e8b7a
ProjectionnoneETAnoneTarget VersionRR17Q2.4
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression levelProduction - Confirmed Stable
Regression date2015-10-26
Regression introduced in releaseRR16Q2
Regression introduced by commit [^]
Triggers an Emergency PackNo

0036868: Caller variable sent as parameter to OBPOS_CheckPaymentApproval hook has changed

DescriptionCaller variable sent as parameter to OBPOS_CheckPaymentApproval hook has changed.

Now, the following code executed inside the hook, that previously was working, fails:

      popup: 'bpartnerselector',
      args: {
        bp: args.context.get('order').get('bp'),
        caller: args.caller
Steps To ReproduceIn a RR17Q3 add the following hook programatically:

OB.UTIL.HookManager.registerHook('OBPOS_CheckPaymentApproval', function (args, callbacks) {
  OB.UTIL.HookManager.callbackExecutor(args, callbacks);
      popup: 'bpartnerselector',
      args: {
        bp: args.context.get('order').get('bp'),
        caller: args.caller

Login to web pos.
Add a product.
Click on Total Amount Button.
The following javascript issue is raised:

8d29ca2….js:79406 Uncaught TypeError: args.caller.doShowPopup is not a function
    at 8d29ca2….js:79406
    at G.d.callbackExecutor (8d29ca2….js:12190)
    at 8d29ca2….js:75205
    at G.d.callbackExecutor (8d29ca2….js:12190)
    at callback (8d29ca2….js:24956)
    at 8d29ca2….js:24962
    at G.d.callbackExecutor (8d29ca2….js:12190)
    at G.d.executeHooks (8d29ca2….js:12179)
    at G.d.checkPaymentApproval (8d29ca2….js:53189)
    at 8d29ca2….js:53177
Proposed SolutionFind attached patch
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
blocks defect 0036756 closedranjith_qualiantech_com Caller variable sent as parameter to OBPOS_CheckPaymentApproval hook has changed 

-  Notes
hgbot (developer)
2017-09-21 11:59

Repository: retail/backports/3.0RR17Q2.4/org.openbravo.retail.posterminal
Changeset: a7ce3e4e8b7aab55ff966199e1e675509cda8588
Author: Ranjith S R <ranjith <at>>
Date: Thu Sep 21 15:09:29 2017 +0530
URL: [^]

Fixed issue 36868 : Caller reference changes to Toal Amount Button

* For OBPOS_PrePaymentHook & OBPOS_PrePaymentApproval, caller reference is changed to Total Amount Button

M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js

- Issue History
Date Modified Username Field Change
2017-09-15 13:03 marvintm Type defect => backport
2017-09-15 13:03 marvintm Target Version => RR17Q2.4
2017-09-21 11:59 hgbot Checkin
2017-09-21 11:59 hgbot Note Added: 0099206
2017-09-21 11:59 hgbot Status scheduled => resolved
2017-09-21 11:59 hgbot Resolution open => fixed
2017-09-21 11:59 hgbot Fixed in SCM revision [^] => [^]
2017-10-31 09:18 marvintm Status resolved => closed
2017-10-31 09:18 marvintm Fixed in Version => RR17Q2.4

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker