0036867: Caller variable sent as parameter to OBPOS_CheckPaymentApproval hook has changed

Description

Caller variable sent as parameter to OBPOS_CheckPaymentApproval hook has changed.

Now, the following code executed inside the hook, that previously was working, fails:

args.caller.doShowPopup({
      popup: 'bpartnerselector',
      args: {
        bp: args.context.get('order').get('bp'),
        caller: args.caller
      }
    });

Steps To Reproduce

In a RR17Q3 add the following hook programatically:

OB.UTIL.HookManager.registerHook('OBPOS_CheckPaymentApproval', function (args, callbacks) {
  OB.UTIL.HookManager.callbackExecutor(args, callbacks);
    args.caller.doShowPopup({
      popup: 'bpartnerselector',
      args: {
        bp: args.context.get('order').get('bp'),
        caller: args.caller
      }
    });
});

Login to web pos.
Add a product.
Click on Total Amount Button.
The following javascript issue is raised:

8d29ca2….js:79406 Uncaught TypeError: args.caller.doShowPopup is not a function
    at 8d29ca2….js:79406
    at G.d.callbackExecutor (8d29ca2….js:12190)
    at 8d29ca2….js:75205
    at G.d.callbackExecutor (8d29ca2….js:12190)
    at callback (8d29ca2….js:24956)
    at 8d29ca2….js:24962
    at G.d.callbackExecutor (8d29ca2….js:12190)
    at G.d.executeHooks (8d29ca2….js:12179)
    at G.d.checkPaymentApproval (8d29ca2….js:53189)
    at 8d29ca2….js:53177

Proposed Solution

Find attached patch

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0036756

closed

ranjith_qualiantech_com

Caller variable sent as parameter to OBPOS_CheckPaymentApproval hook has changed

Notes
(0099205) hgbot (developer) 2017-09-21 11:59	Repository: retail/backports/3.0RR17Q3.1/org.openbravo.retail.posterminal Changeset: c65ce6ca69012e9c2d224dbcaf4e91b797f6ccda Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Thu Sep 21 15:09:25 2017 +0530 URL: http://code.openbravo.com/retail/backports/3.0RR17Q3.1/org.openbravo.retail.posterminal/rev/c65ce6ca69012e9c2d224dbcaf4e91b797f6ccda [^] Fixed issue 36867 : Caller reference changes to Toal Amount Button * For OBPOS_PrePaymentHook & OBPOS_PrePaymentApproval, caller reference is changed to Total Amount Button --- M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js ---

Issue History
Date Modified	Username	Field	Change
2017-09-15 13:03	marvintm	Type	defect => backport
2017-09-15 13:03	marvintm	Target Version	=> RR17Q3.1
2017-09-21 11:59	hgbot	Checkin
2017-09-21 11:59	hgbot	Note Added: 0099205
2017-09-21 11:59	hgbot	Status	scheduled => resolved
2017-09-21 11:59	hgbot	Resolution	open => fixed
2017-09-21 11:59	hgbot	Fixed in SCM revision	http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e4725c9784813538d6fccd23287f074f04e0f50c [^] => http://code.openbravo.com/retail/backports/3.0RR17Q3.1/org.openbravo.retail.posterminal/rev/c65ce6ca69012e9c2d224dbcaf4e91b797f6ccda [^]
2017-10-31 09:18	marvintm	Status	resolved => closed
2017-10-31 09:18	marvintm	Fixed in Version	=> RR17Q2.4