Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036756Retail ModulesWeb POSpublic2017-08-31 11:102017-09-15 13:03
Reporterumartirena 
Assigned Toranjith_qualiantech_com 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket48236
Regression levelProduction - Confirmed Stable
Regression date2015-10-26
Regression introduced in releaseRR16Q2
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/diff/6c588264876f/web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js [^]
Triggers an Emergency PackNo
Summary0036756: Caller variable sent as parameter to OBPOS_CheckPaymentApproval hook has changed
DescriptionCaller variable sent as parameter to OBPOS_CheckPaymentApproval hook has changed.

Now, the following code executed inside the hook, that previously was working, fails:

args.caller.doShowPopup({
      popup: 'bpartnerselector',
      args: {
        bp: args.context.get('order').get('bp'),
        caller: args.caller
      }
    });
Steps To ReproduceIn a RR17Q3 add the following hook programatically:

OB.UTIL.HookManager.registerHook('OBPOS_CheckPaymentApproval', function (args, callbacks) {
  OB.UTIL.HookManager.callbackExecutor(args, callbacks);
    args.caller.doShowPopup({
      popup: 'bpartnerselector',
      args: {
        bp: args.context.get('order').get('bp'),
        caller: args.caller
      }
    });
});

Login to web pos.
Add a product.
Click on Total Amount Button.
The following javascript issue is raised:


8d29ca2….js:79406 Uncaught TypeError: args.caller.doShowPopup is not a function
    at 8d29ca2….js:79406
    at G.d.callbackExecutor (8d29ca2….js:12190)
    at 8d29ca2….js:75205
    at G.d.callbackExecutor (8d29ca2….js:12190)
    at callback (8d29ca2….js:24956)
    at 8d29ca2….js:24962
    at G.d.callbackExecutor (8d29ca2….js:12190)
    at G.d.executeHooks (8d29ca2….js:12179)
    at G.d.checkPaymentApproval (8d29ca2….js:53189)
    at 8d29ca2….js:53177
Proposed SolutionFind attached patch
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0036867RR17Q3.1 closed ranjith_qualiantech_com Caller variable sent as parameter to OBPOS_CheckPaymentApproval hook has changed 
depends on backport 0036868RR17Q2.4 closed ranjith_qualiantech_com Caller variable sent as parameter to OBPOS_CheckPaymentApproval hook has changed 
Attached Filesdiff toolbarLeftFix.diff (858) 2017-08-31 11:10
https://issues.openbravo.com/file_download.php?file_id=11026&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-08-31 11:10umartirenaNew Issue
2017-08-31 11:10umartirenaAssigned To => Retail
2017-08-31 11:10umartirenaFile Added: toolbarLeftFix.diff
2017-08-31 11:10umartirenaOBNetwork customer => No
2017-08-31 11:10umartirenaRegression level => Production - Confirmed Stable
2017-08-31 11:10umartirenaRegression date => 2015-10-26
2017-08-31 11:10umartirenaRegression introduced in release => RR16Q2
2017-08-31 11:10umartirenaRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/diff/6c588264876f/web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js [^]
2017-08-31 11:10umartirenaTriggers an Emergency Pack => No
2017-08-31 12:44umartirenaOBNetwork customerNo => Yes
2017-08-31 12:49ngarciaSupport ticket => 48236
2017-08-31 12:49ngarciaResolution time => 1505944800
2017-08-31 12:49ngarciaPriorityhigh => immediate
2017-08-31 12:49ngarciaIssue Monitored: networkb
2017-08-31 14:12ngarciaIssue Monitored: ngarcia
2017-09-07 11:28ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2017-09-07 11:28ranjith_qualiantech_comStatusnew => scheduled
2017-09-07 13:58hgbotCheckin
2017-09-07 13:58hgbotNote Added: 0098887
2017-09-07 13:58hgbotStatusscheduled => resolved
2017-09-07 13:58hgbotResolutionopen => fixed
2017-09-07 13:58hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e4725c9784813538d6fccd23287f074f04e0f50c [^]
2017-09-15 13:01marvintmReview Assigned To => marvintm
2017-09-15 13:01marvintmStatusresolved => closed
2017-09-15 13:01marvintmFixed in Version => RR17Q4
2017-09-15 13:02marvintmStatusclosed => new
2017-09-15 13:02marvintmResolutionfixed => open
2017-09-15 13:02marvintmFixed in VersionRR17Q4 =>
2017-09-15 13:03marvintmStatusnew => scheduled
2017-09-15 13:03marvintmStatusscheduled => resolved
2017-09-15 13:03marvintmFixed in Version => RR17Q4
2017-09-15 13:03marvintmResolutionopen => fixed
2017-09-15 13:03marvintmStatusresolved => closed

Notes
(0098887)
hgbot   
2017-09-07 13:58   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e4725c9784813538d6fccd23287f074f04e0f50c
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Sep 07 17:26:59 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e4725c9784813538d6fccd23287f074f04e0f50c [^]

Fixed issue 36756 : Caller reference changes to Toal Amount Button

* For OBPOS_PrePaymentHook & OBPOS_PrePaymentApproval, caller reference is changed to Total Amount Button

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
---