0036756: Caller variable sent as parameter to OBPOS_CheckPaymentApproval hook has changed

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0036756

Retail Modules

Web POS

public

2017-08-31 11:10

2017-09-15 13:03

Reporter

umartirena

Assigned To

ranjith_qualiantech_com

Priority

immediate

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

RR17Q4

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

Support ticket

Regression level

Production - Confirmed Stable

Regression date

2015-10-26

Regression introduced in release

RR16Q2

Regression introduced by commit

https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/diff/6c588264876f/web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js [^]

Triggers an Emergency Pack

Summary

0036756: Caller variable sent as parameter to OBPOS_CheckPaymentApproval hook has changed

Description

Caller variable sent as parameter to OBPOS_CheckPaymentApproval hook has changed.

Now, the following code executed inside the hook, that previously was working, fails:

args.caller.doShowPopup({
      popup: 'bpartnerselector',
      args: {
        bp: args.context.get('order').get('bp'),
        caller: args.caller
      }
    });

Steps To Reproduce

In a RR17Q3 add the following hook programatically:

OB.UTIL.HookManager.registerHook('OBPOS_CheckPaymentApproval', function (args, callbacks) {
  OB.UTIL.HookManager.callbackExecutor(args, callbacks);
    args.caller.doShowPopup({
      popup: 'bpartnerselector',
      args: {
        bp: args.context.get('order').get('bp'),
        caller: args.caller
      }
    });
});

Login to web pos.
Add a product.
Click on Total Amount Button.
The following javascript issue is raised:

8d29ca2….js:79406 Uncaught TypeError: args.caller.doShowPopup is not a function
    at 8d29ca2….js:79406
    at G.d.callbackExecutor (8d29ca2….js:12190)
    at 8d29ca2….js:75205
    at G.d.callbackExecutor (8d29ca2….js:12190)
    at callback (8d29ca2….js:24956)
    at 8d29ca2….js:24962
    at G.d.callbackExecutor (8d29ca2….js:12190)
    at G.d.executeHooks (8d29ca2….js:12179)
    at G.d.checkPaymentApproval (8d29ca2….js:53189)
    at 8d29ca2….js:53177

Proposed Solution

Find attached patch

Additional Information

Tags

No tags attached.

Relationships

depends on	backport	0036867	RR17Q3.1	closed	ranjith_qualiantech_com	Caller variable sent as parameter to OBPOS_CheckPaymentApproval hook has changed
depends on	backport	0036868	RR17Q2.4	closed	ranjith_qualiantech_com	Caller variable sent as parameter to OBPOS_CheckPaymentApproval hook has changed