Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0036221
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSminorhave not tried2017-06-09 14:132018-09-20 18:44
ReporterlmonrealView Statuspublic 
Assigned Toebecerra 
PrioritynormalResolutionfixedFixed in VersionRR17Q4
StatusclosedFix in branchFixed in SCM revision9d3385757b9a
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toguilleaer
Regression levelProduction - Confirmed Stable
Regression date2017-12-19
Regression introduced in releaseRR17Q1
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/da460c83b37c [^]
Triggers an Emergency PackNo
Summary

0036221: In some of the pop ups of WEBPOS for 17Q2 the focus is not on the first input field

DescriptionIn some of the pop ups of WEBPOS for 17Q2 the focus is not on the first input field and previously in 16Q4 it was.
Steps To Reproduce1. Open webpos
2. Click receipt properties
3.In the pop up the focus is not there, it should be in Description field
Proposed SolutionIn 17Q1 this change
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/da460c83b37c [^]
Created a problem -> Set focus is not working at all (It just work when the element selected to be the focus is also marked at default action. This is common in popups which does not have inputs and just have one button)

In 17Q2 this change:
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/68def0094634 [^]
Has mittigated the problem introduced in 17Q1, but it is also not working fine. With that change, set Focus will work fine if there are no buttons marked as default action (in this case focus will be put in the first valid input or in the field marked as first focus), but if there is one component marked as default action it will take the focus.


EXPECTED BEHAVIOR.
- Default action: Means that when "intro" is presed when popup is opened this action should be executed
- First focus: Means that a component will pick the focus.
- If there is not first focus then, we will select the focus based on the tag. We will set the focus for the first component found with the tag 'INPUT' || 'SELECT' || 'TEXTAREA' || 'BUTTON' which is being shown.

If both methods above have failed to pick an element to be focused, the we will try to set the focus in the component which is in marked as default action (if it exists)

Summary:
Iterate components of the popup {
save first component visible with valid tag as a candidate
save defaultActionCandidate if found
overwrite candidate if first focused is found
}
if (!candidate) {
  candidate = defaultActionCandidate
}

TagsNo tags attached.
Attached Filespng file icon Selection_096.png [^] (83,468 bytes) 2017-06-25 13:08

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 0036264RR17Q2.2 closedRetail In some of the pop ups of WEBPOS for 17Q2 the focus is not on the first input field 
depends on backport 0036265RR17Q1.3 closedRetail In some of the pop ups of WEBPOS for 17Q2 the focus is not on the first input field 
caused by design defect 0034734 closedjorge-garcia Scan of non-existing EAN/UPC product causes loss of next scan 
causes defect 0039217 closedranjith_qualiantech_com Button Cancel in pop up "Printer and display are not available" does not work. 

-  Notes
(0097516)
hgbot (developer)
2017-06-20 16:20

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: add99883d8811155429eccc9967adda7bb28bab5
Author: Eduardo Becerra <ebec70 <at> yahoo.com>
Date: Mon Jun 19 18:25:46 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/add99883d8811155429eccc9967adda7bb28bab5 [^]

Fixed issue 36221: Focus on first visible component

---
M web/org.openbravo.retail.posterminal/js/components/modalreceiptproperties.js
---
(0097517)
hgbot (developer)
2017-06-20 16:21

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 135e9cdb03efb0ff1ab3f578b3ac2617a8ec6638
Author: Eduardo Becerra <ebec70 <at> yahoo.com>
Date: Mon Jun 19 18:28:58 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/135e9cdb03efb0ff1ab3f578b3ac2617a8ec6638 [^]

Related issue 36221: Focus searh editor on Advanced Filter

---
M web/org.openbravo.mobile.core/source/component/dialog/ob-advancedfilterselector.js
---
(0097619)
mtaal (manager)
2017-06-25 13:08

 Advanced customer filter does not set focus on first field but on the first button. See attached screenshot.

Also describe in a comment/note in this issue which popups are being solved.
(0097730)
hgbot (developer)
2017-06-28 09:10

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: b67a860e962dac3afe5dc7cd4ef272a8e2ff4d29
Author: Eduardo Becerra <ebec70 <at> yahoo.com>
Date: Mon Jun 26 10:29:14 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/b67a860e962dac3afe5dc7cd4ef272a8e2ff4d29 [^]

Fixed issue 36221: Set focus on first component in AdvancedFilters dialog

---
M web/org.openbravo.mobile.core/source/component/dialog/ob-modaladvancedfilters.js
---
(0097755)
hgbot (developer)
2017-06-29 11:54

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 0be045a1b8da39ff8dc003feabdc181ca4f0f471
Author: Eduardo Becerra <ebec70 <at> yahoo.com>
Date: Thu Jun 29 11:54:11 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0be045a1b8da39ff8dc003feabdc181ca4f0f471 [^]

Related to issue 36221: Revert changes

---
M web/org.openbravo.retail.posterminal/js/components/modalreceiptproperties.js
---
(0097756)
hgbot (developer)
2017-06-29 11:56

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 05162b51be645b3e9077cdd05d3b4fa567c08561
Author: Eduardo Becerra <ebec70 <at> yahoo.com>
Date: Thu Jun 29 11:55:44 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/05162b51be645b3e9077cdd05d3b4fa567c08561 [^]

Related to issue 36221: Revert changes

---
M web/org.openbravo.mobile.core/source/component/dialog/ob-advancedfilterselector.js
M web/org.openbravo.mobile.core/source/component/dialog/ob-modaladvancedfilters.js
---
(0097757)
marvintm (manager)
2017-06-29 11:59

 The changes have been reverted, because it seems the regression happened in a central component, and the fix should also happen in this central component, we shouldn't have duplicated logic on each popup handling the first focused fields.
(0097835)
hgbot (developer)
2017-07-04 13:07

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 9d3385757b9adb94f2c6bfe9225a3fb027b7cb85
Author: Eduardo Becerra <ebec70 <at> yahoo.com>
Date: Fri Jun 30 12:29:53 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/9d3385757b9adb94f2c6bfe9225a3fb027b7cb85 [^]

Fixes issue 36221: Refactor autofocus in Popups

---
M web/org.openbravo.mobile.core/source/component/dialog/ob-advancedfilterselector.js
M web/org.openbravo.mobile.core/source/component/dialog/ob-modaladvancedfilters.js
M web/org.openbravo.mobile.core/source/component/dialog/ob-properties.js
M web/org.openbravo.mobile.core/source/component/ob-commonbuttons.js
---

- Issue History
Date Modified Username Field Change
2017-06-09 14:13 lmonreal New Issue
2017-06-09 14:13 lmonreal Assigned To => Retail
2017-06-09 14:13 lmonreal Regression level => Production - Confirmed Stable
2017-06-09 14:13 lmonreal Triggers an Emergency Pack => No
2017-06-12 13:51 lmonreal Resolution time => 1499378400
2017-06-16 12:17 marvintm Status new => scheduled
2017-06-20 16:20 hgbot Checkin
2017-06-20 16:20 hgbot Note Added: 0097516
2017-06-20 16:20 hgbot Status scheduled => resolved
2017-06-20 16:20 hgbot Resolution open => fixed
2017-06-20 16:20 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/add99883d8811155429eccc9967adda7bb28bab5 [^]
2017-06-20 16:21 hgbot Checkin
2017-06-20 16:21 hgbot Note Added: 0097517
2017-06-20 16:52 marvintm Assigned To Retail => ebecerra
2017-06-25 13:08 mtaal Note Added: 0097619
2017-06-25 13:08 mtaal Status resolved => new
2017-06-25 13:08 mtaal Resolution fixed => open
2017-06-25 13:08 mtaal File Added: Selection_096.png
2017-06-28 09:10 hgbot Checkin
2017-06-28 09:10 hgbot Note Added: 0097730
2017-06-28 09:10 hgbot Status new => resolved
2017-06-28 09:10 hgbot Resolution open => fixed
2017-06-28 09:10 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/add99883d8811155429eccc9967adda7bb28bab5 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/b67a860e962dac3afe5dc7cd4ef272a8e2ff4d29 [^]
2017-06-29 11:54 hgbot Checkin
2017-06-29 11:54 hgbot Note Added: 0097755
2017-06-29 11:56 hgbot Checkin
2017-06-29 11:56 hgbot Note Added: 0097756
2017-06-29 11:59 marvintm Note Added: 0097757
2017-06-29 11:59 marvintm Status resolved => new
2017-06-29 11:59 marvintm Resolution fixed => open
2017-06-29 13:56 guilleaer Regression date => 2017-12-19
2017-06-29 13:56 guilleaer Regression introduced in release => RR16Q4
2017-06-29 13:56 guilleaer Regression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/da460c83b37c [^]
2017-06-29 13:57 guilleaer Regression introduced in release RR16Q4 => RR17Q1
2017-06-29 14:12 guilleaer Proposed Solution updated
2017-07-04 13:07 hgbot Checkin
2017-07-04 13:07 hgbot Note Added: 0097835
2017-07-04 13:07 hgbot Status new => resolved
2017-07-04 13:07 hgbot Resolution open => fixed
2017-07-04 13:07 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/b67a860e962dac3afe5dc7cd4ef272a8e2ff4d29 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/9d3385757b9adb94f2c6bfe9225a3fb027b7cb85 [^]
2017-07-06 19:16 guilleaer Review Assigned To => guilleaer
2017-07-06 19:16 guilleaer Status resolved => closed
2017-07-06 19:16 guilleaer Fixed in Version => RR17Q4
2018-09-20 18:42 dmitry_mezentsev Relationship added causes 0039217
2018-09-20 18:44 dmitry_mezentsev Relationship added caused by 0034734

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker