Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0034734
TypeCategorySeverityReproducibilityDate SubmittedLast Update
design defect[Retail Modules] Web POSmajoralways2016-12-14 17:392016-12-22 17:12
ReportermrecasensView Statuspublic 
Assigned Tojorge-garcia 
PriorityhighResolutionfixedFixed in VersionRR17Q1
StatusclosedFix in branchFixed in SCM revisionda460c83b37c
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0034734: Scan of non-existing EAN/UPC product causes loss of next scan

DescriptionScanning a barcode that does not correspond to any available product results in a pop up error which is acknowledged inadvertently by any subsequent scan.
This results in the error not being shown and a potentially valid scan for a product to be lost.
Steps To Reproduce0. Go to "POS Terminal Type" window and check "Use External Input" for your terminal, e.g. "VBS POS Terminal Type"

1. Log into Web POS
https://livebuilds.openbravo.com/retail_pi_pgsql/web/org.openbravo.retail.posterminal/?terminal=VBS-1#retail.pointofsale [^]
as vallblanca / openbravo

2. Scan a series of barcodes, one of them shall not correspond to any product:
2.1. scan a valid barcode that corresponds to an EAN of an existing product for the terminal
=> the corresponding article is added to the ticket
2.2. scan a valid barcode that DOES NOT correspond to any EAN of an existing product for the terminal
=> NO article is added to the ticket
=> Instead, a pop up error message is displayed
2.3. scan a valid barcode that corresponds to an EAN of an existing product for the terminal
=> NO article is NOT added to the ticket
=> Instead, the previous pop up error message disappears; the carriage return may have been taken for an acceptation of the error message
2.4 You can continue scanning products

The overall result is that the article in step 2.2 is not added, which may be normal, but neither is the article in step 2.3 which is a perfectly valid article.

A proposed solution would be to disable the scanning of products while the pop error message is raised

ANNEX A
A list of possible EAN codes and their barcodes is provided to help with further testing.
2099901001832
2099901001849
2099901001870
2099901002068
2099901003553
Attached a PDF file with the barcodes above
Proposed SolutionFurther scanning of products should be disabled as long as the pop up error message is present.
Tags​SER QA
Attached Filespdf file icon BUT - Autom EAN for OTF barcodes test.pdf [^] (18,789 bytes) 2016-12-14 17:39

- Relationships [ Relation Graph ] [ Dependency Graph ]
causes defect 0036221 closedebecerra In some of the pop ups of WEBPOS for 17Q2 the focus is not on the first input field 

-  Notes
(0092882)
hgbot (developer)
2016-12-21 08:42

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: dc2f33eb879b745978cffe6681b27aaa8a29423a
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Dec 19 17:27:23 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/dc2f33eb879b745978cffe6681b27aaa8a29423a [^]

Related to issue 34734: Scan of non-existing EAN/UPC product causes loss of
next scan

In the case the preference OBPOS_KbUPCEANCodeNotFound is active, the popup
shown has not as default action the OK button.

---
M web/org.openbravo.retail.posterminal/js/components/subwindow.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboardorder.js
---
(0092883)
hgbot (developer)
2016-12-21 08:42

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 637c8a3e72f1fa3dfcaae564fcda22262b4dd243
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Dec 20 12:21:37 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/637c8a3e72f1fa3dfcaae564fcda22262b4dd243 [^]

Related to issue 34734: Scan of non-existing EAN/UPC product causes loss of
next scan

The error sound is played when the product doesn’t exists or the scanMode is
disable in that moment.

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboardorder.js
---
(0092884)
hgbot (developer)
2016-12-21 08:42

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: da460c83b37c4b23e9858ea2b7bba4fc929f471d
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Dec 19 17:21:27 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/da460c83b37c4b23e9858ea2b7bba4fc929f471d [^]

Fixed issue 34734: Scan of non-existing EAN/UPC product causes loss of
next scan

Added the possibility of specify if a confirmation popup has a default action.

If the confirmation button is not set as defaultAction, the focus is not set
in that element.

---
M web/org.openbravo.mobile.core/source/component/ob-commonbuttons.js
M web/org.openbravo.mobile.core/source/utils/ob-utilitiesui.js
---
(0092885)
hgbot (developer)
2016-12-21 08:43

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 651d5c0a549bc4c59be8996a55980dc9ecba8110
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Dec 20 12:19:25 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/651d5c0a549bc4c59be8996a55980dc9ecba8110 [^]

Related to issue 34734: Scan of non-existing EAN/UPC product causes loss of
next scan

Added an error sound to indicate the search of a product has failed. This error
sound can be enable/disable with a preference in the backend.

This preference name is ‘Mobile Reproduce Error Sound On Failed Scan’ and by
default is active.

---
M legal/Licensing.txt
M src-db/database/sourcedata/AD_PREFERENCE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M web/org.openbravo.mobile.core/source/component/ob-keyboard.js
A web/org.openbravo.mobile.core/sounds/Computer_Error.mp3
---
(0092918)
marvintm (manager)
2016-12-21 18:44

 I get the error sound in a place not related at all with the scanning action:
- Log in the Web POS
- Open the Address selector.
- Type the "Esc" key. Notice that the error sound is played.
(0092944)
hgbot (developer)
2016-12-22 15:17

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 75a9434301845b0a502ed99e7056a41386022ffa
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Thu Dec 22 10:43:45 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/75a9434301845b0a502ed99e7056a41386022ffa [^]

Related to issue 34734: Scan of non-existing EAN/UPC product causes loss of
next scan

Only the error popup that indicates the EAN/UPC fails must reproduce the error
sound.

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboardorder.js
---
(0092945)
hgbot (developer)
2016-12-22 15:18

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 362ae31579674166d62fb08ccd929de105d49a5d
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Thu Dec 22 10:44:52 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/362ae31579674166d62fb08ccd929de105d49a5d [^]

Related to issue 34734: Scan of non-existing EAN/UPC product causes loss of
next scan

New global variable has been created to indicate if the error sound must be
played if the scan of barcode fails.

---
M web/org.openbravo.mobile.core/source/component/ob-keyboard.js
---
(0092946)
hgbot (developer)
2016-12-22 15:18

 Repository: tools/automation/pi-mobile
Changeset: 47a3363dc6e3472446a825a13579036d8e5f710c
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Thu Dec 22 13:02:05 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/47a3363dc6e3472446a825a13579036d8e5f710c [^]

Related to issue 34734: Scan of non-existing EAN/UPC product causes loss of
next scan

Change two tests related to RFID to tap on the correct button in
confirmation popu.p

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I32868_VerifyDisableLockPreferenceWork.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/rfid/AddMissingRFIDNumber.java
---

- Issue History
Date Modified Username Field Change
2016-12-14 17:39 mrecasens New Issue
2016-12-14 17:39 mrecasens Assigned To => Retail
2016-12-14 17:39 mrecasens File Added: BUT - Autom EAN for OTF barcodes test.pdf
2016-12-14 17:39 mrecasens Triggers an Emergency Pack => No
2016-12-14 17:43 mrecasens Tag Attached: ​SER QA
2016-12-14 17:44 mrecasens Issue Monitored: mrecasens
2016-12-19 12:56 marvintm Resolution time => 1483052400
2016-12-19 13:53 jorge-garcia Status new => scheduled
2016-12-19 13:53 jorge-garcia Assigned To Retail => jorge-garcia
2016-12-21 08:42 hgbot Checkin
2016-12-21 08:42 hgbot Note Added: 0092882
2016-12-21 08:42 hgbot Checkin
2016-12-21 08:42 hgbot Note Added: 0092883
2016-12-21 08:42 hgbot Checkin
2016-12-21 08:42 hgbot Note Added: 0092884
2016-12-21 08:42 hgbot Status scheduled => resolved
2016-12-21 08:42 hgbot Resolution open => fixed
2016-12-21 08:42 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/da460c83b37c4b23e9858ea2b7bba4fc929f471d [^]
2016-12-21 08:43 hgbot Checkin
2016-12-21 08:43 hgbot Note Added: 0092885
2016-12-21 18:44 marvintm Note Added: 0092918
2016-12-21 18:44 marvintm Status resolved => new
2016-12-21 18:44 marvintm Resolution fixed => open
2016-12-22 10:51 jorge-garcia Status new => scheduled
2016-12-22 15:17 hgbot Checkin
2016-12-22 15:17 hgbot Note Added: 0092944
2016-12-22 15:18 hgbot Checkin
2016-12-22 15:18 hgbot Note Added: 0092945
2016-12-22 15:18 hgbot Checkin
2016-12-22 15:18 hgbot Note Added: 0092946
2016-12-22 15:19 jorge-garcia Status scheduled => resolved
2016-12-22 15:19 jorge-garcia Resolution open => fixed
2016-12-22 17:12 marvintm Review Assigned To => marvintm
2016-12-22 17:12 marvintm Status resolved => closed
2016-12-22 17:12 marvintm Fixed in Version => RR17Q1
2018-09-20 18:44 dmitry_mezentsev Relationship added causes 0036221

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker