0036221: In some of the pop ups of WEBPOS for 17Q2 the focus is not on the first input field

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0036221

Retail Modules

Web POS

public

2017-06-09 14:13

2018-09-20 18:44

Reporter

lmonreal

Assigned To

ebecerra

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

RR17Q4

Merge Request Status

Review Assigned To

guilleaer

OBNetwork customer

Support ticket

Regression level

Production - Confirmed Stable

Regression date

2017-12-19

Regression introduced in release

RR17Q1

Regression introduced by commit

https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/da460c83b37c [^]

Triggers an Emergency Pack

Summary

0036221: In some of the pop ups of WEBPOS for 17Q2 the focus is not on the first input field

Description

In some of the pop ups of WEBPOS for 17Q2 the focus is not on the first input field and previously in 16Q4 it was.

Steps To Reproduce

1. Open webpos
2. Click receipt properties
3.In the pop up the focus is not there, it should be in Description field

Proposed Solution

In 17Q1 this change
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/da460c83b37c [^]
Created a problem -> Set focus is not working at all (It just work when the element selected to be the focus is also marked at default action. This is common in popups which does not have inputs and just have one button)

In 17Q2 this change:
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/68def0094634 [^]
Has mittigated the problem introduced in 17Q1, but it is also not working fine. With that change, set Focus will work fine if there are no buttons marked as default action (in this case focus will be put in the first valid input or in the field marked as first focus), but if there is one component marked as default action it will take the focus.

EXPECTED BEHAVIOR.
- Default action: Means that when "intro" is presed when popup is opened this action should be executed
- First focus: Means that a component will pick the focus.
- If there is not first focus then, we will select the focus based on the tag. We will set the focus for the first component found with the tag 'INPUT' || 'SELECT' || 'TEXTAREA' || 'BUTTON' which is being shown.

If both methods above have failed to pick an element to be focused, the we will try to set the focus in the component which is in marked as default action (if it exists)

Summary:
Iterate components of the popup {
save first component visible with valid tag as a candidate
save defaultActionCandidate if found
overwrite candidate if first focused is found
}
if (!candidate) {
candidate = defaultActionCandidate
}

Additional Information

Tags

No tags attached.

Relationships

depends on	backport	0036264	RR17Q2.2	closed	Retail	In some of the pop ups of WEBPOS for 17Q2 the focus is not on the first input field
depends on	backport	0036265	RR17Q1.3	closed	Retail	In some of the pop ups of WEBPOS for 17Q2 the focus is not on the first input field
caused by	design defect	0034734		closed	jorge-garcia	Scan of non-existing EAN/UPC product causes loss of next scan
causes	defect	0039217		closed	ranjith_qualiantech_com	Button Cancel in pop up "Printer and display are not available" does not work.