Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0029273
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] Z. Othersminoralways2015-03-13 14:142015-05-07 22:16
ReporterngarciaView Statuspublic 
Assigned Toumartirena 
PriorityimmediateResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisiona1caffd894bb
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket35023
Regression level
Regression date2014-07-01
Regression introduced in release3.0PR14Q4
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/b1843f200a9092eea99d431776d029a09868615a [^]
Triggers an Emergency PackNo
Summary

0029273: Payment Out cannot be reactivated if the business partner does not have a purchase price list defined

DescriptionPayment Out cannot be reactivated if the business partner does not have a purchase price list defined and the payment currency is different from the Business partner currency
Steps To ReproduceAs group admin role:
   Create a Payment Out for a business partner
   Change the Business Partner currency to a currency different from the payment currency
   Leave the Purchase Price List empty in the Business Partner - Vendor tab
   Try to reactivate the Payment Out and check you get an empty error message
Proposed SolutionCheck if in getConversionRateDocumentForInvoice function of FIN_PaymentProcess class, the business partner currency could be used in both flows instead of the purchase price list currency
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 00295413.0PR15Q2 closedumartirena Payment Out cannot be reactivated if the business partner does not have a purchase price list defined 
depends on backport 00295423.0PR15Q1.3 closedumartirena Payment Out cannot be reactivated if the business partner does not have a purchase price list defined 
caused by defect 00253923.0PR14Q4 closededuardo_Argal Wrong customer balance when working with multicurrency 

-  Notes
(0075744)
fsoto82 (viewer)
2015-03-18 15:52

 As group admin role:
   Create a Payment Out for a business partner
   Change the Business Partner currency to a currency different from the payment currency
   Leave the Purchase Price List empty in the Business Partner - Vendor tab
   Now you can reactivate the Payment Out
(0076471)
hgbot (developer)
2015-04-13 12:31

 Repository: erp/devel/pi
Changeset: a1caffd894bb0a227a43c9b524b077d0811caa9a
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Wed Apr 08 16:42:45 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/a1caffd894bb0a227a43c9b524b077d0811caa9a [^]

Fixes bug 29273: Payment Out can be reactivated without bp purchase pricelist

The problem is that the method 'getConversionRateDocumentForInvoice' tries to get a conversion using the currency of Purchase PriceList of the business partner, and it could happen to be empty, so it fails.

Starting from 3.0PR14Q4 the Currency field in the business partner is mandatory, so it can be used for Sales/Purchase flow.

It could be that at this point while reactivating the Payment to be the Currency of the Business Partner null, because it was created long time ago and no currency set yet, so, if this is the case an error will be raised to the user in order to fix this.

A last change has been made in 'OBMessageUtils.messageBD' method, adding an extra parameter when it is wanted to avoid doing escape of '\n' and doublequotes characters. In this case it is needed because the message that needs to be displayed needs to maintain them because contains a link. This implementation is similar to the one found in BasicUtility.messageBD.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java
M src/org/openbravo/erpCommon/utility/OBMessageUtils.java
---
(0076472)
hgbot (developer)
2015-04-13 12:31

 Repository: erp/devel/pi
Changeset: a6642e0e5f0ce1857e1ba3760fd0a943e20a43cf
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Mon Apr 13 12:29:01 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/a6642e0e5f0ce1857e1ba3760fd0a943e20a43cf [^]

Related to issue 29273: Removed unused parameter

Removed unused parameter in getConversionRateDocumentForInvoice method

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java
---
(0076473)
aferraz (viewer)
2015-04-13 12:32

 Code review + Testing OK
(0077119)
hudsonbot (viewer)
2015-05-07 22:16

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a1817f84bd8b [^]
Maturity status: Test
(0077120)
hudsonbot (viewer)
2015-05-07 22:16

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a1817f84bd8b [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2015-03-13 14:14 ngarcia New Issue
2015-03-13 14:14 ngarcia Assigned To => Sandrahuguet
2015-03-13 14:14 ngarcia OBNetwork customer => Yes
2015-03-13 14:14 ngarcia Modules => Core
2015-03-13 14:14 ngarcia Support ticket => 35023
2015-03-13 14:14 ngarcia Triggers an Emergency Pack => No
2015-03-13 14:15 ngarcia Relationship added caused by 0025392
2015-03-13 14:15 ngarcia Issue Monitored: networkb
2015-03-13 14:16 ngarcia Resolution time => 1432677600
2015-03-18 15:51 fsoto82 Status new => scheduled
2015-03-18 15:51 fsoto82 Assigned To Sandrahuguet => fsoto82
2015-03-18 15:52 fsoto82 Note Added: 0075744
2015-04-08 12:14 umartirena Regression date => 2014-07-01
2015-04-08 12:14 umartirena Regression introduced in release => 3.0PR14Q4
2015-04-08 12:14 umartirena Regression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/b1843f200a9092eea99d431776d029a09868615a [^]
2015-04-09 10:06 umartirena Assigned To fsoto82 => umartirena
2015-04-09 10:06 umartirena Status scheduled => acknowledged
2015-04-09 10:06 umartirena Status acknowledged => scheduled
2015-04-13 12:31 hgbot Checkin
2015-04-13 12:31 hgbot Note Added: 0076471
2015-04-13 12:31 hgbot Status scheduled => resolved
2015-04-13 12:31 hgbot Resolution open => fixed
2015-04-13 12:31 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a1caffd894bb0a227a43c9b524b077d0811caa9a [^]
2015-04-13 12:31 hgbot Checkin
2015-04-13 12:31 hgbot Note Added: 0076472
2015-04-13 12:32 aferraz Review Assigned To => aferraz
2015-04-13 12:32 aferraz Note Added: 0076473
2015-04-13 12:32 aferraz Status resolved => closed
2015-05-07 22:16 hudsonbot Checkin
2015-05-07 22:16 hudsonbot Note Added: 0077119
2015-05-07 22:16 hudsonbot Checkin
2015-05-07 22:16 hudsonbot Note Added: 0077120

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker