Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0029542
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Openbravo ERP] Z. Othersminoralways2015-03-13 14:142015-04-10 10:00
ReporterngarciaView Statuspublic 
Assigned Toumartirena 
PriorityimmediateResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision8bbf1f5e42cd
ProjectionnoneETAnoneTarget Version3.0PR15Q1.3
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Toeduardo_Argal
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket35023
Regression level
Regression date2014-07-01
Regression introduced in release3.0PR14Q4
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/b1843f200a9092eea99d431776d029a09868615a [^]
Triggers an Emergency PackNo
Summary

0029542: Payment Out cannot be reactivated if the business partner does not have a purchase price list defined

DescriptionPayment Out cannot be reactivated if the business partner does not have a purchase price list defined and the payment currency is different from the Business partner currency
Steps To ReproduceAs group admin role:
   Create a Payment Out for a business partner
   Change the Business Partner currency to a currency different from the payment currency
   Leave the Purchase Price List empty in the Business Partner - Vendor tab
   Try to reactivate the Payment Out and check you get an empty error message
Proposed SolutionCheck if in getConversionRateDocumentForInvoice function of FIN_PaymentProcess class, the business partner currency could be used in both flows instead of the purchase price list currency
TagsApproved
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 0029273 closedumartirena Payment Out cannot be reactivated if the business partner does not have a purchase price list defined 

-  Notes
(0076421)
hgbot (developer)
2015-04-09 15:05

 Repository: erp/backports/3.0PR15Q1.3
Changeset: 8bbf1f5e42cdc7c266868d1025ff51def820e737
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Thu Apr 09 11:30:57 2015 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR15Q1.3/rev/8bbf1f5e42cdc7c266868d1025ff51def820e737 [^]

Fixes bug 29542: Payment Out can be reactivated without bp purchase pricelist

The problem is that the method 'getConversionRateDocumentForInvoice' tries to get a conversion using the currency of Purchase PriceList of the business partner, and it could happen to be empty, so it fails.

Starting from 3.0PR14Q4 the Currency field in the business partner is mandatory, so it can be used for Sales/Purchase flow.

It could be that at this point while reactivating the Payment to be the Currency of the Business Partner null, because it was created long time ago and no currency set yet, so, if this is the case an error will be raised to the user in order to fix this.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java
---
(0076422)
eduardo_Argal (viewer)
2015-04-09 15:06

 Code reviewed and tested. Now currency is taken from business partner and an error is raised in case even that currency is missing. Purchase pricelist currency is no longer being used

- Issue History
Date Modified Username Field Change
2015-04-09 10:06 umartirena Type defect => backport
2015-04-09 10:06 umartirena Target Version => 3.0PR15Q1.3
2015-04-09 15:05 hgbot Checkin
2015-04-09 15:05 hgbot Note Added: 0076421
2015-04-09 15:05 hgbot Status scheduled => resolved
2015-04-09 15:05 hgbot Resolution open => fixed
2015-04-09 15:05 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR15Q1.3/rev/8bbf1f5e42cdc7c266868d1025ff51def820e737 [^]
2015-04-09 15:06 eduardo_Argal Review Assigned To => eduardo_Argal
2015-04-09 15:06 eduardo_Argal Note Added: 0076422
2015-04-09 15:06 eduardo_Argal Status resolved => closed
2015-04-10 10:00 dmitry_mezentsev Tag Attached: Approved

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker