Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029542Openbravo ERPZ. Otherspublic2015-03-13 14:142015-04-10 10:00
Reporterngarcia 
Assigned Toumartirena 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR15Q1.3Fixed in Version 
Merge Request Status
Review Assigned Toeduardo_Argal
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date2014-07-01
Regression introduced in release3.0PR14Q4
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/b1843f200a9092eea99d431776d029a09868615a [^]
Triggers an Emergency PackNo
Summary0029542: Payment Out cannot be reactivated if the business partner does not have a purchase price list defined
DescriptionPayment Out cannot be reactivated if the business partner does not have a purchase price list defined and the payment currency is different from the Business partner currency
Steps To ReproduceAs group admin role:
   Create a Payment Out for a business partner
   Change the Business Partner currency to a currency different from the payment currency
   Leave the Purchase Price List empty in the Business Partner - Vendor tab
   Try to reactivate the Payment Out and check you get an empty error message
Proposed SolutionCheck if in getConversionRateDocumentForInvoice function of FIN_PaymentProcess class, the business partner currency could be used in both flows instead of the purchase price list currency
Additional Information
TagsApproved
Relationships
blocks defect 0029273 closed umartirena Payment Out cannot be reactivated if the business partner does not have a purchase price list defined 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-04-09 10:06umartirenaTypedefect => backport
2015-04-09 10:06umartirenaTarget Version => 3.0PR15Q1.3
2015-04-09 15:05hgbotCheckin
2015-04-09 15:05hgbotNote Added: 0076421
2015-04-09 15:05hgbotStatusscheduled => resolved
2015-04-09 15:05hgbotResolutionopen => fixed
2015-04-09 15:05hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR15Q1.3/rev/8bbf1f5e42cdc7c266868d1025ff51def820e737 [^]
2015-04-09 15:06eduardo_ArgalReview Assigned To => eduardo_Argal
2015-04-09 15:06eduardo_ArgalNote Added: 0076422
2015-04-09 15:06eduardo_ArgalStatusresolved => closed
2015-04-10 10:00dmitry_mezentsevTag Attached: Approved

Notes
(0076421)
hgbot   
2015-04-09 15:05   
Repository: erp/backports/3.0PR15Q1.3
Changeset: 8bbf1f5e42cdc7c266868d1025ff51def820e737
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Thu Apr 09 11:30:57 2015 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR15Q1.3/rev/8bbf1f5e42cdc7c266868d1025ff51def820e737 [^]

Fixes bug 29542: Payment Out can be reactivated without bp purchase pricelist

The problem is that the method 'getConversionRateDocumentForInvoice' tries to get a conversion using the currency of Purchase PriceList of the business partner, and it could happen to be empty, so it fails.

Starting from 3.0PR14Q4 the Currency field in the business partner is mandatory, so it can be used for Sales/Purchase flow.

It could be that at this point while reactivating the Payment to be the Currency of the Business Partner null, because it was created long time ago and no currency set yet, so, if this is the case an error will be raised to the user in order to fix this.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java
---
(0076422)
eduardo_Argal   
2015-04-09 15:06   
Code reviewed and tested. Now currency is taken from business partner and an error is raised in case even that currency is missing. Purchase pricelist currency is no longer being used