Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0027574
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 07. Sales managementmajorhave not tried2014-09-10 17:152015-10-07 17:45
ReporterjonalegriaesarteView Statuspublic 
Assigned Toreinaldoguerra 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision2eb38d0f5418
ProjectionnoneETAnoneTarget Version3.0PR15Q1
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tovmromanos
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0027574: Invoice rule - Do not invoice not working in create lines from in purchase flow

DescriptionInvoice rule - Do not invoice not working in create lines from in purchase flow
Steps To Reproduce- Show invoice rule in purchase order
- Create an order and set it as do not invoice
- Create a purchase invoice
- Order appears in the created lines from
Proposed SolutionAttached a patch solving the issue
TagsNo tags attached.
Attached Filesdiff file icon createlines.diff [^] (1,170 bytes) 2014-09-10 17:15 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0000570 closedgorkaion TST240r2: POS order cannot be completed 
related to feature request 0031092 newTriage Omni OMS It would be fine if goods receipt lines could be set as Do not Invoice in order not to be pending to be invoiced 
causes defect 0028980 closedumartirena Good receipt without a purchase order associated do not appear in create lines from functionality in purchase invoice 
causes defect 0031382 closedAtulOpenbravo Purchase Order and Goods Receipt not shown in Invoice's Create Lines From if the Customer Invoice Terms are Do Not Invoice 

-  Notes
(0070706)
reinaldoguerra (developer)
2014-10-04 08:25

 Test plan used:
1- Login into Openbravo ERP
2- Show invoice rule in purchase order
3- Create an order and set it as do not invoice
4- Create a purchase invoice
5- Now order do not appears in the created lines from.
(0070768)
hgbot (developer)
2014-10-07 13:39

 Repository: erp/devel/pi
Changeset: 2eb38d0f5418963af34d3ab7a5dbfec140cc662c
Author: Reinaldo Guerra <reinaldo.guerra <at> peoplewalking.com>
Date: Fri Oct 03 21:35:57 2014 -0500
URL: http://code.openbravo.com/erp/devel/pi/rev/2eb38d0f5418963af34d3ab7a5dbfec140cc662c [^]

Fixed bug 27574: Invoice rule - Do not invoice not working in create lines from.

Orders selector in create lines from process on purchase invoice windows, now exclude orders with invoice terms: Do not invoice.
Now it is not possible to generate invoices from orders withs invoice terms defined as: Do not invoice.

---
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Invoice_data.xsql
---
(0070769)
vmromanos (manager)
2014-10-07 13:43

 Note that the fix also avoids to create an invoice from a goods receipt when the receipt comes from an order with invoice terms = "do not invoice".

1. Create a purchase order for any business partner. Add a line
2. Run the following SQL. Replace the id by the newly created c_order_id:
update c_order
set InvoiceRule = 'N'
where c_order_id = <ID>
3. Go to goods receipt. Create a new header for the same business partner.
4. Create lines from and select the previous order. Complete the document
5. Create a new Purchase invoice header for the same business partner.
6. Press create lines from and verify neither the order nor the goods receipts are available.
(0070770)
vmromanos (manager)
2014-10-07 13:43

 Code review + testing OK
(0072910)
hudsonbot (developer)
2014-12-30 23:22

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6525fe229e06 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2014-09-10 17:15 jonalegriaesarte New Issue
2014-09-10 17:15 jonalegriaesarte Assigned To => dmiguelez
2014-09-10 17:15 jonalegriaesarte File Added: createlines.diff
2014-09-10 17:15 jonalegriaesarte Modules => Core
2014-09-10 17:15 jonalegriaesarte Resolution time => 1412978400
2014-09-10 17:15 jonalegriaesarte Triggers an Emergency Pack => No
2014-09-22 16:36 jonalegriaesarte Target Version 3.0PR14Q4 => 3.0PR15Q1
2014-10-04 02:49 reinaldoguerra Assigned To dmiguelez => reinaldoguerra
2014-10-04 02:49 reinaldoguerra Status new => scheduled
2014-10-04 08:25 reinaldoguerra Note Added: 0070706
2014-10-07 13:39 hgbot Checkin
2014-10-07 13:39 hgbot Note Added: 0070768
2014-10-07 13:39 hgbot Status scheduled => resolved
2014-10-07 13:39 hgbot Resolution open => fixed
2014-10-07 13:39 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/2eb38d0f5418963af34d3ab7a5dbfec140cc662c [^]
2014-10-07 13:43 vmromanos Note Added: 0070769
2014-10-07 13:43 vmromanos Review Assigned To => vmromanos
2014-10-07 13:43 vmromanos Note Added: 0070770
2014-10-07 13:43 vmromanos Status resolved => closed
2014-12-30 23:22 hudsonbot Checkin
2014-12-30 23:22 hudsonbot Note Added: 0072910
2015-02-19 12:10 Sandrahuguet Relationship added causes 0028980
2015-06-09 13:54 ngarcia Issue Monitored: ngarcia
2015-10-07 17:45 ngarcia Relationship added related to 0000570
2015-10-08 10:28 ngarcia Relationship added related to 0031092
2015-11-05 18:58 ngarcia Relationship added related to 0031382
2015-11-05 19:07 ngarcia Relationship replaced causes 0031092
2015-11-05 19:07 ngarcia Relationship replaced related to 0031092
2015-11-05 19:09 ngarcia Relationship replaced causes 0031382

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker