Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0027574Openbravo ERP07. Sales managementpublic2014-09-10 17:152015-10-07 17:45
Reporterjonalegriaesarte 
Assigned Toreinaldoguerra 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR15Q1Fixed in Version 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket30898
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0027574: Invoice rule - Do not invoice not working in create lines from in purchase flow
DescriptionInvoice rule - Do not invoice not working in create lines from in purchase flow
Steps To Reproduce- Show invoice rule in purchase order
- Create an order and set it as do not invoice
- Create a purchase invoice
- Order appears in the created lines from
Proposed SolutionAttached a patch solving the issue
Additional Information
TagsNo tags attached.
Relationships
related to defect 0000570 closed gorkaion TST240r2: POS order cannot be completed 
related to feature request 0031092 new Triage Omni OMS It would be fine if goods receipt lines could be set as Do not Invoice in order not to be pending to be invoiced 
causes defect 0028980 closed umartirena Good receipt without a purchase order associated do not appear in create lines from functionality in purchase invoice 
causes defect 0031382 closed AtulOpenbravo Purchase Order and Goods Receipt not shown in Invoice's Create Lines From if the Customer Invoice Terms are Do Not Invoice 
Attached Filesdiff createlines.diff (1,170) 2014-09-10 17:15
https://issues.openbravo.com/file_download.php?file_id=7231&type=bug
Issue History
Date ModifiedUsernameFieldChange
2014-09-10 17:15jonalegriaesarteNew Issue
2014-09-10 17:15jonalegriaesarteAssigned To => dmiguelez
2014-09-10 17:15jonalegriaesarteFile Added: createlines.diff
2014-09-10 17:15jonalegriaesarteOBNetwork customer => Yes
2014-09-10 17:15jonalegriaesarteModules => Core
2014-09-10 17:15jonalegriaesarteSupport ticket => 30898
2014-09-10 17:15jonalegriaesarteResolution time => 1412978400
2014-09-10 17:15jonalegriaesarteTriggers an Emergency Pack => No
2014-09-22 16:36jonalegriaesarteTarget Version3.0PR14Q4 => 3.0PR15Q1
2014-10-04 02:49reinaldoguerraAssigned Todmiguelez => reinaldoguerra
2014-10-04 02:49reinaldoguerraStatusnew => scheduled
2014-10-04 08:25reinaldoguerraNote Added: 0070706
2014-10-07 13:39hgbotCheckin
2014-10-07 13:39hgbotNote Added: 0070768
2014-10-07 13:39hgbotStatusscheduled => resolved
2014-10-07 13:39hgbotResolutionopen => fixed
2014-10-07 13:39hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/2eb38d0f5418963af34d3ab7a5dbfec140cc662c [^]
2014-10-07 13:43vmromanosNote Added: 0070769
2014-10-07 13:43vmromanosReview Assigned To => vmromanos
2014-10-07 13:43vmromanosNote Added: 0070770
2014-10-07 13:43vmromanosStatusresolved => closed
2014-12-30 23:22hudsonbotCheckin
2014-12-30 23:22hudsonbotNote Added: 0072910
2015-02-19 12:10SandrahuguetRelationship addedcauses 0028980
2015-06-09 13:54ngarciaIssue Monitored: ngarcia
2015-10-07 17:45ngarciaRelationship addedrelated to 0000570
2015-10-08 10:28ngarciaRelationship addedrelated to 0031092
2015-11-05 18:58ngarciaRelationship addedrelated to 0031382
2015-11-05 19:07ngarciaRelationship replacedcauses 0031092
2015-11-05 19:07ngarciaRelationship replacedrelated to 0031092
2015-11-05 19:09ngarciaRelationship replacedcauses 0031382

Notes
(0070706)
reinaldoguerra   
2014-10-04 08:25   
Test plan used:
1- Login into Openbravo ERP
2- Show invoice rule in purchase order
3- Create an order and set it as do not invoice
4- Create a purchase invoice
5- Now order do not appears in the created lines from.
(0070768)
hgbot   
2014-10-07 13:39   
Repository: erp/devel/pi
Changeset: 2eb38d0f5418963af34d3ab7a5dbfec140cc662c
Author: Reinaldo Guerra <reinaldo.guerra <at> peoplewalking.com>
Date: Fri Oct 03 21:35:57 2014 -0500
URL: http://code.openbravo.com/erp/devel/pi/rev/2eb38d0f5418963af34d3ab7a5dbfec140cc662c [^]

Fixed bug 27574: Invoice rule - Do not invoice not working in create lines from.

Orders selector in create lines from process on purchase invoice windows, now exclude orders with invoice terms: Do not invoice.
Now it is not possible to generate invoices from orders withs invoice terms defined as: Do not invoice.

---
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Invoice_data.xsql
---
(0070769)
vmromanos   
2014-10-07 13:43   
Note that the fix also avoids to create an invoice from a goods receipt when the receipt comes from an order with invoice terms = "do not invoice".

1. Create a purchase order for any business partner. Add a line
2. Run the following SQL. Replace the id by the newly created c_order_id:
update c_order
set InvoiceRule = 'N'
where c_order_id = <ID>
3. Go to goods receipt. Create a new header for the same business partner.
4. Create lines from and select the previous order. Complete the document
5. Create a new Purchase invoice header for the same business partner.
6. Press create lines from and verify neither the order nor the goods receipts are available.
(0070770)
vmromanos   
2014-10-07 13:43   
Code review + testing OK
(0072910)
hudsonbot   
2014-12-30 23:22   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6525fe229e06 [^]
Maturity status: Test