Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0021381 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] B. User interface | critical | always | 2012-08-19 01:07 | 2016-10-24 09:17 | |||
| Reporter | pjuvara | View Status | public | |||||
| Assigned To | dbaz | |||||||
| Priority | normal | Resolution | duplicate | Fixed in Version | 3.0MP15 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | 3.0MP12.1 | SCM revision | ||||||
| Review Assigned To | dbaz | |||||||
| Web browser | Google Chrome | |||||||
| Modules | Core | |||||||
| Regression level | Production - Confirmed Stable | |||||||
| Regression date | 2011-09-27 | |||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | https://code.openbravo.com/erp/devel/pi/rev/7d3eaa3a17c45de0256302f2bee25b8984e722fc [^] | |||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0021381: Focus is lost after a record is saved in form view, resulting in incorrect operation of keyboards | |||||||
| Description | When you enter a record in Edit mode and you save it pressing CTRL+S, the focus is lost and it is no longer in the record. This implies that the keyboard operations no longer work. If at a point you want to perform the two most common actions, which are - Create a new record with CTRL+D, or - Navigate to another screen opening the Quick menu with CTRL+O these shortcuts are intercepted by the browser and - at least in Chrome - you are going to instead create a bookmark (CTRL+D) or open the dialog to open a local file. | |||||||
| Steps To Reproduce | In any window (for example: Sales order window), create a record (for example Sales order header) in form view. Save it using CTRL+S. Try to create another record with CTRL+D | |||||||
| Tags | Coworking | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||
|
|||||||||||||||
 Relationships |
|
Notes |
|
|
(0051345) pjuvara (reporter) 2012-08-19 01:08 |
This might be a regression as I have the distinct recollection that this flow used to work smoothly. |
|
(0051869) dbaz (developer) 2012-09-05 11:10 |
The problem root is that the focus is lost once the "Save" button action is done (it can be reproduced using the mouse or the keyboard) |
|
(0051870) dbaz (developer) 2012-09-05 11:10 |
The problem is that before the regression commit, the previous focused item was stored: https://code.openbravo.com/erp/devel/pi/rev/7d3eaa3a17c45de0256302f2bee25b8984e722fc#l1.201 [^] [^] and then in the save callback it was restored https://code.openbravo.com/erp/devel/pi/rev/7d3eaa3a17c45de0256302f2bee25b8984e722fc#l1.210 [^] [^] This logic was using "storeFocusItem" and "restoreFocusItem" that also don't exist anymore: https://code.openbravo.com/erp/devel/pi/rev/7d3eaa3a17c45de0256302f2bee25b8984e722fc#l1.263 [^] [^] In the fix a simplified version of this code is going to be introduced in order to recover the logic. The fix risk is medium, and should be supervised by Martin Taal |
|
(0051871) dbaz (developer) 2012-09-05 11:10 |
Repository: erp/devel/pi Changeset: 2e55c0d0da0d133a538c77b6380340f7b4de53c8 Author: David Baz Fayos <david.baz <at> openbravo.com> Date: Fri Aug 31 22:27:11 2012 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/2e55c0d0da0d133a538c77b6380340f7b4de53c8 [^] [^] Fixed issue 21420: focus is set back in the form view after save action --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js --- |
|
(0051872) dbaz (developer) 2012-09-05 11:10 |
Repository: erp/devel/pi Changeset: 5492d5749d01b2fc25ba399063be8f3e78abf5c4 Author: David Baz Fayos <david.baz <at> openbravo.com> Date: Tue Sep 04 13:09:31 2012 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/5492d5749d01b2fc25ba399063be8f3e78abf5c4 [^] [^] Related to issue 21420: 'saveRow' focus logic is now more solid --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js --- |
|
(0051873) dbaz (developer) 2012-09-05 11:11 |
Duplicate of https://issues.openbravo.com/view.php?id=21420 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2012-08-19 01:07 | pjuvara | New Issue | |
| 2012-08-19 01:07 | pjuvara | Assigned To | => dbaz |
| 2012-08-19 01:07 | pjuvara | Web browser | => Google Chrome |
| 2012-08-19 01:07 | pjuvara | Modules | => Core |
| 2012-08-19 01:07 | pjuvara | Tag Attached: Coworking | |
| 2012-08-19 01:08 | pjuvara | Note Added: 0051345 | |
| 2012-09-05 11:09 | dbaz | Web browser | Google Chrome => Google Chrome |
| 2012-09-05 11:09 | dbaz | Regression level | => Production - Confirmed Stable |
| 2012-09-05 11:09 | dbaz | Regression date | => 2011-09-27 |
| 2012-09-05 11:09 | dbaz | Regression introduced by commit | => https://code.openbravo.com/erp/devel/pi/rev/7d3eaa3a17c45de0256302f2bee25b8984e722fc [^] |
| 2012-09-05 11:10 | dbaz | Note Added: 0051869 | |
| 2012-09-05 11:10 | dbaz | Note Added: 0051870 | |
| 2012-09-05 11:10 | dbaz | Note Added: 0051871 | |
| 2012-09-05 11:10 | dbaz | Note Added: 0051872 | |
| 2012-09-05 11:11 | dbaz | Closed by | => dbaz |
| 2012-09-05 11:11 | dbaz | Relationship added | duplicate of 0021420 |
| 2012-09-05 11:11 | dbaz | Note Added: 0051873 | |
| 2012-09-05 11:11 | dbaz | Status | new => closed |
| 2012-09-05 11:11 | dbaz | Resolution | open => duplicate |
| 2012-09-05 11:11 | dbaz | Fixed in Version | => 3.0MP15 |
| 2016-10-24 09:17 | NaroaIriarte | Relationship added | related to 0034057 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |