Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0021381Openbravo ERPB. User interfacepublic2012-08-19 01:072016-10-24 09:17
Reporterpjuvara 
Assigned Todbaz 
PrioritynormalSeveritycriticalReproducibilityalways
StatusclosedResolutionduplicate 
PlatformOS5OS Version
Product Version3.0MP12.1 
Target VersionFixed in Version3.0MP15 
Merge Request Status
Review Assigned Todbaz
OBNetwork customer
Web browserGoogle Chrome
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2011-09-27
Regression introduced in release
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/7d3eaa3a17c45de0256302f2bee25b8984e722fc [^]
Triggers an Emergency PackNo
Summary0021381: Focus is lost after a record is saved in form view, resulting in incorrect operation of keyboards
DescriptionWhen you enter a record in Edit mode and you save it pressing CTRL+S, the focus is lost and it is no longer in the record.

This implies that the keyboard operations no longer work. If at a point you want to perform the two most common actions, which are
- Create a new record with CTRL+D, or
- Navigate to another screen opening the Quick menu with CTRL+O
these shortcuts are intercepted by the browser and - at least in Chrome - you are going to instead create a bookmark (CTRL+D) or open the dialog to open a local file.
Steps To ReproduceIn any window (for example: Sales order window), create a record (for example Sales order header) in form view. Save it using CTRL+S.
Try to create another record with CTRL+D
Proposed Solution
Additional Information
TagsCoworking
Relationships
duplicate of defect 0021420 closed dbaz [KS] CTRL+O does not consistently work 
related to defect 0034057 closed NaroaIriarte Wrong Tabulation Order in form fields in Organization window 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-08-19 01:07pjuvaraNew Issue
2012-08-19 01:07pjuvaraAssigned To => dbaz
2012-08-19 01:07pjuvaraWeb browser => Google Chrome
2012-08-19 01:07pjuvaraModules => Core
2012-08-19 01:07pjuvaraTag Attached: Coworking
2012-08-19 01:08pjuvaraNote Added: 0051345
2012-09-05 11:09dbazWeb browserGoogle Chrome => Google Chrome
2012-09-05 11:09dbazRegression level => Production - Confirmed Stable
2012-09-05 11:09dbazRegression date => 2011-09-27
2012-09-05 11:09dbazRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/7d3eaa3a17c45de0256302f2bee25b8984e722fc [^]
2012-09-05 11:10dbazNote Added: 0051869
2012-09-05 11:10dbazNote Added: 0051870
2012-09-05 11:10dbazNote Added: 0051871
2012-09-05 11:10dbazNote Added: 0051872
2012-09-05 11:11dbazClosed by => dbaz
2012-09-05 11:11dbazRelationship addedduplicate of 0021420
2012-09-05 11:11dbazNote Added: 0051873
2012-09-05 11:11dbazStatusnew => closed
2012-09-05 11:11dbazResolutionopen => duplicate
2012-09-05 11:11dbazFixed in Version => 3.0MP15
2016-10-24 09:17NaroaIriarteRelationship addedrelated to 0034057

Notes
(0051345)
pjuvara   
2012-08-19 01:08   
This might be a regression as I have the distinct recollection that this flow used to work smoothly.
(0051869)
dbaz   
2012-09-05 11:10   
The problem root is that the focus is lost once the "Save" button action is done (it can be reproduced using the mouse or the keyboard)
(0051870)
dbaz   
2012-09-05 11:10   
The problem is that before the regression commit, the previous focused item was stored:

https://code.openbravo.com/erp/devel/pi/rev/7d3eaa3a17c45de0256302f2bee25b8984e722fc#l1.201 [^] [^]

and then in the save callback it was restored

https://code.openbravo.com/erp/devel/pi/rev/7d3eaa3a17c45de0256302f2bee25b8984e722fc#l1.210 [^] [^]

This logic was using "storeFocusItem" and "restoreFocusItem" that also don't exist anymore:

https://code.openbravo.com/erp/devel/pi/rev/7d3eaa3a17c45de0256302f2bee25b8984e722fc#l1.263 [^] [^]


In the fix a simplified version of this code is going to be introduced in order to recover the logic.

The fix risk is medium, and should be supervised by Martin Taal
(0051871)
dbaz   
2012-09-05 11:10   
Repository: erp/devel/pi
Changeset: 2e55c0d0da0d133a538c77b6380340f7b4de53c8
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Fri Aug 31 22:27:11 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/2e55c0d0da0d133a538c77b6380340f7b4de53c8 [^] [^]

Fixed issue 21420: focus is set back in the form view after save action

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
---
(0051872)
dbaz   
2012-09-05 11:10   
Repository: erp/devel/pi
Changeset: 5492d5749d01b2fc25ba399063be8f3e78abf5c4
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Tue Sep 04 13:09:31 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/5492d5749d01b2fc25ba399063be8f3e78abf5c4 [^] [^]

Related to issue 21420: 'saveRow' focus logic is now more solid

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
---
(0051873)
dbaz   
2012-09-05 11:11   
Duplicate of
https://issues.openbravo.com/view.php?id=21420 [^]