Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0030712 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] Z. Others | minor | always | 2015-09-01 11:14 | 2016-02-02 09:35 | |||
| Reporter | maite | View Status | public | |||||
| Assigned To | aferraz | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | 3.0PR15Q4 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | a5243e3b4df9 | ||||
| Projection | none | ETA | none | Target Version | 3.0PR15Q4 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | dmiguelez | |||||||
| Web browser | ||||||||
| Modules | Advanced Payables and Receivables Mngmt | |||||||
| Regression level | Production - Confirmed Stable | |||||||
| Regression date | 2015-03-16 | |||||||
| Regression introduced in release | 3.0PR15Q2 | |||||||
| Regression introduced by commit | https://code.openbravo.com/erp/devel/pi/rev/41e10f964f97 [^] | |||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0030712: Payment Method not filled when running Add Payment From Invoice and business partner has not default Financial Account | |||||||
| Description | Payment Method not filled when running Add Payment From Invoice and business partner has not default Financial Account | |||||||
| Steps To Reproduce | 1. Access Business Partner "Alimentos y Supermercados" and leave Financial Account field empty in Customer tab 2. Register new Sales Invoice for this business partner, adding any line and process 3. Run Add Payment process and realize that Payment Method field is not filled | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||||||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||||||||||||
 Relationships |
|
Notes |
|
|
(0080002) aferraz (manager) 2015-09-01 17:32 edited on: 2015-09-04 09:41 |
Test plan: As F&B Admin: - Access Business Partner "Alimentos y Supermercados" and leave Financial Account field empty in Customer tab - Register new Sales Invoice for this business partner and "Transferencia" payment method, adding any line and process - Run Add Payment process and realize that Payment Method field is filled with "Transaction" (the document payment method). - Check that "Cuenta de Banco - EUR" can be selected in the field "Deposit To" - Change Payment Method to "Al contado" - Check that "Caja - EUR" can be selected in the field "Deposit To". - Register new Sales Invoice for this business partner and "Cheque" payment method, adding any line and process - Run Add Payment process and realize that Payment Method field is filled with "Cheque" (the document payment method). - Check that "Cuenta de Banco - EUR" can be selected in the field "Deposit To" - Go to Financial Account "Cuenta de Banco" and set "Cheque" payment method as active = false in Payment Method tab. - Register new Sales Invoice for this business partner and "Cheque" payment method, adding any line and process - Run Add Payment process and realize that Payment Method field is filled with "Transferencia" (the business partner default payment method). Realize also you can not select "Cheque" in payment method combo. - Access Business Partner "Alimentos y Supermercados" and leave Payment Method field empty in Customer tab - Register new Sales Invoice for this business partner and "Cheque" payment method, adding any line and process - Run Add Payment process and realize that Payment Method field is not filled. Realize also you can not select "Cheque" in payment method combo. You can only select "Al contado" or "Transferencia" and depending on the one selected "Deposit To" field selection changes as well. Repeat the same flows setting Financial Account = "Cuenta de Banco" to "Alimentos y Supermercados" Business Partner in Customer tab. The results should be the same. Verified. Repeat also the same flows opening Add Payment from any other window (Purchase Order, Sales Order, Purchase Invoice, Payment In, Payment Out). Verified. |
|
(0080050) psanjuan (manager) 2015-09-03 14:04 |
Scenario below related to issue 27119 also verified: -Go to Price List and create a new price list with this data: Organization: * Name: price list test Currency: EUR Sales price list: YES and add the product "Agua sin Gas 1L" -Go to Payment Method and create one with this data: Organization: * Name: payment method test -Go to Financial Account and create a new header with this data: Organization: F&B US, Inc. Name: Bank- test Currency: EUR Type:Bank and add the payment method created in previous step "payment method test" -Go to Business Partner and create a new customer with this data: Organization: * Name: business partner test Financial account: Bank- test Payment method: payment method test Price list: price list test -Go to Sales invoice: Organization: F&B España - Región Norte Business partner: business partner test Add a new line and complete the invoive Click in add payment, notice that the default value is Bank- test while it should be empty. |
|
(0080096) hgbot (developer) 2015-09-04 12:32 |
Repository: erp/devel/pi Changeset: 1d78ee2328c65c05cde007c6c0ab77b59075cb07 Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com> Date: Wed Sep 02 19:55:07 2015 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/1d78ee2328c65c05cde007c6c0ab77b59075cb07 [^] Fixes issue 30712: Payment Method not filled in Add Payment Payment Method was not filled when running Add Payment and business partner has no default Financial Account. When calling from getDefaultPaymentMethod to getFinancialAccountPaymentMethod in AddPaymentDefaultValuesHandler class with a null financialAccountId (in case of opening Add Payment from windows without Financial Account information like Purchase/Sales Order/Invoice and Business Partner does not have a default Financial Account setted), a NPE was raised and Payment Method was not filled in Add Payment. Now, in Purchase/Sales Order/Invoice windows, where is no financial account information in the context, document payment method will be taken if it is active for any financial account, if not, business partner default payment method will be taken instead (if it is active for any financial account and document organization has access to it). In those windows, Financial Account selector will show Business Partner default account if selected Payment Method belongs to it, or any Financial Account which Payment Method belongs to instead. In case of opening Add Payment from Payment In/Out windows, where exists Financial Account information in the context, Payment Method and Financial Account will be taken from the document. --- M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/AddPaymentDefaultValuesHandler.java --- |
|
(0080104) dmiguelez (developer) 2015-09-04 12:34 |
Code Review + Testing Ok |
|
(0080217) hudsonbot (developer) 2015-09-07 21:18 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f3ddf66cdf4b [^] Maturity status: Test |
|
(0080396) hgbot (developer) 2015-09-15 11:27 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 26b2e403b3d20bc961a513de43eb760cea607ccc Author: Rafa Alonso <ral <at> openbravo.com> Date: Tue Sep 15 10:45:33 2015 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/26b2e403b3d20bc961a513de43eb760cea607ccc [^] Backed out changeset: a5243e3b4df9, issue 30712, wrong issue assignment --- M web/org.openbravo.retail.posterminal/js/data/dataordersave.js --- |
|
(0083813) hgbot (developer) 2016-02-02 09:35 |
Repository: tools/automation/int Changeset: aa455fcdcc655750100294b9f656a5d7dbe9c165 Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com> Date: Mon Sep 28 19:31:30 2015 +0200 URL: http://code.openbravo.com/tools/automation/int/rev/aa455fcdcc655750100294b9f656a5d7dbe9c165 [^] Related to issue 30712: Added some automated tests --- M src-test/com/openbravo/test/integration/erp/data/financial/receivablespayables/transactions/financialaccount/PaymentMethodData.java M src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_Regressions/RegressionSuite.java M src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_Regressions/build.xml A src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_Regressions/APRRegression30712In.java A src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_Regressions/APRRegression30712Out.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2015-09-01 11:14 | maite | New Issue | |
| 2015-09-01 11:14 | maite | Assigned To | => Triage Finance |
| 2015-09-01 11:14 | maite | Modules | => Advanced Payables and Receivables Mngmt |
| 2015-09-01 11:14 | maite | Resolution time | => 1443996000 |
| 2015-09-01 11:14 | maite | Triggers an Emergency Pack | => No |
| 2015-09-01 11:14 | maite | Issue Monitored: networkb | |
| 2015-09-01 12:30 | aferraz | Assigned To | Triage Finance => aferraz |
| 2015-09-01 12:38 | aferraz | Regression level | => Production - Confirmed Stable |
| 2015-09-01 12:38 | aferraz | Regression date | => 2015-03-16 |
| 2015-09-01 12:38 | aferraz | Regression introduced in release | => 3.0PR14Q3.8 |
| 2015-09-01 12:38 | aferraz | Regression introduced by commit | => https://code.openbravo.com/erp/devel/pi/rev/41e10f964f97 [^] |
| 2015-09-01 12:39 | aferraz | Relationship added | caused by 0029252 |
| 2015-09-01 12:40 | aferraz | Status | new => scheduled |
| 2015-09-01 15:09 | aferraz | Relationship added | related to 0030719 |
| 2015-09-01 17:32 | aferraz | Note Added: 0080002 | |
| 2015-09-01 17:34 | aferraz | Relationship deleted | related to 0030719 |
| 2015-09-01 17:35 | aferraz | Relationship added | blocks 0030719 |
| 2015-09-01 17:53 | aferraz | Relationship deleted | blocks 0030719 |
| 2015-09-01 17:54 | aferraz | Relationship added | related to 0030719 |
| 2015-09-02 10:31 | aferraz | Relationship added | related to 0030623 |
| 2015-09-02 12:31 | psanjuan | Note Edited: 0080002 | View Revisions |
| 2015-09-02 12:32 | psanjuan | Note Edited: 0080002 | View Revisions |
| 2015-09-02 12:33 | psanjuan | Note Edited: 0080002 | View Revisions |
| 2015-09-02 12:36 | psanjuan | Note Edited: 0080002 | View Revisions |
| 2015-09-02 19:11 | aferraz | Relationship added | related to 0027119 |
| 2015-09-02 19:25 | aferraz | Regression introduced in release | 3.0PR14Q3.8 => 3.0PR15Q2 |
| 2015-09-03 10:31 | maite | Severity | major => minor |
| 2015-09-03 12:02 | aferraz | Relationship added | related to 0030641 |
| 2015-09-03 14:04 | psanjuan | Note Added: 0080050 | |
| 2015-09-03 15:03 | psanjuan | Note Edited: 0080002 | View Revisions |
| 2015-09-04 09:41 | psanjuan | Note Edited: 0080002 | View Revisions |
| 2015-09-04 12:32 | hgbot | Checkin | |
| 2015-09-04 12:32 | hgbot | Note Added: 0080096 | |
| 2015-09-04 12:32 | hgbot | Status | scheduled => resolved |
| 2015-09-04 12:32 | hgbot | Resolution | open => fixed |
| 2015-09-04 12:32 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/1d78ee2328c65c05cde007c6c0ab77b59075cb07 [^] |
| 2015-09-04 12:34 | dmiguelez | Review Assigned To | => dmiguelez |
| 2015-09-04 12:34 | dmiguelez | Note Added: 0080104 | |
| 2015-09-04 12:34 | dmiguelez | Status | resolved => closed |
| 2015-09-07 21:18 | hudsonbot | Checkin | |
| 2015-09-07 21:18 | hudsonbot | Note Added: 0080217 | |
| 2015-09-14 22:17 | hgbot | Checkin | |
| 2015-09-14 22:17 | hgbot | Note Added: 0080392 | |
| 2015-09-14 22:17 | hgbot | Status | closed => resolved |
| 2015-09-14 22:17 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/devel/pi/rev/1d78ee2328c65c05cde007c6c0ab77b59075cb07 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a5243e3b4df9ab15e8d0851d811b99c5674c2108 [^] |
| 2015-09-15 10:36 | Orekaria | Note Deleted: 0080392 | |
| 2015-09-15 11:27 | hgbot | Checkin | |
| 2015-09-15 11:27 | hgbot | Note Added: 0080396 | |
| 2015-09-22 09:50 | aferraz | Status | resolved => closed |
| 2015-09-22 09:51 | aferraz | Fixed in Version | => 3.0PR15Q4 |
| 2016-02-02 09:35 | hgbot | Checkin | |
| 2016-02-02 09:35 | hgbot | Note Added: 0083813 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |