Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0029252
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] Z. Othersminoralways2015-03-12 11:152015-03-24 03:44
ReportermaiteView Statuspublic 
Assigned Toumartirena 
PriorityimmediateResolutionfixedFixed in Version3.0PR15Q2
StatusclosedFix in branchFixed in SCM revision41e10f964f97
ProjectionnoneETAnoneTarget Version3.0PR15Q2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned ToSandrahuguet
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0029252: Payment Method combo does not work in Add Payment process definition, when payment method considered as default is unactive

DescriptionPayment Method combo does not work in Add Payment process definition, when payment method considered as default is unactive
Steps To Reproduce1. Access "Cuenta de banco" financial account, access Payment MEthod tab and set "Cheque" payment method as ACTIVE=NO
2. Access Transactions tab. Press "+" button to add a new payment. Try to select another payment method in the combo and realize that values are not show
Proposed SolutionProblem is that value for "Deposit to" field (which is a financial account) has not been loaded in Add Payment window. Financial Account has not been loaded because "Cheque" payment method is not active for it, so root problem is in "getDefaultPaymentMethod" method of TransactionAddPaymentDefaultValues.java, because it is also considering unactive payment methods
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 00292993.0PR15Q1.2 closedumartirena Payment Method combo does not work in Add Payment process definition, when payment method considered as default is unactive 
depends on backport 00293003.0PR14Q3.8 closedSandrahuguet Payment Method combo does not work in Add Payment process definition, when payment method considered as default is unactive 
related to defect 0029368 closedjorge-garcia It is possible to create a payment header when a payment method is disabled in a given financial account 
related to defect 00307193.0PR15Q4 closedaferraz Deposit To in Add Payment should only show financial accounts where selected payment method is active 
causes defect 00307123.0PR15Q4 closedaferraz Payment Method not filled when running Add Payment From Invoice and business partner has not default Financial Account 

-  Notes
(0075855)
hgbot (developer)
2015-03-23 12:59

 Repository: erp/devel/pi
Changeset: 41e10f964f97a80fb54a463edda349da9a120922
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Mon Mar 16 17:07:49 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/41e10f964f97a80fb54a463edda349da9a120922 [^]

Fixes bug 29252: Payment method in add payment does not display inactive values

The whereClause of fin_payment_method combo in add payment has been changed to not display never payment methods that are inactive.

Also the default values of Add Payment window that are opened from all windows has been changed to not set as default a Payment Method that is inactive, even if it is marked as default in the financial account or if is the default payment method of the Business Partner.

A change has also been done in OB.APRM.AddPayment.paymentMethodMulticurrency javascript function. In Add Payment window, while clearing Payment Method combo manually, the Financial Account was also being cleared. This was causing a problem when opening from Financial Account, because in this case novalues were displayed on both combos any more. It has been fixed to not to clear the Financial Account combo in this case as always is going to be the same, so it is no necessary to clear it.

---
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/OBUISEL_SELECTOR.xml
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/AddPaymentDefaultValuesHandler.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/TransactionAddPaymentDefaultValues.java
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js
---
(0075856)
hgbot (developer)
2015-03-23 12:59

 Repository: erp/devel/pi
Changeset: df7e81f69e35cfa424ec64ee509f1baebea3948c
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Mon Mar 23 12:56:19 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/df7e81f69e35cfa424ec64ee509f1baebea3948c [^]

related to issue 29252 update Copyright

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/AddPaymentDefaultValuesHandler.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/TransactionAddPaymentDefaultValues.java
---
(0075860)
Sandrahuguet (developer)
2015-03-23 13:13

 Code review + testing OK
(0075907)
hudsonbot (developer)
2015-03-24 03:44

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/63f9617f42fb [^]
Maturity status: Test
(0075908)
hudsonbot (developer)
2015-03-24 03:44

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/63f9617f42fb [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2015-03-12 11:15 maite New Issue
2015-03-12 11:15 maite Assigned To => Sandrahuguet
2015-03-12 11:15 maite Modules => Core
2015-03-12 11:15 maite Resolution time => 1432504800
2015-03-12 11:15 maite Triggers an Emergency Pack => No
2015-03-12 11:15 maite Issue Monitored: networkb
2015-03-16 18:21 umartirena Status new => scheduled
2015-03-16 18:21 umartirena Assigned To Sandrahuguet => umartirena
2015-03-23 12:37 Sandrahuguet Relationship added related to 0029368
2015-03-23 12:59 hgbot Checkin
2015-03-23 12:59 hgbot Note Added: 0075855
2015-03-23 12:59 hgbot Status scheduled => resolved
2015-03-23 12:59 hgbot Resolution open => fixed
2015-03-23 12:59 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/41e10f964f97a80fb54a463edda349da9a120922 [^]
2015-03-23 12:59 hgbot Checkin
2015-03-23 12:59 hgbot Note Added: 0075856
2015-03-23 13:13 Sandrahuguet Review Assigned To => Sandrahuguet
2015-03-23 13:13 Sandrahuguet Note Added: 0075860
2015-03-23 13:13 Sandrahuguet Status resolved => closed
2015-03-23 13:13 Sandrahuguet Fixed in Version => 3.0PR15Q2
2015-03-24 03:44 hudsonbot Checkin
2015-03-24 03:44 hudsonbot Note Added: 0075907
2015-03-24 03:44 hudsonbot Checkin
2015-03-24 03:44 hudsonbot Note Added: 0075908
2015-09-01 12:39 aferraz Relationship added causes 0030712
2015-09-01 15:09 aferraz Relationship added related to 0030719

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker