Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0029299 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [Openbravo ERP] Z. Others | minor | always | 2015-03-12 11:15 | 2015-04-01 08:31 | |||
| Reporter | maite | View Status | public | |||||
| Assigned To | umartirena | |||||||
| Priority | immediate | Resolution | fixed | Fixed in Version | 3.0PR15Q1.2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 06da2fdf1e69 | ||||
| Projection | none | ETA | none | Target Version | 3.0PR15Q1.2 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | Sandrahuguet | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0029299: Payment Method combo does not work in Add Payment process definition, when payment method considered as default is unactive | |||||||
| Description | Payment Method combo does not work in Add Payment process definition, when payment method considered as default is unactive | |||||||
| Steps To Reproduce | 1. Access "Cuenta de banco" financial account, access Payment MEthod tab and set "Cheque" payment method as ACTIVE=NO 2. Access Transactions tab. Press "+" button to add a new payment. Try to select another payment method in the combo and realize that values are not show | |||||||
| Proposed Solution | Problem is that value for "Deposit to" field (which is a financial account) has not been loaded in Add Payment window. Financial Account has not been loaded because "Cheque" payment method is not active for it, so root problem is in "getDefaultPaymentMethod" method of TransactionAddPaymentDefaultValues.java, because it is also considering unactive payment methods | |||||||
| Tags | Approved | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0075857) hgbot (developer) 2015-03-23 13:11 |
Repository: erp/backports/3.0PR15Q1.2 Changeset: 06da2fdf1e69c8e5ef34e73bb10f81f9f788c0a8 Author: Unai Martirena <unai.martirena <at> openbravo.com> Date: Mon Mar 16 17:07:49 2015 +0100 URL: http://code.openbravo.com/erp/backports/3.0PR15Q1.2/rev/06da2fdf1e69c8e5ef34e73bb10f81f9f788c0a8 [^] Fixes bug 29299: Payment method in add payment does not display inactive values The whereClause of fin_payment_method combo in add payment has been changed to not display never payment methods that are inactive. Also the default values of Add Payment window that are opened from all windows has been changed to not set as default a Payment Method that is inactive, even if it is marked as default in the financial account or if is the default payment method of the Business Partner. A change has also been done in OB.APRM.AddPayment.paymentMethodMulticurrency javascript function. In Add Payment window, while clearing Payment Method combo manually, the Financial Account was also being cleared. This was causing a problem when opening from Financial Account, because in this case novalues were displayed on both combos any more. It has been fixed to not to clear the Financial Account combo in this case as always is going to be the same, so it is no necessary to clear it. --- M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/OBUISEL_SELECTOR.xml M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/AddPaymentDefaultValuesHandler.java M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/TransactionAddPaymentDefaultValues.java M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js --- |
|
(0075858) Sandrahuguet (developer) 2015-03-23 13:12 |
https://code.openbravo.com/erp/backports/3.0PR15Q1.2/rev/0dad76d49f3d [^] |
|
(0075859) Sandrahuguet (developer) 2015-03-23 13:13 |
Code review + testing OK |
|
(0076226) hgbot (developer) 2015-04-01 08:08 |
Repository: erp/backports/3.0PR15Q2 Changeset: 06da2fdf1e69c8e5ef34e73bb10f81f9f788c0a8 Author: Unai Martirena <unai.martirena <at> openbravo.com> Date: Mon Mar 16 17:07:49 2015 +0100 URL: http://code.openbravo.com/erp/backports/3.0PR15Q2/rev/06da2fdf1e69c8e5ef34e73bb10f81f9f788c0a8 [^] Fixes bug 29299: Payment method in add payment does not display inactive values The whereClause of fin_payment_method combo in add payment has been changed to not display never payment methods that are inactive. Also the default values of Add Payment window that are opened from all windows has been changed to not set as default a Payment Method that is inactive, even if it is marked as default in the financial account or if is the default payment method of the Business Partner. A change has also been done in OB.APRM.AddPayment.paymentMethodMulticurrency javascript function. In Add Payment window, while clearing Payment Method combo manually, the Financial Account was also being cleared. This was causing a problem when opening from Financial Account, because in this case novalues were displayed on both combos any more. It has been fixed to not to clear the Financial Account combo in this case as always is going to be the same, so it is no necessary to clear it. --- M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/OBUISEL_SELECTOR.xml M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/AddPaymentDefaultValuesHandler.java M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/TransactionAddPaymentDefaultValues.java M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js --- |
|
(0076257) priyam (administrator) 2015-04-01 08:31 |
closed again, as the status changed due the merge tag of 3.0PR15Q1.2 to backports/3.0PR15Q2 |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2015-03-16 18:21 | umartirena | Type | defect => backport |
| 2015-03-16 18:21 | umartirena | Target Version | 3.0PR15Q2 => 3.0PR15Q1.2 |
| 2015-03-23 13:11 | hgbot | Checkin | |
| 2015-03-23 13:11 | hgbot | Note Added: 0075857 | |
| 2015-03-23 13:11 | hgbot | Status | scheduled => resolved |
| 2015-03-23 13:11 | hgbot | Resolution | open => fixed |
| 2015-03-23 13:11 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/backports/3.0PR15Q1.2/rev/06da2fdf1e69c8e5ef34e73bb10f81f9f788c0a8 [^] |
| 2015-03-23 13:12 | Sandrahuguet | Note Added: 0075858 | |
| 2015-03-23 13:13 | Sandrahuguet | Review Assigned To | => Sandrahuguet |
| 2015-03-23 13:13 | Sandrahuguet | Note Added: 0075859 | |
| 2015-03-23 13:13 | Sandrahuguet | Status | resolved => closed |
| 2015-03-23 13:13 | Sandrahuguet | Fixed in Version | => 3.0PR15Q1.2 |
| 2015-03-23 13:13 | Sandrahuguet | Assigned To | Sandrahuguet => umartirena |
| 2015-03-23 20:18 | dmitry_mezentsev | Tag Attached: Approved | |
| 2015-04-01 08:08 | hgbot | Checkin | |
| 2015-04-01 08:08 | hgbot | Note Added: 0076226 | |
| 2015-04-01 08:08 | hgbot | Status | closed => resolved |
| 2015-04-01 08:08 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/backports/3.0PR15Q1.2/rev/06da2fdf1e69c8e5ef34e73bb10f81f9f788c0a8 [^] => http://code.openbravo.com/erp/backports/3.0PR15Q2/rev/06da2fdf1e69c8e5ef34e73bb10f81f9f788c0a8 [^] |
| 2015-04-01 08:31 | priyam | Status | resolved => closed |
| 2015-04-01 08:31 | priyam | Note Added: 0076257 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |