Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0030719
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 09. Financial managementminoralways2015-09-01 15:072015-09-07 21:18
ReporteraferrazView Statuspublic 
Assigned Toaferraz 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisionddf0351fd69a
ProjectionnoneETAnoneTarget Version3.0PR15Q4
OSLinux 64 bitDatabasePostgreSQLJava version1.6.0_18
OS VersionProfessional ApplianceDatabase version8.3.9Ant version1.7.1
Product VersionSCM revision 
Review Assigned Todmiguelez
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0030719: Deposit To in Add Payment should only show financial accounts where selected payment method is active

DescriptionDeposit To in Add Payment should only show financial accounts where selected payment method is active
Steps To ReproduceAs group admin:

- Go to Financial Account "Caja" and create "Transferencia" payment method as active = false in Payment Method tab.
- Create a Sales Invoice for "Alimentos y Supermercados" with "Transferencia" payment method. Add any product and complete it.
- Click on Add Payment.
- Realize "Transferencia" payment method is filled automatically.
- Click on Deposit To and realize "Caja" and "Cuenta de Banco" financial accounts appears available. Select "Caja". Realize "Deposit To" combo gets empty automatically.

Deposit To combo should only show "Cuenta de Banco" financial account as "Transferencia" payment method is active for this account but not for "Caja".
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 00292523.0PR15Q2 closedumartirena Payment Method combo does not work in Add Payment process definition, when payment method considered as default is unactive 
related to defect 00307123.0PR15Q4 closedaferraz Payment Method not filled when running Add Payment From Invoice and business partner has not default Financial Account 
related to defect 0027119 closedSandrahuguet Wrong default value in deposit to combo in add payment popup in some circumstances 
related to defect 00306413.0PR15Q4 closedaferraz Payment Method not reloaded when setting Business Partner in Add Payment process from Transaction tab 
related to defect 0030750 newTriage Omni OMS Payment Method info do not automatically filled in while creating a Payment if BP does not have a financial account related. 
related to defect 00306233.0PR15Q4 closedaferraz "deposit to" field in Add Payment process does not show all available financial accounts 

-  Notes
(0080003)
aferraz (manager)
2015-09-01 17:34
edited on: 2015-09-03 14:59

 Test plan:

As F&B Admin:

Scenario 1

- Go to Business Partner window and search by Alimentos y Supermercados BP.
- Remove Financial Account info from "Customer" tab
- Make sure that "Transferencia" Payment Method is filled in.
- Go to Financial Account "Caja" and create "Transferencia" payment method as active = false in Payment Method tab.
- Create a Sales Invoice for "Alimentos y Supermercados" with "Transferencia" payment method. Add any product and complete it.
- Click on Add Payment.
- Realize "Transferencia" payment method is filled automatically.
- Click on Deposit To and realize only "Cuenta de Banco" financial account appears available.

Scenario 2

- Go to Business Partner window and search by "Alimentos y Supermercados" BP
- Add "Cuenta de Banco" Financial Account in "Customer" tab
- Make sure that "Transferencia" Payment Method is filled in.
- Create a Sales Invoice for "Alimentos y Supermercados" with "Transferencia" payment method. Add any product and complete it.
- Click on Add Payment.
- Realize "Transferencia" payment method is filled automatically, same as "Cuenta de Banco" financial account.

Scenario 3
- Go to Business Partner window and search by "Alimentos y Supermercados" BP
- Add "Caja" Financial Account in "Customer" tab
- Make sure that "Transferencia" Payment Method is filled in.
- Create a Sales Invoice for "Alimentos y Supermercados" with "Transferencia" payment method. Add any product and complete it.
- Click on Add Payment.
- Realize that both "Payment Method" and "Deposit To" fields are filled in as "Transferecia" payment method is active in "Cuenta de Banco" financial account.

Scenario 4

- Go to Financial Account window, search by "Cuenta de Banco".
- Go to Transactions tab and add a new one (BP Deposit).
- Click on the "+" option of Payment field.
- In the "Add Payment" window, select "Alimentos y Supermercados" in the field "Received From".
- Realize that "Transferencia" payment method is shown.

Scenario 5

- Go to Financial Account window, search by "Caja".
- Go to Transactions tab and add a new one (BP Deposit).
- Click on the "+" option of Payment field.
- In the "Add Payment" window, select "Alimentos y Supermercados" in the field "Received From".
- Realize that "Transferencia" payment method is shown, regardless it is not active for this financial account.
- Enter "100" in the field "Actual Payment" and select any of the transaction show below.
- Press "Done"
- An error message is shown saying that "Selected Payment method doesn't exist".

This scenario can be improved either:
- by improving the error message as "Selected Payment Method is not Active for the Financial Account".
- or by do not showing "Transferencia" as valid Payment Method for "Caja" financial account, regardless it is the one assigned to the Business Partner, therefore another valid payment method for the financial account need to be selected.

Scenario 5 improved:
"Payment Method" field does not show "Transferencia" payment method anymore but the ones active for the Financial Account. See also issue 30641

Repeat scenarios 1,2 and 3 above for Sales Order. Verified it is also working.

Scenario 6
- Go to Business Partner window, search by "Alimentos y Supermercados" BP. Go to customer tab and fill in below info:
Financial Account = Cuenta de Banco
Payment method = Transferencia
- Go to Payment In window and create a new payment for Alimentos y Supermercados.
- Realize that Payment Method and Financial Account fields are properly filled in.

Scenario 7
- Go to Business Partner window, search by "Alimentos y Supermercados" BP. Go to customer tab and fill in below info:
Financial Account = Caja
Payment method = Transferencia
- Go to Payment In window and create a new payment for Alimentos y Supermercados.
- Realize that an error is shown: "The default payment method "Transferencia" for the financial account Caja is inactive. Please consider to activate it.
(This is correct)

Scenario 8
- Go to Business Partner window, search by "Alimentos y Supermercados" BP. Go to customer tab and fill in below info:
Financial Account = empty
Payment method = Transferencia
- Go to Payment In window and create a new payment for Alimentos y Supermercados.
- Realize that "Payment Method" field is not automatically populated with defaulted payment method "Transferencia". See issue related: 30750

Scenario 9
- Go to Business Partner window, search by "Alimentos y Supermercados" BP. Go to customer tab and fill in below info:
Financial Account = Cuenta de Banco
Payment method = Transferencia
- Go to Payment In window and create a new payment for Alimentos y Supermercados.
- Realize that "Payment Method" field is automatically populated with defaulted payment method "Transferencia", same as "Financial Account".

Repeat all of the steps above for Vendor BP, Purchase Order/Invoice, Payment Out, Financial Account BP Withdrawal. All verified.

This issue can be closed.
(0080098)
hgbot (developer)
2015-09-04 12:32

 Repository: erp/devel/pi
Changeset: ddf0351fd69a2558c761230bf58fc259100bf0d4
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Tue Sep 01 15:08:49 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/ddf0351fd69a2558c761230bf58fc259100bf0d4 [^]

Fixes issue 30719: Deposit To in Add Payment does not filter correctly

Deposit To in Add Payment should only show financial accounts where selected payment method is active.

---
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/OBUISEL_SELECTOR.xml
---
(0080105)
dmiguelez (developer)
2015-09-04 12:35

 Code Review + Testing Ok
(0080218)
hudsonbot (developer)
2015-09-07 21:18

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f3ddf66cdf4b [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2015-09-01 15:07 aferraz New Issue
2015-09-01 15:07 aferraz Assigned To => aferraz
2015-09-01 15:07 aferraz Modules => Core
2015-09-01 15:07 aferraz Triggers an Emergency Pack => No
2015-09-01 15:09 aferraz Relationship added related to 0030712
2015-09-01 15:09 aferraz Relationship added related to 0029252
2015-09-01 15:09 aferraz Status new => scheduled
2015-09-01 17:34 aferraz Note Added: 0080003
2015-09-01 17:34 aferraz Relationship deleted related to 0030712
2015-09-01 17:35 aferraz Relationship added depends on 0030712
2015-09-01 17:53 aferraz Steps to Reproduce Updated View Revisions
2015-09-01 17:53 aferraz Relationship deleted depends on 0030712
2015-09-01 17:54 aferraz Relationship added related to 0030712
2015-09-01 17:55 aferraz Note Edited: 0080003 View Revisions
2015-09-02 10:31 aferraz Relationship added related to 0030623
2015-09-02 13:39 psanjuan Note Edited: 0080003 View Revisions
2015-09-02 13:40 psanjuan Note Edited: 0080003 View Revisions
2015-09-02 13:46 psanjuan Note Edited: 0080003 View Revisions
2015-09-02 13:48 psanjuan Note Edited: 0080003 View Revisions
2015-09-02 14:02 psanjuan Note Edited: 0080003 View Revisions
2015-09-02 19:11 aferraz Relationship added related to 0027119
2015-09-03 12:03 aferraz Relationship added related to 0030641
2015-09-03 13:37 psanjuan Note Edited: 0080003 View Revisions
2015-09-03 13:40 psanjuan Note Edited: 0080003 View Revisions
2015-09-03 13:42 psanjuan Note Edited: 0080003 View Revisions
2015-09-03 13:45 psanjuan Note Edited: 0080003 View Revisions
2015-09-03 13:52 psanjuan Note Edited: 0080003 View Revisions
2015-09-03 13:57 psanjuan Relationship added related to 0030750
2015-09-03 13:58 psanjuan Note Edited: 0080003 View Revisions
2015-09-03 14:44 psanjuan Note Edited: 0080003 View Revisions
2015-09-03 14:59 psanjuan Note Edited: 0080003 View Revisions
2015-09-04 12:32 hgbot Checkin
2015-09-04 12:32 hgbot Note Added: 0080098
2015-09-04 12:32 hgbot Status scheduled => resolved
2015-09-04 12:32 hgbot Resolution open => fixed
2015-09-04 12:32 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ddf0351fd69a2558c761230bf58fc259100bf0d4 [^]
2015-09-04 12:35 dmiguelez Review Assigned To => dmiguelez
2015-09-04 12:35 dmiguelez Note Added: 0080105
2015-09-04 12:35 dmiguelez Status resolved => closed
2015-09-07 21:18 hudsonbot Checkin
2015-09-07 21:18 hudsonbot Note Added: 0080218

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker