0030719: Deposit To in Add Payment should only show financial accounts where selected payment method is active - Openbravo Issue Tracking System

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

ID

Project

Category

View Status

Date Submitted

Last Update

0030719

Openbravo ERP

09. Financial management

public

2015-09-01 15:07

2015-09-07 21:18

Reporter

aferraz

Assigned To

aferraz

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS

30

OS Version

Professional Appliance

Product Version

Target Version

3.0PR15Q4

Fixed in Version

Merge Request Status

Review Assigned To

dmiguelez

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0030719: Deposit To in Add Payment should only show financial accounts where selected payment method is active

Description

Deposit To in Add Payment should only show financial accounts where selected payment method is active

Steps To Reproduce

As group admin:

- Go to Financial Account "Caja" and create "Transferencia" payment method as active = false in Payment Method tab.
- Create a Sales Invoice for "Alimentos y Supermercados" with "Transferencia" payment method. Add any product and complete it.
- Click on Add Payment.
- Realize "Transferencia" payment method is filled automatically.
- Click on Deposit To and realize "Caja" and "Cuenta de Banco" financial accounts appears available. Select "Caja". Realize "Deposit To" combo gets empty automatically.

Deposit To combo should only show "Cuenta de Banco" financial account as "Transferencia" payment method is active for this account but not for "Caja".

Proposed Solution

Additional Information

Tags

No tags attached.

Relationships

related to	defect	0029252	3.0PR15Q2	closed	umartirena	Payment Method combo does not work in Add Payment process definition, when payment method considered as default is unactive
related to	defect	0030712	3.0PR15Q4	closed	aferraz	Payment Method not filled when running Add Payment From Invoice and business partner has not default Financial Account
related to	defect	0027119		closed	Sandrahuguet	Wrong default value in deposit to combo in add payment popup in some circumstances
related to	defect	0030641	3.0PR15Q4	closed	aferraz	Payment Method not reloaded when setting Business Partner in Add Payment process from Transaction tab
related to	defect	0030750		new	Triage Omni OMS	Payment Method info do not automatically filled in while creating a Payment if BP does not have a financial account related.
related to	defect	0030623	3.0PR15Q4	closed	aferraz	"deposit to" field in Add Payment process does not show all available financial accounts

Attached Files

Issue History

Date Modified

Username

Field

Change

2015-09-01 15:07

New Issue

2015-09-01 15:07

Assigned To

=> aferraz

2015-09-01 15:07

Modules

=> Core

2015-09-01 15:07

Triggers an Emergency Pack

=> No

2015-09-01 15:09

Relationship added

related to 0030712

2015-09-01 15:09

Relationship added

related to 0029252

2015-09-01 15:09

Status

new => scheduled

2015-09-01 17:34

Note Added: 0080003

2015-09-01 17:34

Relationship deleted

related to 0030712

2015-09-01 17:35

Relationship added

depends on 0030712

2015-09-01 17:53

Steps to Reproduce Updated

bug_revision_view_page.php?rev_id=9306#r9306

2015-09-01 17:53

Relationship deleted

depends on 0030712

2015-09-01 17:54

Relationship added

related to 0030712

2015-09-01 17:55

Note Edited: 0080003

bug_revision_view_page.php?bugnote_id=0080003#r9308

2015-09-02 10:31

Relationship added

related to 0030623

2015-09-02 13:39

Note Edited: 0080003

bug_revision_view_page.php?bugnote_id=0080003#r9315

2015-09-02 13:40

Note Edited: 0080003

bug_revision_view_page.php?bugnote_id=0080003#r9316

2015-09-02 13:46

Note Edited: 0080003

bug_revision_view_page.php?bugnote_id=0080003#r9317

2015-09-02 13:48

Note Edited: 0080003

bug_revision_view_page.php?bugnote_id=0080003#r9318

2015-09-02 14:02

Note Edited: 0080003

bug_revision_view_page.php?bugnote_id=0080003#r9319

2015-09-02 19:11

Relationship added

related to 0027119

2015-09-03 12:03

Relationship added

related to 0030641

2015-09-03 13:37

Note Edited: 0080003

bug_revision_view_page.php?bugnote_id=0080003#r9327

2015-09-03 13:40

Note Edited: 0080003

bug_revision_view_page.php?bugnote_id=0080003#r9328

2015-09-03 13:42

Note Edited: 0080003

bug_revision_view_page.php?bugnote_id=0080003#r9329

2015-09-03 13:45

Note Edited: 0080003

bug_revision_view_page.php?bugnote_id=0080003#r9330

2015-09-03 13:52

Note Edited: 0080003

bug_revision_view_page.php?bugnote_id=0080003#r9331

2015-09-03 13:57

Relationship added

related to 0030750

2015-09-03 13:58

Note Edited: 0080003

bug_revision_view_page.php?bugnote_id=0080003#r9332

2015-09-03 14:44

Note Edited: 0080003

bug_revision_view_page.php?bugnote_id=0080003#r9333

2015-09-03 14:59

Note Edited: 0080003

bug_revision_view_page.php?bugnote_id=0080003#r9334

2015-09-04 12:32

Checkin

2015-09-04 12:32

Note Added: 0080098

2015-09-04 12:32

Status

scheduled => resolved

2015-09-04 12:32

Resolution

open => fixed

2015-09-04 12:32

Fixed in SCM revision

=> http://code.openbravo.com/erp/devel/pi/rev/ddf0351fd69a2558c761230bf58fc259100bf0d4 [^]

2015-09-04 12:35

Review Assigned To

=> dmiguelez

2015-09-04 12:35

Note Added: 0080105

2015-09-04 12:35

Status

resolved => closed

2015-09-07 21:18

Checkin

2015-09-07 21:18

Note Added: 0080218

Notes

Test plan:

As F&B Admin:

Scenario 1

- Go to Business Partner window and search by Alimentos y Supermercados BP.
- Remove Financial Account info from "Customer" tab
- Make sure that "Transferencia" Payment Method is filled in.
- Go to Financial Account "Caja" and create "Transferencia" payment method as active = false in Payment Method tab.
- Create a Sales Invoice for "Alimentos y Supermercados" with "Transferencia" payment method. Add any product and complete it.
- Click on Add Payment.
- Realize "Transferencia" payment method is filled automatically.
- Click on Deposit To and realize only "Cuenta de Banco" financial account appears available.

Scenario 2

- Go to Business Partner window and search by "Alimentos y Supermercados" BP
- Add "Cuenta de Banco" Financial Account in "Customer" tab
- Make sure that "Transferencia" Payment Method is filled in.
- Create a Sales Invoice for "Alimentos y Supermercados" with "Transferencia" payment method. Add any product and complete it.
- Click on Add Payment.
- Realize "Transferencia" payment method is filled automatically, same as "Cuenta de Banco" financial account.

Scenario 3
- Go to Business Partner window and search by "Alimentos y Supermercados" BP
- Add "Caja" Financial Account in "Customer" tab
- Make sure that "Transferencia" Payment Method is filled in.
- Create a Sales Invoice for "Alimentos y Supermercados" with "Transferencia" payment method. Add any product and complete it.
- Click on Add Payment.
- Realize that both "Payment Method" and "Deposit To" fields are filled in as "Transferecia" payment method is active in "Cuenta de Banco" financial account.

Scenario 4

- Go to Financial Account window, search by "Cuenta de Banco".
- Go to Transactions tab and add a new one (BP Deposit).
- Click on the "+" option of Payment field.
- In the "Add Payment" window, select "Alimentos y Supermercados" in the field "Received From".
- Realize that "Transferencia" payment method is shown.

Scenario 5

- Go to Financial Account window, search by "Caja".
- Go to Transactions tab and add a new one (BP Deposit).
- Click on the "+" option of Payment field.
- In the "Add Payment" window, select "Alimentos y Supermercados" in the field "Received From".
- Realize that "Transferencia" payment method is shown, regardless it is not active for this financial account.
- Enter "100" in the field "Actual Payment" and select any of the transaction show below.
- Press "Done"
- An error message is shown saying that "Selected Payment method doesn't exist".

This scenario can be improved either:
- by improving the error message as "Selected Payment Method is not Active for the Financial Account".
- or by do not showing "Transferencia" as valid Payment Method for "Caja" financial account, regardless it is the one assigned to the Business Partner, therefore another valid payment method for the financial account need to be selected.

Scenario 5 improved:
"Payment Method" field does not show "Transferencia" payment method anymore but the ones active for the Financial Account. See also issue 30641

Repeat scenarios 1,2 and 3 above for Sales Order. Verified it is also working.

Scenario 6
- Go to Business Partner window, search by "Alimentos y Supermercados" BP. Go to customer tab and fill in below info:
Financial Account = Cuenta de Banco
Payment method = Transferencia
- Go to Payment In window and create a new payment for Alimentos y Supermercados.
- Realize that Payment Method and Financial Account fields are properly filled in.

Scenario 7
- Go to Business Partner window, search by "Alimentos y Supermercados" BP. Go to customer tab and fill in below info:
Financial Account = Caja
Payment method = Transferencia
- Go to Payment In window and create a new payment for Alimentos y Supermercados.
- Realize that an error is shown: "The default payment method "Transferencia" for the financial account Caja is inactive. Please consider to activate it.
(This is correct)

Scenario 8
- Go to Business Partner window, search by "Alimentos y Supermercados" BP. Go to customer tab and fill in below info:
Financial Account = empty
Payment method = Transferencia
- Go to Payment In window and create a new payment for Alimentos y Supermercados.
- Realize that "Payment Method" field is not automatically populated with defaulted payment method "Transferencia". See issue related: 30750

Scenario 9
- Go to Business Partner window, search by "Alimentos y Supermercados" BP. Go to customer tab and fill in below info:
Financial Account = Cuenta de Banco
Payment method = Transferencia
- Go to Payment In window and create a new payment for Alimentos y Supermercados.
- Realize that "Payment Method" field is automatically populated with defaulted payment method "Transferencia", same as "Financial Account".

Repeat all of the steps above for Vendor BP, Purchase Order/Invoice, Payment Out, Financial Account BP Withdrawal. All verified.

This issue can be closed.