Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0030712Openbravo ERPZ. Otherspublic2015-09-01 11:142016-02-02 09:35
maite 
aferraz 
urgentminoralways
closedfixed 
5
 
3.0PR15Q43.0PR15Q4 
dmiguelez
Advanced Payables and Receivables Mngmt
Production - Confirmed Stable
2015-03-16
3.0PR15Q2
https://code.openbravo.com/erp/devel/pi/rev/41e10f964f97 [^]
No
0030712: Payment Method not filled when running Add Payment From Invoice and business partner has not default Financial Account
Payment Method not filled when running Add Payment From Invoice and business partner has not default Financial Account
1. Access Business Partner "Alimentos y Supermercados" and leave Financial Account field empty in Customer tab
2. Register new Sales Invoice for this business partner, adding any line and process
3. Run Add Payment process and realize that Payment Method field is not filled
No tags attached.
related to defect 0027119 closed Sandrahuguet Wrong default value in deposit to combo in add payment popup in some circumstances 
related to defect 00306413.0PR15Q4 closed aferraz Payment Method not reloaded when setting Business Partner in Add Payment process from Transaction tab 
depends on backport 00307143.0PR15Q3.1 closed aferraz Payment Method not filled when running Add Payment From Invoice and business partner has not default Financial Account 
depends on backport 00307153.0PR15Q2.5 closed aferraz Payment Method not filled when running Add Payment From Invoice and business partner has not default Financial Account 
caused by defect 00292523.0PR15Q2 closed umartirena Payment Method combo does not work in Add Payment process definition, when payment method considered as default is unactive 
related to defect 00307193.0PR15Q4 closed aferraz Deposit To in Add Payment should only show financial accounts where selected payment method is active 
related to defect 00306233.0PR15Q4 closed aferraz "deposit to" field in Add Payment process does not show all available financial accounts 
Issue History
2015-09-01 11:14maiteNew Issue
2015-09-01 11:14maiteAssigned To => Triage Finance
2015-09-01 11:14maiteModules => Advanced Payables and Receivables Mngmt
2015-09-01 11:14maiteResolution time => 1443996000
2015-09-01 11:14maiteTriggers an Emergency Pack => No
2015-09-01 11:14maiteIssue Monitored: networkb
2015-09-01 12:30aferrazAssigned ToTriage Finance => aferraz
2015-09-01 12:38aferrazRegression level => Production - Confirmed Stable
2015-09-01 12:38aferrazRegression date => 2015-03-16
2015-09-01 12:38aferrazRegression introduced in release => 3.0PR14Q3.8
2015-09-01 12:38aferrazRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/41e10f964f97 [^]
2015-09-01 12:39aferrazRelationship addedcaused by 0029252
2015-09-01 12:40aferrazStatusnew => scheduled
2015-09-01 15:09aferrazRelationship addedrelated to 0030719
2015-09-01 17:32aferrazNote Added: 0080002
2015-09-01 17:34aferrazRelationship deletedrelated to 0030719
2015-09-01 17:35aferrazRelationship addedblocks 0030719
2015-09-01 17:53aferrazRelationship deletedblocks 0030719
2015-09-01 17:54aferrazRelationship addedrelated to 0030719
2015-09-02 10:31aferrazRelationship addedrelated to 0030623
2015-09-02 12:31psanjuanNote Edited: 0080002bug_revision_view_page.php?bugnote_id=0080002#r9311
2015-09-02 12:32psanjuanNote Edited: 0080002bug_revision_view_page.php?bugnote_id=0080002#r9312
2015-09-02 12:33psanjuanNote Edited: 0080002bug_revision_view_page.php?bugnote_id=0080002#r9313
2015-09-02 12:36psanjuanNote Edited: 0080002bug_revision_view_page.php?bugnote_id=0080002#r9314
2015-09-02 19:11aferrazRelationship addedrelated to 0027119
2015-09-02 19:25aferrazRegression introduced in release3.0PR14Q3.8 => 3.0PR15Q2
2015-09-03 10:31maiteSeveritymajor => minor
2015-09-03 12:02aferrazRelationship addedrelated to 0030641
2015-09-03 14:04psanjuanNote Added: 0080050
2015-09-03 15:03psanjuanNote Edited: 0080002bug_revision_view_page.php?bugnote_id=0080002#r9335
2015-09-04 09:41psanjuanNote Edited: 0080002bug_revision_view_page.php?bugnote_id=0080002#r9344
2015-09-04 12:32hgbotCheckin
2015-09-04 12:32hgbotNote Added: 0080096
2015-09-04 12:32hgbotStatusscheduled => resolved
2015-09-04 12:32hgbotResolutionopen => fixed
2015-09-04 12:32hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/1d78ee2328c65c05cde007c6c0ab77b59075cb07 [^]
2015-09-04 12:34dmiguelezReview Assigned To => dmiguelez
2015-09-04 12:34dmiguelezNote Added: 0080104
2015-09-04 12:34dmiguelezStatusresolved => closed
2015-09-07 21:18hudsonbotCheckin
2015-09-07 21:18hudsonbotNote Added: 0080217
2015-09-14 22:17hgbotCheckin
2015-09-14 22:17hgbotNote Added: 0080392
2015-09-14 22:17hgbotStatusclosed => resolved
2015-09-14 22:17hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/1d78ee2328c65c05cde007c6c0ab77b59075cb07 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a5243e3b4df9ab15e8d0851d811b99c5674c2108 [^]
2015-09-15 10:36OrekariaNote Deleted: 0080392
2015-09-15 11:27hgbotCheckin
2015-09-15 11:27hgbotNote Added: 0080396
2015-09-22 09:50aferrazStatusresolved => closed
2015-09-22 09:51aferrazFixed in Version => 3.0PR15Q4
2016-02-02 09:35hgbotCheckin
2016-02-02 09:35hgbotNote Added: 0083813

Notes
(0080002)
aferraz   
2015-09-01 17:32   
(edited on: 2015-09-04 09:41)
Test plan:

As F&B Admin:

- Access Business Partner "Alimentos y Supermercados" and leave Financial Account field empty in Customer tab
- Register new Sales Invoice for this business partner and "Transferencia" payment method, adding any line and process
- Run Add Payment process and realize that Payment Method field is filled with "Transaction" (the document payment method).
- Check that "Cuenta de Banco - EUR" can be selected in the field "Deposit To"
- Change Payment Method to "Al contado"
- Check that "Caja - EUR" can be selected in the field "Deposit To".

- Register new Sales Invoice for this business partner and "Cheque" payment method, adding any line and process
- Run Add Payment process and realize that Payment Method field is filled with "Cheque" (the document payment method).
- Check that "Cuenta de Banco - EUR" can be selected in the field "Deposit To"

- Go to Financial Account "Cuenta de Banco" and set "Cheque" payment method as active = false in Payment Method tab.
- Register new Sales Invoice for this business partner and "Cheque" payment method, adding any line and process
- Run Add Payment process and realize that Payment Method field is filled with "Transferencia" (the business partner default payment method). Realize also you can not select "Cheque" in payment method combo.

- Access Business Partner "Alimentos y Supermercados" and leave Payment Method field empty in Customer tab
- Register new Sales Invoice for this business partner and "Cheque" payment method, adding any line and process
- Run Add Payment process and realize that Payment Method field is not filled. Realize also you can not select "Cheque" in payment method combo. You can only select "Al contado" or "Transferencia" and depending on the one selected "Deposit To" field selection changes as well.

Repeat the same flows setting Financial Account = "Cuenta de Banco" to "Alimentos y Supermercados" Business Partner in Customer tab. The results should be the same. Verified.

Repeat also the same flows opening Add Payment from any other window (Purchase Order, Sales Order, Purchase Invoice, Payment In, Payment Out). Verified.

(0080050)
psanjuan   
2015-09-03 14:04   
Scenario below related to issue 27119 also verified:
-Go to Price List and create a new price list with this data:
 Organization: *
 Name: price list test
 Currency: EUR
 Sales price list: YES
 and add the product "Agua sin Gas 1L"
-Go to Payment Method and create one with this data:
 Organization: *
 Name: payment method test
-Go to Financial Account and create a new header with this data:
 Organization: F&B US, Inc.
 Name: Bank- test
 Currency: EUR
 Type:Bank
 and add the payment method created in previous step "payment method test"
-Go to Business Partner and create a new customer with this data:
 Organization: *
 Name: business partner test
 Financial account: Bank- test
 Payment method: payment method test
 Price list: price list test
-Go to Sales invoice:
 Organization: F&B España - Región Norte
 Business partner: business partner test
 Add a new line and complete the invoive
 Click in add payment, notice that the default value is Bank- test while it should be empty.
(0080096)
hgbot   
2015-09-04 12:32   
Repository: erp/devel/pi
Changeset: 1d78ee2328c65c05cde007c6c0ab77b59075cb07
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed Sep 02 19:55:07 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/1d78ee2328c65c05cde007c6c0ab77b59075cb07 [^]

Fixes issue 30712: Payment Method not filled in Add Payment

Payment Method was not filled when running Add Payment and business partner has no default Financial Account.
When calling from getDefaultPaymentMethod to getFinancialAccountPaymentMethod in AddPaymentDefaultValuesHandler class with a null financialAccountId (in case of opening Add Payment from windows without Financial Account information like Purchase/Sales Order/Invoice and Business Partner does not have a default Financial Account setted), a NPE was raised and Payment Method was not filled in Add Payment.
Now, in Purchase/Sales Order/Invoice windows, where is no financial account information in the context, document payment method will be taken if it is active for any financial account, if not, business partner default payment method will be taken instead (if it is active for any financial account and document organization has access to it).
In those windows, Financial Account selector will show Business Partner default account if selected Payment Method belongs to it, or any Financial Account which Payment Method belongs to instead.
In case of opening Add Payment from Payment In/Out windows, where exists Financial Account information in the context, Payment Method and Financial Account will be taken from the document.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/AddPaymentDefaultValuesHandler.java
---
(0080104)
dmiguelez   
2015-09-04 12:34   
Code Review + Testing Ok
(0080217)
hudsonbot   
2015-09-07 21:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f3ddf66cdf4b [^]
Maturity status: Test
(0080396)
hgbot   
2015-09-15 11:27   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 26b2e403b3d20bc961a513de43eb760cea607ccc
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Tue Sep 15 10:45:33 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/26b2e403b3d20bc961a513de43eb760cea607ccc [^]

Backed out changeset: a5243e3b4df9, issue 30712, wrong issue assignment

---
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
---
(0083813)
hgbot   
2016-02-02 09:35   
Repository: tools/automation/int
Changeset: aa455fcdcc655750100294b9f656a5d7dbe9c165
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Mon Sep 28 19:31:30 2015 +0200
URL: http://code.openbravo.com/tools/automation/int/rev/aa455fcdcc655750100294b9f656a5d7dbe9c165 [^]

Related to issue 30712: Added some automated tests

---
M src-test/com/openbravo/test/integration/erp/data/financial/receivablespayables/transactions/financialaccount/PaymentMethodData.java
M src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_Regressions/RegressionSuite.java
M src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_Regressions/build.xml
A src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_Regressions/APRRegression30712In.java
A src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_Regressions/APRRegression30712Out.java
---