Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0030715
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Openbravo ERP] Z. Othersminoralways2015-09-01 11:142015-09-04 12:34
ReportermaiteView Statuspublic 
Assigned Toaferraz 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision66cf0b6848bf
ProjectionnoneETAnoneTarget Version3.0PR15Q2.5
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Todmiguelez
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Regression levelProduction - Confirmed Stable
Regression date2015-03-16
Regression introduced in release3.0PR14Q3.8
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/41e10f964f97 [^]
Triggers an Emergency PackNo
Summary

0030715: Payment Method not filled when running Add Payment From Invoice and business partner has not default Financial Account

DescriptionPayment Method not filled when running Add Payment From Invoice and business partner has not default Financial Account
Steps To Reproduce1. Access Business Partner "Alimentos y Supermercados" and leave Financial Account field empty in Customer tab
2. Register new Sales Invoice for this business partner, adding any line and process
3. Run Add Payment process and realize that Payment Method field is not filled
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 00307123.0PR15Q4 closedaferraz Payment Method not filled when running Add Payment From Invoice and business partner has not default Financial Account 

-  Notes
(0080099)
hgbot (developer)
2015-09-04 12:32

 Repository: erp/backports/3.0PR15Q2.5
Changeset: 66cf0b6848bf51f79bada76ee643924f060186b4
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed Sep 02 19:55:07 2015 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR15Q2.5/rev/66cf0b6848bf51f79bada76ee643924f060186b4 [^]

Fixes issue 30715: Payment Method not filled in Add Payment

Payment Method was not filled when running Add Payment and business partner has no default Financial Account.
When calling from getDefaultPaymentMethod to getFinancialAccountPaymentMethod in AddPaymentDefaultValuesHandler class with a null financialAccountId (in case of opening Add Payment from windows without Financial Account information like Purchase/Sales Order/Invoice and Business Partner does not have a default Financial Account setted), a NPE was raised and Payment Method was not filled in Add Payment.
Now, in Purchase/Sales Order/Invoice windows, where is no financial account information in the context, document payment method will be taken if it is active for any financial account, if not, business partner default payment method will be taken instead (if it is active for any financial account and document organization has access to it).
In those windows, Financial Account selector will show Business Partner default account if selected Payment Method belongs to it, or any Financial Account which Payment Method belongs to instead.
In case of opening Add Payment from Payment In/Out windows, where exists Financial Account information in the context, Payment Method and Financial Account will be taken from the document.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/AddPaymentDefaultValuesHandler.java
---
(0080103)
dmiguelez (developer)
2015-09-04 12:34

 Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2015-09-01 12:40 aferraz Type defect => backport
2015-09-01 12:40 aferraz Target Version 3.0PR15Q4 => 3.0PR15Q2.5
2015-09-03 10:32 maite Severity major => minor
2015-09-04 12:32 hgbot Checkin
2015-09-04 12:32 hgbot Note Added: 0080099
2015-09-04 12:32 hgbot Status scheduled => resolved
2015-09-04 12:32 hgbot Resolution open => fixed
2015-09-04 12:32 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR15Q2.5/rev/66cf0b6848bf51f79bada76ee643924f060186b4 [^]
2015-09-04 12:34 dmiguelez Review Assigned To => dmiguelez
2015-09-04 12:34 dmiguelez Note Added: 0080103
2015-09-04 12:34 dmiguelez Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker