Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0026267
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Openbravo ERP] A. PlatformmajorN/A2014-04-14 08:392014-05-27 23:09
ReporteralostaleView Statuspublic 
Assigned Toshankarb 
PriorityurgentResolutionfixedFixed in Version3.0PR14Q3
StatusclosedFix in branchFixed in SCM revision402d7bca3f77
ProjectionnoneETAnoneTarget Version3.0PR14Q3
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toalostale
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0026267: Re-implement combos (table and tableDir) to use datasources

DescriptionCurrently, in Openbravo 3 there are two fundamental ways to define a Foreign key column:

* Using a selector (the "Defined selector" reference)
* Using an old-schooled combo (the "table", or "tableDir" reference).

Selectors use OB3 Smartclient components, and are attached to a datasource. Combos also use Smartclient components in OB3, but instead of being attached to a datasource, they are filled with the whole set of data using the OB 2.50 ComboTableData classes.

So combos currently have a main performance disadvantage: Current combos have quite good performance if the dataset they query is small, but scale poorly, and if the dataset is big enough, they have terrible performance, and they can even drag down the application for all users.
Steps To ReproduceSee project page: http://wiki.openbravo.com/wiki/Projects:NewCombos [^]
TagsPerformance
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0023643 closedshankarb List of Dropdowns with more than 1000 fire a warning in the log. 
related to defect 00262023.0PR14Q3 closedAugustoMauch Big combos causing performance problems. 
related to defect 00270053.0PR14Q3 closedshankarb Wrong behaviour when filtering the a formitem that uses the table reference 
related to defect 0027057 closedalostale can't select value in drop down if role has no access to field entity 
related to defect 00270613.0PR14Q3 closedshankarb Sales Representative field is not initialized properly 
related to defect 00287793.0PR15Q2 closedalostale Value of combo is not displayed after setting it with a trigger 
causes defect 0027233 closedalostale Country combo does not show all available options 
causes defect 00276123.0PR14Q4 closedshankarb It is not possible to delete the contents of the Organization field using the keyboard. 
causes defect 00287273.0PR15Q3 closedAugustoMauch Payment Method info should be maintained when using "Modify Payment Plan" functionality 
causes defect 0030060 closedcaristu Select Payments Pick&Edit window is not working properly 
causes defect 0031274 closedcaristu current combo value is not selected when opening drop down list with mouse in form view 

-  Notes
(0067432)
hgbot (developer)
2014-05-26 09:06

 Repository: erp/devel/pi
Changeset: 402d7bca3f774737bf194cb7cbe41d2454a69326
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Mon May 26 12:26:51 2014 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/402d7bca3f774737bf194cb7cbe41d2454a69326 [^]

Fixes issue 26267: Re-implement combos (table and tableDir) to use datasources

Combos refactor project merge with pi

---
M .hgsigs
M .hgtags
M lib/README
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MODULE.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/Reconciliation.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_ExecutePayment.java
M modules/org.openbravo.base.weld/src-db/database/sourcedata/AD_MODULE.xml
M modules/org.openbravo.base.weld/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MODULE.xml
M modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-fk-filter.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
M modules/org.openbravo.client.htmlwidget/src-db/database/sourcedata/AD_MODULE.xml
M modules/org.openbravo.client.htmlwidget/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M modules/org.openbravo.client.kernel/src-db/database/sourcedata/AD_MODULE.xml
M modules/org.openbravo.client.kernel/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M modules/org.openbravo.client.myob/src-db/database/sourcedata/AD_MODULE.xml
M modules/org.openbravo.client.myob/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M modules/org.openbravo.client.myob/web/org.openbravo.client.myob/js/ob-myopenbravo.js
M modules/org.openbravo.client.querylist/src-db/database/sourcedata/AD_MODULE.xml
M modules/org.openbravo.client.querylist/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M modules/org.openbravo.client.widgets/src-db/database/sourcedata/AD_MODULE.xml
M modules/org.openbravo.client.widgets/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M modules/org.openbravo.financial.paymentreport/src-db/database/sourcedata/AD_MODULE.xml
M modules/org.openbravo.financial.paymentreport/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M modules/org.openbravo.reports.ordersawaitingdelivery/src-db/database/sourcedata/AD_MODULE.xml
M modules/org.openbravo.reports.ordersawaitingdelivery/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_MODULE.xml
M modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M modules/org.openbravo.service.integration.google/src-db/database/sourcedata/AD_MODULE.xml
M modules/org.openbravo.service.integration.google/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M modules/org.openbravo.service.integration.openid/src-db/database/sourcedata/AD_MODULE.xml
M modules/org.openbravo.service.integration.openid/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M modules/org.openbravo.service.json/src-db/database/sourcedata/AD_MODULE.xml
M modules/org.openbravo.service.json/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M modules/org.openbravo.service.json/src/org/openbravo/service/json/AdvancedQueryBuilder.java
M modules/org.openbravo.userinterface.selector/src-db/database/sourcedata/AD_MODULE.xml
M modules/org.openbravo.userinterface.selector/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M modules/org.openbravo.userinterface.skin.250to300Comp/src-db/database/sourcedata/AD_MODULE.xml
M modules/org.openbravo.userinterface.skin.250to300Comp/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M modules/org.openbravo.userinterface.smartclient/src-db/database/sourcedata/AD_MODULE.xml
M modules/org.openbravo.userinterface.smartclient/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M modules/org.openbravo.v3.datasets/src-db/database/sourcedata/AD_MODULE.xml
M modules/org.openbravo.v3.datasets/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M modules/org.openbravo.v3.framework/src-db/database/sourcedata/AD_MODULE.xml
M modules/org.openbravo.v3.framework/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M modules/org.openbravo.v3/src-db/database/sourcedata/AD_MODULE.xml
M modules/org.openbravo.v3/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M src-db/database/sourcedata/AD_MODULE.xml
M src/org/openbravo/erpCommon/ad_reports/GeneralAccountingReports.java
M src/org/openbravo/erpCommon/ad_reports/GeneralAccountingReportsPDF.jrxml
---
(0067434)
alostale (manager)
2014-05-26 09:08

 Code reviewed

QA executed as described in http://wiki.openbravo.com/wiki/Projects:NewCombos/QA-Test_Plan [^]
(0067495)
hudsonbot (developer)
2014-05-27 23:09

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/15bdf44a37ae [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2014-04-14 08:39 alostale New Issue
2014-04-14 08:39 alostale Assigned To => shankarb
2014-04-14 08:39 alostale Modules => Core
2014-04-14 08:39 alostale Triggers an Emergency Pack => No
2014-04-14 08:39 alostale Tag Attached: Performance
2014-04-14 08:40 alostale Description Updated View Revisions
2014-04-14 08:40 alostale Steps to Reproduce Updated View Revisions
2014-04-24 09:10 alostale Relationship added related to 0026202
2014-05-09 10:25 alostale Relationship added related to 0023643
2014-05-26 09:06 hgbot Checkin
2014-05-26 09:06 hgbot Note Added: 0067432
2014-05-26 09:06 hgbot Status new => resolved
2014-05-26 09:06 hgbot Resolution open => fixed
2014-05-26 09:06 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/402d7bca3f774737bf194cb7cbe41d2454a69326 [^]
2014-05-26 09:08 alostale Review Assigned To => alostale
2014-05-26 09:08 alostale Note Added: 0067434
2014-05-26 09:08 alostale Status resolved => closed
2014-05-26 09:08 alostale Fixed in Version => PR14Q3
2014-05-27 23:09 hudsonbot Checkin
2014-05-27 23:09 hudsonbot Note Added: 0067495
2014-07-03 10:54 AugustoMauch Relationship added related to 0027005
2014-07-14 08:57 alostale Relationship added related to 0027057
2014-07-14 11:37 AugustoMauch Relationship added related to 0027061
2014-07-30 14:05 alostale Relationship added causes 0027233
2014-09-16 10:03 alostale Relationship added causes 0027612
2015-01-29 09:06 alostale Relationship added related to 0028779
2015-03-16 17:15 AugustoMauch Relationship added causes 0028727
2015-06-10 09:28 dmitry_mezentsev Relationship added causes 0030060
2015-10-29 10:36 alostale Relationship added causes 0031274

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker