Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0026267Openbravo ERPA. Platformpublic2014-04-14 08:392014-05-27 23:09
alostale 
shankarb 
urgentmajorN/A
closedfixed 
5
 
3.0PR14Q33.0PR14Q3 
alostale
Core
No
0026267: Re-implement combos (table and tableDir) to use datasources
Currently, in Openbravo 3 there are two fundamental ways to define a Foreign key column:

* Using a selector (the "Defined selector" reference)
* Using an old-schooled combo (the "table", or "tableDir" reference).

Selectors use OB3 Smartclient components, and are attached to a datasource. Combos also use Smartclient components in OB3, but instead of being attached to a datasource, they are filled with the whole set of data using the OB 2.50 ComboTableData classes.

So combos currently have a main performance disadvantage: Current combos have quite good performance if the dataset they query is small, but scale poorly, and if the dataset is big enough, they have terrible performance, and they can even drag down the application for all users.
See project page: http://wiki.openbravo.com/wiki/Projects:NewCombos [^]
Performance
related to defect 0023643 closed shankarb List of Dropdowns with more than 1000 fire a warning in the log. 
related to defect 00262023.0PR14Q3 closed AugustoMauch Big combos causing performance problems. 
related to defect 00270053.0PR14Q3 closed shankarb Wrong behaviour when filtering the a formitem that uses the table reference 
related to defect 0027057 closed alostale can't select value in drop down if role has no access to field entity 
related to defect 00270613.0PR14Q3 closed shankarb Sales Representative field is not initialized properly 
related to defect 00287793.0PR15Q2 closed alostale Value of combo is not displayed after setting it with a trigger 
causes defect 0027233 closed alostale Country combo does not show all available options 
causes defect 00276123.0PR14Q4 closed shankarb It is not possible to delete the contents of the Organization field using the keyboard. 
causes defect 00287273.0PR15Q3 closed AugustoMauch Payment Method info should be maintained when using "Modify Payment Plan" functionality 
causes defect 0030060 closed caristu Select Payments Pick&Edit window is not working properly 
causes defect 0031274 closed caristu current combo value is not selected when opening drop down list with mouse in form view 
Issue History
2014-04-14 08:39alostaleNew Issue
2014-04-14 08:39alostaleAssigned To => shankarb
2014-04-14 08:39alostaleModules => Core
2014-04-14 08:39alostaleTriggers an Emergency Pack => No
2014-04-14 08:39alostaleTag Attached: Performance
2014-04-14 08:40alostaleDescription Updatedbug_revision_view_page.php?rev_id=5697#r5697
2014-04-14 08:40alostaleSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=5699#r5699
2014-04-24 09:10alostaleRelationship addedrelated to 0026202
2014-05-09 10:25alostaleRelationship addedrelated to 0023643
2014-05-26 09:06hgbotCheckin
2014-05-26 09:06hgbotNote Added: 0067432
2014-05-26 09:06hgbotStatusnew => resolved
2014-05-26 09:06hgbotResolutionopen => fixed
2014-05-26 09:06hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/402d7bca3f774737bf194cb7cbe41d2454a69326 [^]
2014-05-26 09:08alostaleReview Assigned To => alostale
2014-05-26 09:08alostaleNote Added: 0067434
2014-05-26 09:08alostaleStatusresolved => closed
2014-05-26 09:08alostaleFixed in Version => PR14Q3
2014-05-27 23:09hudsonbotCheckin
2014-05-27 23:09hudsonbotNote Added: 0067495
2014-07-03 10:54AugustoMauchRelationship addedrelated to 0027005
2014-07-14 08:57alostaleRelationship addedrelated to 0027057
2014-07-14 11:37AugustoMauchRelationship addedrelated to 0027061
2014-07-30 14:05alostaleRelationship addedcauses 0027233
2014-09-16 10:03alostaleRelationship addedcauses 0027612
2015-01-29 09:06alostaleRelationship addedrelated to 0028779
2015-03-16 17:15AugustoMauchRelationship addedcauses 0028727
2015-06-10 09:28dmitry_mezentsevRelationship addedcauses 0030060
2015-10-29 10:36alostaleRelationship addedcauses 0031274

Notes
(0067432)
hgbot   
2014-05-26 09:06   
Repository: erp/devel/pi
Changeset: 402d7bca3f774737bf194cb7cbe41d2454a69326
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Mon May 26 12:26:51 2014 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/402d7bca3f774737bf194cb7cbe41d2454a69326 [^]

Fixes issue 26267: Re-implement combos (table and tableDir) to use datasources

Combos refactor project merge with pi

---
M .hgsigs
M .hgtags
M lib/README
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MODULE.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/Reconciliation.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_ExecutePayment.java
M modules/org.openbravo.base.weld/src-db/database/sourcedata/AD_MODULE.xml
M modules/org.openbravo.base.weld/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MODULE.xml
M modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-fk-filter.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
M modules/org.openbravo.client.htmlwidget/src-db/database/sourcedata/AD_MODULE.xml
M modules/org.openbravo.client.htmlwidget/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M modules/org.openbravo.client.kernel/src-db/database/sourcedata/AD_MODULE.xml
M modules/org.openbravo.client.kernel/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M modules/org.openbravo.client.myob/src-db/database/sourcedata/AD_MODULE.xml
M modules/org.openbravo.client.myob/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M modules/org.openbravo.client.myob/web/org.openbravo.client.myob/js/ob-myopenbravo.js
M modules/org.openbravo.client.querylist/src-db/database/sourcedata/AD_MODULE.xml
M modules/org.openbravo.client.querylist/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M modules/org.openbravo.client.widgets/src-db/database/sourcedata/AD_MODULE.xml
M modules/org.openbravo.client.widgets/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M modules/org.openbravo.financial.paymentreport/src-db/database/sourcedata/AD_MODULE.xml
M modules/org.openbravo.financial.paymentreport/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M modules/org.openbravo.reports.ordersawaitingdelivery/src-db/database/sourcedata/AD_MODULE.xml
M modules/org.openbravo.reports.ordersawaitingdelivery/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_MODULE.xml
M modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M modules/org.openbravo.service.integration.google/src-db/database/sourcedata/AD_MODULE.xml
M modules/org.openbravo.service.integration.google/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M modules/org.openbravo.service.integration.openid/src-db/database/sourcedata/AD_MODULE.xml
M modules/org.openbravo.service.integration.openid/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M modules/org.openbravo.service.json/src-db/database/sourcedata/AD_MODULE.xml
M modules/org.openbravo.service.json/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M modules/org.openbravo.service.json/src/org/openbravo/service/json/AdvancedQueryBuilder.java
M modules/org.openbravo.userinterface.selector/src-db/database/sourcedata/AD_MODULE.xml
M modules/org.openbravo.userinterface.selector/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M modules/org.openbravo.userinterface.skin.250to300Comp/src-db/database/sourcedata/AD_MODULE.xml
M modules/org.openbravo.userinterface.skin.250to300Comp/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M modules/org.openbravo.userinterface.smartclient/src-db/database/sourcedata/AD_MODULE.xml
M modules/org.openbravo.userinterface.smartclient/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M modules/org.openbravo.v3.datasets/src-db/database/sourcedata/AD_MODULE.xml
M modules/org.openbravo.v3.datasets/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M modules/org.openbravo.v3.framework/src-db/database/sourcedata/AD_MODULE.xml
M modules/org.openbravo.v3.framework/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M modules/org.openbravo.v3/src-db/database/sourcedata/AD_MODULE.xml
M modules/org.openbravo.v3/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M src-db/database/sourcedata/AD_MODULE.xml
M src/org/openbravo/erpCommon/ad_reports/GeneralAccountingReports.java
M src/org/openbravo/erpCommon/ad_reports/GeneralAccountingReportsPDF.jrxml
---
(0067434)
alostale   
2014-05-26 09:08   
Code reviewed

QA executed as described in http://wiki.openbravo.com/wiki/Projects:NewCombos/QA-Test_Plan [^]
(0067495)
hudsonbot   
2014-05-27 23:09   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/15bdf44a37ae [^]
Maturity status: Test