Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0028727
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] Z. Othersminoralways2015-01-22 10:582015-03-18 00:03
ReportermaiteView Statuspublic 
Assigned ToAugustoMauch 
PriorityimmediateResolutionfixedFixed in Version3.0PR15Q2
StatusclosedFix in branchFixed in SCM revision8e0a9e1ef5c3
ProjectionnoneETAnoneTarget Version3.0PR15Q3
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toalostale
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Regression levelProduction - Confirmed Stable
Regression date2014-05-26
Regression introduced in release3.0PR14Q3
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/402d7bca3f774737bf194cb7cbe41d2454a69326 [^]
Triggers an Emergency PackNo
Summary

0028727: Payment Method info should be maintained when using "Modify Payment Plan" functionality

DescriptionPayment Method info should be maintained when using "Modify Payment Plan" functionality
Steps To Reproduce1. Access as System Administrator and display "Modify Payment Plan" button in Payment Plan tab of Sales Invoice window
2. Logout and login
3. Create new Sales Invoice document. Add line and process
4. Access Payment Plan tab and run "Modify Payment Plan" process. Click on Due Date field of existent register to modify the date and realize that Payment Method information has been deleted
Proposed SolutionPayment Method value should be maintained as other values are also maintained
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 00292933.0PR15Q1.2 closedAugustoMauch Payment Method info should be maintained when using "Modify Payment Plan" functionality 
depends on backport 00292943.0PR14Q3.8 closedAugustoMauch Payment Method info should be maintained when using "Modify Payment Plan" functionality 
caused by feature request 00262673.0PR14Q3 closedshankarb Re-implement combos (table and tableDir) to use datasources 
causes defect 0029374 closedAugustoMauch Warehouse column is showing a wrong value in Manage Stock popup 
causes defect 0029940 closedalostale Selector Reference field changes to Id in editable P&E when adding new rows 

-  Notes
(0075639)
hgbot (developer)
2015-03-16 17:07

 Repository: erp/devel/pi
Changeset: b625c136e3dec64b8656315f9ce22124ccd21a8d
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Mar 16 16:42:25 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/b625c136e3dec64b8656315f9ce22124ccd21a8d [^]

Related with issue 28727: Checks if the okButton exists to prevent error in log

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js
---
(0075641)
hgbot (developer)
2015-03-16 17:07

 Repository: erp/devel/pi
Changeset: a882ebfc5ae62239e25474f67de797735bf960db
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Mar 16 16:57:41 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/a882ebfc5ae62239e25474f67de797735bf960db [^]

Fixes issue 28727: valueMap is properly initialized in pick and execute windows

The problem was that when a line in a pick and execute grid was edited, the valueMap of its OBFKComboItems was not properly initialized. The initialization is done in the OBPickAndExecuteGrid.processColumnValue function.

Before the Openbravo combos was refactored, the columnValue parameter used to contain the full valueMap of the combo in its entries attribute. This atribute was passed to the OBPickAndExecuteGrid.setValueMap, and the valueMap of the combos was initialized. The problem was that since the combos was refactored the columnValue parameter no longer contained the entries attribute, because the FIC now only returns the selected value. To fix this, in this case the valueMap is built manually based on the column value and identifier. This valueMap is passed to the OBPickAndExecuteGrid.setValueMap function to initialize the field valueMap.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js
---
(0075647)
hgbot (developer)
2015-03-16 18:03

 Repository: erp/devel/pi
Changeset: efa53163ee0c77c84baaf2a3360f42d662dfa329
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Mar 16 18:01:47 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/efa53163ee0c77c84baaf2a3360f42d662dfa329 [^]

Fixes issue 28727: Use proper attribute names in the valueMap of the combo

The ListGrid.setValueMap function expected a valueMap that is an array, where each position contains an object with two properties: id and _identifier (OB.Constants.ID and OB.Constants.IDENTIFIER constants). The identifier property was not being properly named, so the valueMap did not contain the proper values.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js
---
(0075653)
hgbot (developer)
2015-03-16 18:44

 Repository: erp/devel/pi
Changeset: 8e0a9e1ef5c35acc8ae8efff6b43dfb424392947
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Mar 16 18:35:40 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/8e0a9e1ef5c35acc8ae8efff6b43dfb424392947 [^]

Fixes issue 28727: Set properly the value of fk combo items in P&E windows

The problem was that when the value was being set to fk combo items before its valueMap was defined. To fix this, the value of the combo is reset just after defining its combo.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js
---
(0075661)
AugustoMauch (administrator)
2015-03-16 19:32

 Test created in testlink: http://testlink.openbravo.com/testlink/linkto.php?tprojectPrefix=Communit&item=testcase&id=Communit-8148 [^]

This issue will not be automated, as it cannot be reproduced in a standard Openbravo
(0075672)
alostale (manager)
2015-03-17 08:35

 code reviewed

tested:
-When editing the record in the P&E value in payment method field is kept
-This value can be edited and it is correctly processed
(0075706)
hudsonbot (developer)
2015-03-18 00:03

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2e3cf56c8f15 [^]
Maturity status: Test
(0075707)
hudsonbot (developer)
2015-03-18 00:03

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2e3cf56c8f15 [^]
Maturity status: Test
(0075708)
hudsonbot (developer)
2015-03-18 00:03

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2e3cf56c8f15 [^]
Maturity status: Test
(0075711)
hudsonbot (developer)
2015-03-18 00:03

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2e3cf56c8f15 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2015-01-22 10:58 maite New Issue
2015-01-22 10:58 maite Assigned To => dmiguelez
2015-01-22 10:58 maite Modules => Advanced Payables and Receivables Mngmt
2015-01-22 10:58 maite Resolution time => 1428357600
2015-01-22 10:58 maite Triggers an Emergency Pack => No
2015-01-22 10:58 maite Issue Monitored: networkb
2015-01-22 10:58 maite Assigned To dmiguelez => Sandrahuguet
2015-02-23 13:30 jonalegriaesarte Target Version 3.0PR15Q2 => 3.0PR15Q3
2015-03-09 11:21 maite Priority high => immediate
2015-03-09 11:22 maite Steps to Reproduce Updated View Revisions
2015-03-09 17:29 jonalegriaesarte Resolution time 1428357600 =>
2015-03-09 17:30 jonalegriaesarte Regression date => 2015-03-10
2015-03-09 17:30 jonalegriaesarte Severity minor => major
2015-03-09 17:31 jonalegriaesarte Severity major => minor
2015-03-16 11:25 aferraz Assigned To Sandrahuguet => AugustoMauch
2015-03-16 16:41 AugustoMauch Status new => scheduled
2015-03-16 17:04 AugustoMauch Regression level => Production - Confirmed Stable
2015-03-16 17:04 AugustoMauch Regression date 2015-03-10 => 2014-05-26
2015-03-16 17:04 AugustoMauch Regression introduced in release => 3.0PR14Q3
2015-03-16 17:04 AugustoMauch Regression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/402d7bca3f774737bf194cb7cbe41d2454a69326 [^]
2015-03-16 17:06 AugustoMauch Issue Monitored: alostale
2015-03-16 17:06 AugustoMauch Review Assigned To => alostale
2015-03-16 17:07 hgbot Checkin
2015-03-16 17:07 hgbot Note Added: 0075639
2015-03-16 17:07 hgbot Checkin
2015-03-16 17:07 hgbot Note Added: 0075641
2015-03-16 17:07 hgbot Status scheduled => resolved
2015-03-16 17:07 hgbot Resolution open => fixed
2015-03-16 17:07 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a882ebfc5ae62239e25474f67de797735bf960db [^]
2015-03-16 17:15 AugustoMauch Relationship added caused by 0026267
2015-03-16 18:03 hgbot Checkin
2015-03-16 18:03 hgbot Note Added: 0075647
2015-03-16 18:03 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/a882ebfc5ae62239e25474f67de797735bf960db [^] => http://code.openbravo.com/erp/devel/pi/rev/efa53163ee0c77c84baaf2a3360f42d662dfa329 [^]
2015-03-16 18:44 hgbot Checkin
2015-03-16 18:44 hgbot Note Added: 0075653
2015-03-16 18:44 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/efa53163ee0c77c84baaf2a3360f42d662dfa329 [^] => http://code.openbravo.com/erp/devel/pi/rev/8e0a9e1ef5c35acc8ae8efff6b43dfb424392947 [^]
2015-03-16 19:32 AugustoMauch Note Added: 0075661
2015-03-17 08:35 alostale Note Added: 0075672
2015-03-17 08:35 alostale Status resolved => closed
2015-03-17 08:35 alostale Fixed in Version => 3.0PR15Q2
2015-03-18 00:03 hudsonbot Checkin
2015-03-18 00:03 hudsonbot Note Added: 0075706
2015-03-18 00:03 hudsonbot Checkin
2015-03-18 00:03 hudsonbot Note Added: 0075707
2015-03-18 00:03 hudsonbot Checkin
2015-03-18 00:03 hudsonbot Note Added: 0075708
2015-03-18 00:03 hudsonbot Checkin
2015-03-18 00:03 hudsonbot Note Added: 0075711
2015-03-23 16:57 AugustoMauch Relationship added causes 0029374
2015-05-21 15:15 alostale Relationship added causes 0029940

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker