Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0009177
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 08. Project and service managementminoralways2009-05-26 08:492012-05-25 12:13
ReportersureshbabuView Statuspublic 
Assigned ToSandrahuguet 
PrioritynormalResolutionfixedFixed in Version3.0MP12
StatusclosedFix in branchFixed in SCM revision650d3a0a5225
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionmainSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0009177: List price for a product wrongly dispalys as Zero in Sales order which is created through create sales order from expenses

DescriptionList price for a product(type: Expense), wrongly shows as Zero in Sales order which is created through create sales order from expenses process

Used a product(type: expense, with unit, standard & list price as 2) in expense sheet to create invoiceable expenses. Then created a sales order for the invoiceable expenses through 'create sales order from expenses' process. Then i opened the Sales order in edit mode and checked the line item details, where i found the list price of the product is wrongly mentioned as Zero.




Steps To Reproduce1) Move to Project & Service Management || Transactions || Expense Sheet || Header and click new, enter the required fields
2) move to line items & click new.
Check the reinvoicing check box,
select any product in the product combo box,
Quantity: 10
Invoice price : 2
Project: Any project

move back to header tab and click process expenses.

3)Move to Project & Service Management || Transactions || Create Sales Orders from Expenses || Create Sales Orders from Expenses

Select any date in Date ordered field and click process.

Process completed message appears with SO id and Shipment id.

4) Open the above created Sales order(Sales Management || Transactions || Sales Order || Header >> Lines ) in edit mode and check the line item details.

I found that list price is wrongly assigned to Zero(instead of 2)
Proposed SolutionOrder lines (as well as invoice lines) have 4 different prices:
* Price actual
* Price std
* Price list
* Price limit

When using Create Sales Orders from Expenses:
* If no price has been set in the expense sheet line, those 4 prices are taken from the Price List of the business partner (set in the expense sheet line).
* If a price is set in the expense sheet line (inside invoice price field), all 4 prices are equal to the price set there.

In ad_actionButton/ExpenseSOrder.java, change:
priceactual = data[i].invoiceprice;
pricelist = "0";
pricelimit = "0";

by

priceactual = data[i].invoiceprice;
pricelist = priceactual;
pricelimit = priceactual;
TagsOB3-Reviewed, VMA-Reviewed
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 0009259 closedsathiyan List price for a product wrongly dispalys as Zero in Sales order which is created through create sales order from expenses 

-  Notes
(0048397)
Sandrahuguet (developer)
2012-05-07 09:31

 Test Plan:
-Go to product, select electricity.
 ·Product type: Expense type
-Go to Expense Sheet and create one, navigate to lines
 ·Check the reinvoicing check box,
 ·Product: electricity
 ·Quantity: 10
 ·Net unit price: 2
-Move back to header tab and click process expenses, process completed message appears with SO id and Shipment id.
-Go to sales order an select de order create, navigate to lines.
 ·Select electricity, notice that net list price is not zero
(0048895)
hgbot (developer)
2012-05-23 18:12

 Repository: erp/devel/pi
Changeset: 650d3a0a5225e6280b09317fb012a6a2f50756c9
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Mon May 07 09:15:35 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/650d3a0a5225e6280b09317fb012a6a2f50756c9 [^]

Fixed bug 9177 Change price list in sales order
Change price list in sales order when create a sales order
using create sales order from Expenses

---
M src/org/openbravo/erpCommon/ad_actionButton/ExpenseSOrder.java
---
(0048897)
mirurita (developer)
2012-05-23 18:22

 code review + testing OK

If the "Net Unit Price" field on Expense Sheet line is filled, use this value for net unit price of the sales order. Take the price list and price limit from the valid price list version for the business partner and product.
(0049193)
hudsonbot (developer)
2012-05-25 12:13

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5401e185a8b0 [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2009-05-26 08:49 sureshbabu New Issue
2009-05-26 08:49 sureshbabu Assigned To => rafaroda
2009-05-26 08:56 sureshbabu version => main
2009-05-26 11:29 rafaroda Status new => scheduled
2009-05-26 11:29 rafaroda Steps to Reproduce Updated
2009-06-01 12:10 rafaroda Assigned To rafaroda => sathiyan
2009-06-01 12:10 rafaroda Status scheduled => acknowledged
2009-06-01 12:10 rafaroda Proposed Solution updated
2009-06-01 12:10 rafaroda Status acknowledged => scheduled
2009-06-01 12:10 rafaroda fix_in_branch => pi
2011-10-31 10:55 psarobe Assigned To sathiyan => jonalegriaesarte
2011-10-31 10:55 psarobe fix_in_branch pi =>
2011-11-07 14:48 RenateNieuwkoop Issue Monitored: RenateNieuwkoop
2011-11-24 15:09 jonalegriaesarte Tag Attached: OB3-Reviewed
2012-02-15 19:03 iciordia Assigned To jonalegriaesarte => vmromanos
2012-02-16 18:11 vmromanos Tag Attached: VMA-Reviewed
2012-05-04 13:43 Sandrahuguet Assigned To vmromanos => Sandrahuguet
2012-05-07 09:31 Sandrahuguet Note Added: 0048397
2012-05-23 18:12 hgbot Checkin
2012-05-23 18:12 hgbot Note Added: 0048895
2012-05-23 18:12 hgbot Status scheduled => resolved
2012-05-23 18:12 hgbot Resolution open => fixed
2012-05-23 18:12 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/650d3a0a5225e6280b09317fb012a6a2f50756c9 [^]
2012-05-23 18:22 mirurita Note Added: 0048897
2012-05-23 18:22 mirurita Status resolved => closed
2012-05-23 18:22 mirurita Fixed in Version => 3.0MP12
2012-05-25 12:13 hudsonbot Checkin
2012-05-25 12:13 hudsonbot Note Added: 0049193

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker