0009177: List price for a product wrongly dispalys as Zero in Sales order which is created through create sales order from expenses

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0009177

Openbravo ERP

08. Project and service management

public

2009-05-26 08:49

2012-05-25 12:13

Reporter

sureshbabu

Assigned To

Sandrahuguet

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

main

Target Version

Fixed in Version

3.0MP12

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0009177: List price for a product wrongly dispalys as Zero in Sales order which is created through create sales order from expenses

Description

List price for a product(type: Expense), wrongly shows as Zero in Sales order which is created through create sales order from expenses process

Used a product(type: expense, with unit, standard & list price as 2) in expense sheet to create invoiceable expenses. Then created a sales order for the invoiceable expenses through 'create sales order from expenses' process. Then i opened the Sales order in edit mode and checked the line item details, where i found the list price of the product is wrongly mentioned as Zero.

Steps To Reproduce

1) Move to Project & Service Management || Transactions || Expense Sheet || Header and click new, enter the required fields
2) move to line items & click new.
Check the reinvoicing check box,
select any product in the product combo box,
Quantity: 10
Invoice price : 2
Project: Any project

move back to header tab and click process expenses.

3)Move to Project & Service Management || Transactions || Create Sales Orders from Expenses || Create Sales Orders from Expenses

Select any date in Date ordered field and click process.

Process completed message appears with SO id and Shipment id.

4) Open the above created Sales order(Sales Management || Transactions || Sales Order || Header >> Lines ) in edit mode and check the line item details.

I found that list price is wrongly assigned to Zero(instead of 2)

Proposed Solution

Order lines (as well as invoice lines) have 4 different prices:
* Price actual
* Price std
* Price list
* Price limit

When using Create Sales Orders from Expenses:
* If no price has been set in the expense sheet line, those 4 prices are taken from the Price List of the business partner (set in the expense sheet line).
* If a price is set in the expense sheet line (inside invoice price field), all 4 prices are equal to the price set there.

In ad_actionButton/ExpenseSOrder.java, change:
priceactual = data[i].invoiceprice;
pricelist = "0";
pricelimit = "0";

by

priceactual = data[i].invoiceprice;
pricelist = priceactual;
pricelimit = priceactual;

Additional Information