0009259: List price for a product wrongly dispalys as Zero in Sales order which is created through create sales order from expenses

Description

List price for a product(type: Expense), wrongly shows as Zero in Sales order which is created through create sales order from expenses process

Used a product(type: expense, with unit, standard & list price as 2) in expense sheet to create invoiceable expenses. Then created a sales order for the invoiceable expenses through 'create sales order from expenses' process. Then i opened the Sales order in edit mode and checked the line item details, where i found the list price of the product is wrongly mentioned as Zero.

Steps To Reproduce

1) Move to Project & Service Management || Transactions || Expense Sheet || Header and click new, enter the required fields
2) move to line items & click new.
Check the reinvoicing check box,
select any product in the product combo box,
Quantity: 10
Invoice price : 2
Project: Any project

move back to header tab and click process expenses.

3)Move to Project & Service Management || Transactions || Create Sales Orders from Expenses || Create Sales Orders from Expenses

Select any date in Date ordered field and click process.

Process completed message appears with SO id and Shipment id.

4) Open the above created Sales order(Sales Management || Transactions || Sales Order || Header >> Lines ) in edit mode and check the line item details.

I found that list price is wrongly assigned to Zero(instead of 2)

Proposed Solution

Order lines (as well as invoice lines) have 4 different prices:
* Price actual
* Price std
* Price list
* Price limit

When using Create Sales Orders from Expenses:
* If no price has been set in the expense sheet line, those 4 prices are taken from the Price List of the business partner (set in the expense sheet line).
* If a price is set in the expense sheet line (inside invoice price field), all 4 prices are equal to the price set there.

In ad_actionButton/ExpenseSOrder.java, change:
priceactual = data[i].invoiceprice;
pricelist = "0";
pricelimit = "0";

by

priceactual = data[i].invoiceprice;
pricelist = priceactual;
pricelimit = priceactual;

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0009177

closed

Sandrahuguet

List price for a product wrongly dispalys as Zero in Sales order which is created through create sales order from expenses

Notes
(0043170) jonalegriaesarte (reporter) 2011-11-24 15:07	Openbravo provides community support only for the latest Openbravo version, which is Openbravo 3. This version has significantly improved financial flow, filtering, performance, etc and this issue is not present there. Upgrade path from Openbravo 2.50 to latest Openbravo version is available so we recommend to upgrade your instance to get this issue fixed. Life cycle guarantee (backporting bug fixes to the previos to latest releases (Openbravo 2.40, 2.50)) is available for Professional Edition subscribers only. Please register your ticket through Openbravo Support Portal (http://support.openbravo.com/ [^]) if you have valid Professional subscription. You can find more details about our Support policy in the following blog post http://paolojuvara.blogspot.com/2009/12/maintenance-policy-for-openbravo-250.html [^]

Issue History
Date Modified	Username	Field	Change
2009-06-01 12:10	rafaroda	Type	defect => backport
2009-06-01 12:10	rafaroda	fix_in_branch	=> 2.40
2011-11-24 15:07	jonalegriaesarte	Note Added: 0043170
2011-11-24 15:07	jonalegriaesarte	Status	scheduled => closed
2011-11-24 15:07	jonalegriaesarte	Resolution	open => no change required