Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0005797
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Openbravo ERP] F. Localizationmajoralways2008-11-03 11:302009-03-03 17:16
ReporterrcordovinView Statuspublic 
Assigned Tovmromanos 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branch2.40Fixed in SCM revision10626
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0005797: CreateFile creates several lines for each remittance line

DescriptionThe file created has than one line for each remittance line if a Business Partner has more than one active Bank Account.
Steps To Reproduce1. Create a Business Partner with more than one actives Bank Accounts
2. Create a Debt Payment for the BP just created.
3. Create a Remittance with the Debt Payment just created.
4. Process and Create File.

The file created has as many lines as Bank Accounts the Business Partner has.
Proposed SolutionWe check in the code if any of the remittance lines has a Business Partner with more than one active Bank Accounts. If so, we throw a message that inform the user that this has to be fixed manually.

The code is:

---- (CreateFile_data.xsql)

  <SqlMethod name="selectComprobacion5" type="preparedStatement" return="multiple" audit="false">
    <SqlMethodComment></SqlMethodComment>
    <Sql>
    <![CDATA[
        select c_bpartner.name as name
        from c_remittanceline
        inner join c_debt_payment on (c_debt_payment.c_debt_payment_id= c_remittanceline.c_debt_payment_id)
        inner join c_bp_bankaccount on (c_bp_bankaccount.c_bpartner_id= c_debt_payment.c_bpartner_id and c_bp_bankaccount.isactive='Y')
        inner join c_bpartner on (c_bp_bankaccount.c_bpartner_id= c_bpartner.c_bpartner_id)
        where c_remittanceline.C_Remittance_ID = ?
        group by c_debt_payment.c_bpartner_id,c_bpartner.name, c_remittanceline.c_debt_payment_id
        having count(*)>1
    ]]>
    </Sql>
    <Parameter name="cRemittanceId"/>
    </SqlMethod>

---- (CreateFile.java)

  CreateFileData[]comprobacion5=CreateFileData.selectComprobacion5(this,vars,strKey);
for (int i=0;i<comprobacion5.length;i++){ strMessage=strMessage+"\\n"+Utility.messageBD(this,"CodeBankBPErrorMultiple",vars.getLanguage())+comprobacion5[i].name;
}
if (!strMessage.equals("")){
      printPage(response, vars, strKey, "", "", strMessage);
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
has duplicate backport 0005884 closeddalsasua Spanish bank rule 34: Does not manage business partner bank accounts properly 
blocks defect 0005697 closedvmromanos CreateFile creates several lines for each remittance line 

-  Notes
(0010558)
rafaroda (developer)
2008-11-24 12:36

 Solution proposed: if one of the Business Partners has more than one bank account active, display a message saying for which Business Partner this happens and proposing to deactivate all his bank accounts but the one that one wants to be used.
(0010563)
rcordovin (reporter)
2008-11-24 13:42

 I agree is a good temporary solution (is the one we have adopted) but I think in following releases it should be improved with a check box in the bankaccount tab where the user could choose the bankaccount to be included in these files.
(0010605)
svnbot (reporter)
2008-11-25 10:50

 Repository: openbravo
Revision: 10516
Author: vmromanos
Date: 2008-11-25 10:50:46 +0100 (Tue, 25 Nov 2008)

Fixed bug 0005797: CreateFile creates several lines for each remittance line

---
U branches/r2.40/src/org/openbravo/erpCommon/ad_actionButton/CreateFile.java
U branches/r2.40/src/org/openbravo/erpCommon/ad_actionButton/CreateFile_data.xsql
U branches/r2.40/src-db/database/sourcedata/AD_MESSAGE.xml
---

https://dev.openbravo.com/websvn/openbravo/?rev=10516&sc=1 [^]
(0010727)
svnbot (reporter)
2008-11-26 17:21

 Repository: openbravo
Revision: 10626
Author: villind
Date: 2008-11-26 17:21:28 +0100 (Wed, 26 Nov 2008)

Merged r10516. Fixed bug 0005797: CreateFile creates several lines for each remittance line

---
_U branches/bonware/r2.40/
_U branches/bonware/r2.40/config/setup-tool/
_U branches/bonware/r2.40/eclipse.install.source.launch
_U branches/bonware/r2.40/export.database.launch
U branches/bonware/r2.40/src/org/openbravo/erpCommon/ad_actionButton/CreateFile.java
U branches/bonware/r2.40/src/org/openbravo/erpCommon/ad_actionButton/CreateFile_data.xsql
_U branches/bonware/r2.40/src-core/src/org/openbravo/database/OpenbravoDriverManagerConnectionFactory.java
U branches/bonware/r2.40/src-db/database/sourcedata/AD_MESSAGE.xml
_U branches/bonware/r2.40/update.database.launch
---

https://dev.openbravo.com/websvn/openbravo/?rev=10626&sc=1 [^]

- Issue History
Date Modified Username Field Change
2008-11-03 11:30 rafaroda New Issue
2008-11-03 11:30 rafaroda Assigned To => vmromanos
2008-11-03 11:30 rafaroda Status new => scheduled
2008-11-21 08:55 vmromanos Status scheduled => feedback
2008-11-24 12:36 rafaroda Status feedback => scheduled
2008-11-24 12:36 rafaroda Note Added: 0010558
2008-11-24 12:36 rafaroda fix_in_branch 2.40 => trunk
2008-11-24 12:36 rafaroda fix_in_branch trunk => 2.40
2008-11-24 12:36 rafaroda Steps to Reproduce Updated
2008-11-24 13:42 rcordovin Note Added: 0010563
2008-11-25 10:50 svnbot Checkin
2008-11-25 10:50 svnbot Note Added: 0010605
2008-11-25 10:50 svnbot Status scheduled => resolved
2008-11-25 10:50 svnbot Resolution open => fixed
2008-11-25 10:50 svnbot svn_revision => 10516
2008-11-26 17:21 svnbot Checkin
2008-11-26 17:21 svnbot Note Added: 0010727
2008-11-26 17:21 svnbot svn_revision 10516 => 10626
2008-12-15 15:29 dalsasua Relationship added has duplicate 0005884
2009-03-03 17:16 psarobe Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker