Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0005797Openbravo ERPF. Localizationpublic2008-11-03 11:302009-03-03 17:16
Reporterrcordovin 
Assigned Tovmromanos 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0005797: CreateFile creates several lines for each remittance line
DescriptionThe file created has than one line for each remittance line if a Business Partner has more than one active Bank Account.
Steps To Reproduce1. Create a Business Partner with more than one actives Bank Accounts
2. Create a Debt Payment for the BP just created.
3. Create a Remittance with the Debt Payment just created.
4. Process and Create File.

The file created has as many lines as Bank Accounts the Business Partner has.
Proposed SolutionWe check in the code if any of the remittance lines has a Business Partner with more than one active Bank Accounts. If so, we throw a message that inform the user that this has to be fixed manually.

The code is:

---- (CreateFile_data.xsql)

  <SqlMethod name="selectComprobacion5" type="preparedStatement" return="multiple" audit="false">
    <SqlMethodComment></SqlMethodComment>
    <Sql>
    <![CDATA[
        select c_bpartner.name as name
        from c_remittanceline
        inner join c_debt_payment on (c_debt_payment.c_debt_payment_id= c_remittanceline.c_debt_payment_id)
        inner join c_bp_bankaccount on (c_bp_bankaccount.c_bpartner_id= c_debt_payment.c_bpartner_id and c_bp_bankaccount.isactive='Y')
        inner join c_bpartner on (c_bp_bankaccount.c_bpartner_id= c_bpartner.c_bpartner_id)
        where c_remittanceline.C_Remittance_ID = ?
        group by c_debt_payment.c_bpartner_id,c_bpartner.name, c_remittanceline.c_debt_payment_id
        having count(*)>1
    ]]>
    </Sql>
    <Parameter name="cRemittanceId"/>
    </SqlMethod>

---- (CreateFile.java)

  CreateFileData[]comprobacion5=CreateFileData.selectComprobacion5(this,vars,strKey);
for (int i=0;i<comprobacion5.length;i++){ strMessage=strMessage+"\\n"+Utility.messageBD(this,"CodeBankBPErrorMultiple",vars.getLanguage())+comprobacion5[i].name;
}
if (!strMessage.equals("")){
      printPage(response, vars, strKey, "", "", strMessage);
Additional Information
TagsNo tags attached.
Relationships
has duplicate backport 0005884 closed dalsasua Spanish bank rule 34: Does not manage business partner bank accounts properly 
blocks defect 0005697 closed vmromanos CreateFile creates several lines for each remittance line 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2008-11-03 11:30rafarodaNew Issue
2008-11-03 11:30rafarodaAssigned To => vmromanos
2008-11-03 11:30rafarodaStatusnew => scheduled
2008-11-21 08:55vmromanosStatusscheduled => feedback
2008-11-24 12:36rafarodaStatusfeedback => scheduled
2008-11-24 12:36rafarodaNote Added: 0010558
2008-11-24 12:36rafarodafix_in_branch2.40 => trunk
2008-11-24 12:36rafarodafix_in_branchtrunk => 2.40
2008-11-24 12:36rafarodaSteps to Reproduce Updated
2008-11-24 13:42rcordovinNote Added: 0010563
2008-11-25 10:50svnbotCheckin
2008-11-25 10:50svnbotNote Added: 0010605
2008-11-25 10:50svnbotStatusscheduled => resolved
2008-11-25 10:50svnbotResolutionopen => fixed
2008-11-25 10:50svnbotsvn_revision => 10516
2008-11-26 17:21svnbotCheckin
2008-11-26 17:21svnbotNote Added: 0010727
2008-11-26 17:21svnbotsvn_revision10516 => 10626
2008-12-15 15:29dalsasuaRelationship addedhas duplicate 0005884
2009-03-03 17:16psarobeStatusresolved => closed

Notes
(0010558)
rafaroda   
2008-11-24 12:36   
Solution proposed: if one of the Business Partners has more than one bank account active, display a message saying for which Business Partner this happens and proposing to deactivate all his bank accounts but the one that one wants to be used.
(0010563)
rcordovin   
2008-11-24 13:42   
I agree is a good temporary solution (is the one we have adopted) but I think in following releases it should be improved with a check box in the bankaccount tab where the user could choose the bankaccount to be included in these files.
(0010605)
svnbot   
2008-11-25 10:50   
Repository: openbravo
Revision: 10516
Author: vmromanos
Date: 2008-11-25 10:50:46 +0100 (Tue, 25 Nov 2008)

Fixed bug 0005797: CreateFile creates several lines for each remittance line

---
U branches/r2.40/src/org/openbravo/erpCommon/ad_actionButton/CreateFile.java
U branches/r2.40/src/org/openbravo/erpCommon/ad_actionButton/CreateFile_data.xsql
U branches/r2.40/src-db/database/sourcedata/AD_MESSAGE.xml
---

https://dev.openbravo.com/websvn/openbravo/?rev=10516&sc=1 [^]
(0010727)
svnbot   
2008-11-26 17:21   
Repository: openbravo
Revision: 10626
Author: villind
Date: 2008-11-26 17:21:28 +0100 (Wed, 26 Nov 2008)

Merged r10516. Fixed bug 0005797: CreateFile creates several lines for each remittance line

---
_U branches/bonware/r2.40/
_U branches/bonware/r2.40/config/setup-tool/
_U branches/bonware/r2.40/eclipse.install.source.launch
_U branches/bonware/r2.40/export.database.launch
U branches/bonware/r2.40/src/org/openbravo/erpCommon/ad_actionButton/CreateFile.java
U branches/bonware/r2.40/src/org/openbravo/erpCommon/ad_actionButton/CreateFile_data.xsql
_U branches/bonware/r2.40/src-core/src/org/openbravo/database/OpenbravoDriverManagerConnectionFactory.java
U branches/bonware/r2.40/src-db/database/sourcedata/AD_MESSAGE.xml
_U branches/bonware/r2.40/update.database.launch
---

https://dev.openbravo.com/websvn/openbravo/?rev=10626&sc=1 [^]