Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0005697

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Openbravo ERP] F. Localization

major

always

2008-10-28 15:26

2008-12-13 18:34

Reporter

rcordovin

View Status

public

Assigned To

vmromanos

Priority

normal

Resolution

fixed

Fixed in Version

Status

closed

Fix in branch

pi

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

pi

SCM revision

Review Assigned To

Web browser

Modules

Core

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0005697: CreateFile creates several lines for each remittance line

Description

The file created has than one line for each remittance line if a Business Partner has more than one active Bank Account.

Steps To Reproduce

1. Create a Business Partner with more than one actives Bank Accounts
2. Create a Debt Payment for the BP just created.
3. Create a Remittance with the Debt Payment just created.
4. Process and Create File.

The file created has as many lines as Bank Accounts the Business Partner has.

Proposed Solution

We check in the code if any of the remittance lines has a Business Partner with more than one active Bank Accounts. If so, we throw a message that inform the user that this has to be fixed manually.

The code is:

---- (CreateFile_data.xsql)

  <SqlMethod name="selectComprobacion5" type="preparedStatement" return="multiple" audit="false">
    <SqlMethodComment></SqlMethodComment>
    <Sql>
    <![CDATA[
        select c_bpartner.name as name
        from c_remittanceline
        inner join c_debt_payment on (c_debt_payment.c_debt_payment_id= c_remittanceline.c_debt_payment_id)
        inner join c_bp_bankaccount on (c_bp_bankaccount.c_bpartner_id= c_debt_payment.c_bpartner_id and c_bp_bankaccount.isactive='Y')
        inner join c_bpartner on (c_bp_bankaccount.c_bpartner_id= c_bpartner.c_bpartner_id)
        where c_remittanceline.C_Remittance_ID = ?
        group by c_debt_payment.c_bpartner_id,c_bpartner.name, c_remittanceline.c_debt_payment_id
        having count(*)>1
    ]]>
    </Sql>
    <Parameter name="cRemittanceId"/>
    </SqlMethod>

---- (CreateFile.java)

  CreateFileData[]comprobacion5=CreateFileData.selectComprobacion5(this,vars,strKey);
for (int i=0;i<comprobacion5.length;i++){ strMessage=strMessage+"\\n"+Utility.messageBD(this,"CodeBankBPErrorMultiple",vars.getLanguage())+comprobacion5[i].name;
}
if (!strMessage.equals("")){
      printPage(response, vars, strKey, "", "", strMessage);

Tags

No tags attached.

Relationships [ Relation Graph ] [ Dependency Graph ]

depends on	backport	0005797		closed	vmromanos	CreateFile creates several lines for each remittance line
has duplicate	defect	0005880		closed	dalsasua	Spanish bank rule 34: Does not manage business partner bank accounts properly

Notes
(0010494) vmromanos (manager) 2008-11-21 08:55	I have followed the steps to reproduce the bug but I am unable to do it. I've created two remittances in tecnicia14 (types Consolidated and Non-Consolidated) and both files have only one line with one of the two configured bank accounts for the Business Partner. Please, could you give more details in order to reproduce the bug?

(0010557) rafaroda (developer) 2008-11-24 12:35	Solution proposed: if one of the Business Partners has more than one bank account active, display a message saying for which Business Partner this happens and proposing to deactivate all his bank accounts but the one that one wants to be used.

(0010587) svnbot (reporter) 2008-11-24 20:08	Repository: openbravo Revision: 10497 Author: vmromanos Date: 2008-11-24 20:08:25 +0100 (Mon, 24 Nov 2008) Fixed bug 0005697: CreateFile creates several lines for each remittance line --- U trunk/src/org/openbravo/erpCommon/ad_actionButton/CreateFile.java U trunk/src/org/openbravo/erpCommon/ad_actionButton/CreateFile_data.xsql U trunk/src-db/database/sourcedata/AD_MESSAGE.xml --- https://dev.openbravo.com/websvn/openbravo/?rev=10497&sc=1 [^]

Issue History
Date Modified	Username	Field	Change
2008-10-28 15:26	rcordovin	New Issue
2008-10-28 15:26	rcordovin	Assigned To	=> cromero
2008-10-28 15:26	rcordovin	sf_bug_id	0 => 2204266
2008-11-03 11:30	rafaroda	Status	new => scheduled
2008-11-03 11:30	rafaroda	Assigned To	cromero => vmromanos
2008-11-03 11:30	rafaroda	fix_in_branch	=> trunk
2008-11-21 08:55	vmromanos	Note Added: 0010494
2008-11-21 08:55	vmromanos	Status	scheduled => feedback
2008-11-24 12:35	rafaroda	Note Added: 0010557
2008-11-24 12:35	rafaroda	Status	feedback => scheduled
2008-11-24 20:08	svnbot	Checkin
2008-11-24 20:08	svnbot	Note Added: 0010587
2008-11-24 20:08	svnbot	Status	scheduled => resolved
2008-11-24 20:08	svnbot	Resolution	open => fixed
2008-11-24 20:08	svnbot	svn_revision	=> 10497
2008-12-13 18:34	psarobe	Regression testing	=> No
2008-12-13 18:34	psarobe	Status	resolved => closed
2008-12-15 15:25	dalsasua	Relationship added	has duplicate 0005880

Copyright © 2000 - 2009 MantisBT Group