0005697: CreateFile creates several lines for each remittance line

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0005697

Openbravo ERP

F. Localization

public

2008-10-28 15:26

2008-12-13 18:34

Reporter

rcordovin

Assigned To

vmromanos

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0005697: CreateFile creates several lines for each remittance line

Description

The file created has than one line for each remittance line if a Business Partner has more than one active Bank Account.

Steps To Reproduce

1. Create a Business Partner with more than one actives Bank Accounts
2. Create a Debt Payment for the BP just created.
3. Create a Remittance with the Debt Payment just created.
4. Process and Create File.

The file created has as many lines as Bank Accounts the Business Partner has.

Proposed Solution

We check in the code if any of the remittance lines has a Business Partner with more than one active Bank Accounts. If so, we throw a message that inform the user that this has to be fixed manually.

The code is:

---- (CreateFile_data.xsql)

  <SqlMethod name="selectComprobacion5" type="preparedStatement" return="multiple" audit="false">
    <SqlMethodComment></SqlMethodComment>
    <Sql>
    <![CDATA[
        select c_bpartner.name as name
        from c_remittanceline
        inner join c_debt_payment on (c_debt_payment.c_debt_payment_id= c_remittanceline.c_debt_payment_id)
        inner join c_bp_bankaccount on (c_bp_bankaccount.c_bpartner_id= c_debt_payment.c_bpartner_id and c_bp_bankaccount.isactive='Y')
        inner join c_bpartner on (c_bp_bankaccount.c_bpartner_id= c_bpartner.c_bpartner_id)
        where c_remittanceline.C_Remittance_ID = ?
        group by c_debt_payment.c_bpartner_id,c_bpartner.name, c_remittanceline.c_debt_payment_id
        having count(*)>1
    ]]>
    </Sql>
    <Parameter name="cRemittanceId"/>
    </SqlMethod>

---- (CreateFile.java)

  CreateFileData[]comprobacion5=CreateFileData.selectComprobacion5(this,vars,strKey);
for (int i=0;i<comprobacion5.length;i++){ strMessage=strMessage+"\\n"+Utility.messageBD(this,"CodeBankBPErrorMultiple",vars.getLanguage())+comprobacion5[i].name;
}
if (!strMessage.equals("")){
      printPage(response, vars, strKey, "", "", strMessage);

Additional Information

Tags

No tags attached.

Relationships

depends on	backport	0005797		closed	vmromanos	CreateFile creates several lines for each remittance line
has duplicate	defect	0005880		closed	dalsasua	Spanish bank rule 34: Does not manage business partner bank accounts properly