Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0057278
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[POS2] POSmajorhave not tried2024-09-05 17:072024-11-26 11:38
ReporterhbrasmeView Statuspublic 
Assigned Toradhakrishnan 
PrioritynormalResolutionfixedFixed in Version24Q3.3
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version24Q3.3
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product Version24Q3SCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0057278: Contribution Module - No contribution recalculation after a line split or deletion

DescriptionWhen a product with contribution is splitted, the contribution line is not recalculate
Steps To ReproduceUse a contribution (Product subtype) defined like as follow :

Checkbox Linkable To Product selected
Checkbox Forced in returns selected
Price Calculation > By Product multiplicator
Quantity Rule > As per product
Allocation Type > mandatory

---------
This contribution is assigned to a product

----

Select product with quantity of 3

When the line is splitted the contribution line is not recalculate


----

When 2 of the previous lines are deleted, the contribution is not recalculated for the only line present.

The result shlould be a contribution (Gestion APE) with an 6.02 € like amount







Proposed Solution1. Include property 'preventSplit' at line level for the main product line when adding a contribution to the ticket
2. Modify the conditional to check for contributions similar to how ticket.hasServices is used in https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3065/diffs?file=02be15b3fb317b5ce80c75e279ae19fd221914ca#02be15b3fb317b5ce80c75e279ae19fd221914ca_41_49 [^]

I think solution 1 is the better option.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to backport 005727724Q4.1 closedradhakrishnan Contribution Module - No contribution recalculation after a line split or deletion 
blocks defect 0056386 closedradhakrishnan Contribution Module - No contribution recalculation after a line split or deletion 

-  Notes
(0172594)
hgbot (developer)
2024-11-26 11:12

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3157 [^]
(0172598)
hgbot (developer)
2024-11-26 11:38

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 27c21360427685a9d141921e8b5c372c3374aaea
Author: Radhakrishnan Seeman <r.seeman@external.orisha.com>
Date: 26-11-2024 10:38:12
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/27c21360427685a9d141921e8b5c372c3374aaea [^]

Fixed ISSUE-57278: Blocked split action of a line

---
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/ContributionHooks.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/ContributionHooks.js
---
(0172599)
hgbot (developer)
2024-11-26 11:38

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3157 [^]

- Issue History
Date Modified Username Field Change
2024-11-26 10:44 jonae Type defect => backport
2024-11-26 10:44 jonae Target Version => 24Q3.3
2024-11-26 11:12 hgbot Note Added: 0172594
2024-11-26 11:38 hgbot Resolution open => fixed
2024-11-26 11:38 hgbot Status scheduled => closed
2024-11-26 11:38 hgbot Fixed in Version => 24Q3.3
2024-11-26 11:38 hgbot Note Added: 0172598
2024-11-26 11:38 hgbot Note Added: 0172599
2024-11-26 11:39 frank_gonzalez Relationship added related to 0057277


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker