Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0057278POS2POSpublic2024-09-05 17:072024-11-26 11:38
Reporterhbrasme 
Assigned Toradhakrishnan 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version24Q3 
Target Version24Q3.3Fixed in Version24Q3.3 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0057278: Contribution Module - No contribution recalculation after a line split or deletion
DescriptionWhen a product with contribution is splitted, the contribution line is not recalculate
Steps To ReproduceUse a contribution (Product subtype) defined like as follow :

Checkbox Linkable To Product selected
Checkbox Forced in returns selected
Price Calculation > By Product multiplicator
Quantity Rule > As per product
Allocation Type > mandatory

---------
This contribution is assigned to a product

----

Select product with quantity of 3

When the line is splitted the contribution line is not recalculate


----

When 2 of the previous lines are deleted, the contribution is not recalculated for the only line present.

The result shlould be a contribution (Gestion APE) with an 6.02 € like amount







Proposed Solution1. Include property 'preventSplit' at line level for the main product line when adding a contribution to the ticket
2. Modify the conditional to check for contributions similar to how ticket.hasServices is used in https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3065/diffs?file=02be15b3fb317b5ce80c75e279ae19fd221914ca#02be15b3fb317b5ce80c75e279ae19fd221914ca_41_49 [^]

I think solution 1 is the better option.
Additional Information
TagsNo tags attached.
Relationships
related to backport 005727724Q4.1 closed radhakrishnan Contribution Module - No contribution recalculation after a line split or deletion 
blocks defect 0056386 closed radhakrishnan Contribution Module - No contribution recalculation after a line split or deletion 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2024-11-26 10:44jonaeTypedefect => backport
2024-11-26 10:44jonaeTarget Version => 24Q3.3
2024-11-26 11:12hgbotNote Added: 0172594
2024-11-26 11:38hgbotResolutionopen => fixed
2024-11-26 11:38hgbotStatusscheduled => closed
2024-11-26 11:38hgbotFixed in Version => 24Q3.3
2024-11-26 11:38hgbotNote Added: 0172598
2024-11-26 11:38hgbotNote Added: 0172599
2024-11-26 11:39frank_gonzalezRelationship addedrelated to 0057277

Notes
(0172594)
hgbot   
2024-11-26 11:12   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3157 [^]
(0172598)
hgbot   
2024-11-26 11:38   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 27c21360427685a9d141921e8b5c372c3374aaea
Author: Radhakrishnan Seeman <r.seeman@external.orisha.com>
Date: 26-11-2024 10:38:12
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/27c21360427685a9d141921e8b5c372c3374aaea [^]

Fixed ISSUE-57278: Blocked split action of a line

---
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/ContributionHooks.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/ContributionHooks.js
---
(0172599)
hgbot   
2024-11-26 11:38   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3157 [^]