Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0054547
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[POS2] Coreminorhave not tried2024-02-01 07:152024-02-16 09:13
ReportercaristuView Statuspublic 
Assigned ToTriage Platform Base 
PriorityurgentResolutionfixedFixed in Version24Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version24Q1
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date2023-11-13
Regression introduced in release
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/72fca1cdb2100a3d1c55f8cc2e4b7e9b9f652b55 [^]
Triggers an Emergency PackNo
Summary

0054547: Wrong icon is displayed for return reasons

DescriptionWrong icon is displayed for return reasons, see current vs expected attached images.
Steps To Reproduce1) Login in the POS
2) Create a new ticket adding a new line
3) Return the line, note that next to the return reason input, the expected icon is not displayed
Proposed SolutionSee the attached patch. This allows to set the configured icon as it was done before. But note that this solution may be limited now because it does not allow to configure the icon at input level, i.e., the same icon is applied to all the inputs of the same user action.

Together with this, there are different user actions using a wrong property to configure the icon. See for example here[1]. content.InputIconClass must be replaced with content.iconClass

[1] https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/blob/master/web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/ReturnLine.js#L36 [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 0054536 closedTriage Platform Base Wrong icon is displayed for return reasons 

-  Notes
(0160755)
hgbot (developer)
2024-02-14 17:55

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1371 [^]
(0160756)
hgbot (developer)
2024-02-14 18:00

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2427 [^]
(0160827)
hgbot (developer)
2024-02-16 09:13

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2427 [^]
(0160828)
hgbot (developer)
2024-02-16 09:13

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1371 [^]
(0160829)
hgbot (developer)
2024-02-16 09:13

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 0bef673c7e1bedb7d07422d135bb5ee781f163df
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 16-02-2024 08:13:03
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/0bef673c7e1bedb7d07422d135bb5ee781f163df [^]

fixes BUG-54547: fix ability to define the input icon

---
M web-jspack/org.openbravo.core2/src/components/ComboBox/ComboBox.jsx
M web-jspack/org.openbravo.core2/src/components/InputAndApprovalDialog/__test__/InputAndApprovalDialog.test.jsx
M web-jspack/org.openbravo.core2/src/core/security/requestInputAndApproval.js
---

- Issue History
Date Modified Username Field Change
2024-02-01 16:17 caristu Type defect => backport
2024-02-01 16:17 caristu Target Version => 24Q1
2024-02-14 17:55 hgbot Note Added: 0160755
2024-02-14 18:00 hgbot Note Added: 0160756
2024-02-16 09:13 hgbot Note Added: 0160827
2024-02-16 09:13 hgbot Note Added: 0160828
2024-02-16 09:13 hgbot Resolution open => fixed
2024-02-16 09:13 hgbot Status scheduled => closed
2024-02-16 09:13 hgbot Fixed in Version => 24Q1
2024-02-16 09:13 hgbot Note Added: 0160829

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker