Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0054536
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] Coreminorhave not tried2024-02-01 07:152024-02-16 09:13
ReportercaristuView Statuspublic 
Assigned ToTriage Platform Base 
PriorityurgentResolutionfixedFixed in Version24Q2
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date2023-11-13
Regression introduced in release
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/72fca1cdb2100a3d1c55f8cc2e4b7e9b9f652b55 [^]
Triggers an Emergency PackNo
Summary

0054536: Wrong icon is displayed for return reasons

DescriptionWrong icon is displayed for return reasons, see current vs expected attached images.
Steps To Reproduce1) Login in the POS
2) Create a new ticket adding a new line
3) Return the line, note that next to the return reason input, the expected icon is not displayed
Proposed SolutionSee the attached patch. This allows to set the configured icon as it was done before. But note that this solution may be limited now because it does not allow to configure the icon at input level, i.e., the same icon is applied to all the inputs of the same user action.

Together with this, there are different user actions using a wrong property to configure the icon. See for example here[1]. content.InputIconClass must be replaced with content.iconClass

[1] https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/blob/master/web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/ReturnLine.js#L36 [^]
TagsNo tags attached.
Attached Filespng file icon current.png [^] (8,406 bytes) 2024-02-01 07:15


png file icon expected.png [^] (8,690 bytes) 2024-02-01 07:15


diff file icon iconClass.diff [^] (1,169 bytes) 2024-02-01 07:22 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
depends on backport 005454724Q1 closedTriage Platform Base Wrong icon is displayed for return reasons 
caused by feature request 0053821 closedTriage Platform Base Rename reasons infrastructure API to not use reasons but inputs in the names 

-  Notes
(0160752)
hgbot (developer)
2024-02-14 17:48

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1370 [^]
(0160754)
hgbot (developer)
2024-02-14 17:51

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2426 [^]
(0160826)
hgbot (developer)
2024-02-16 09:13

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 0cacd9d67478f77d512434398515c9af29dbeee8
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 16-02-2024 08:13:06
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/0cacd9d67478f77d512434398515c9af29dbeee8 [^]

related to BUG-54536: use the correct property to set the icon

 Some user actions were using a wrong property to set the icon of their
inputs

---
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/ReturnLine.js
---
(0160830)
hgbot (developer)
2024-02-16 09:13

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 0be4a02c7e57f9f7046fbf9a17b71a2bec6ea50f
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 16-02-2024 08:13:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/0be4a02c7e57f9f7046fbf9a17b71a2bec6ea50f [^]

related to BUG-54536: use the correct property to set the icon

 Some user actions were using a wrong property to set the icon of their
inputs

---
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/ReturnBlindTicket.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/ReturnLine.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/ReturnVerifiedTicket.js
---
(0160831)
hgbot (developer)
2024-02-16 09:13

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2426 [^]
(0160832)
hgbot (developer)
2024-02-16 09:13

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1370 [^]
(0160833)
hgbot (developer)
2024-02-16 09:13

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: b50ec990e4415e6b4a690c49722771c661400f5a
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 16-02-2024 08:13:23
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/b50ec990e4415e6b4a690c49722771c661400f5a [^]

fixes BUG-54536: fix ability to define the input icon

---
M web-jspack/org.openbravo.core2/src/components/ComboBox/ComboBox.jsx
M web-jspack/org.openbravo.core2/src/components/InputAndApprovalDialog/__test__/InputAndApprovalDialog.test.jsx
M web-jspack/org.openbravo.core2/src/core/security/requestInputAndApproval.js
---

- Issue History
Date Modified Username Field Change
2024-02-01 07:15 caristu New Issue
2024-02-01 07:15 caristu Assigned To => Triage Platform Base
2024-02-01 07:15 caristu File Added: current.png
2024-02-01 07:15 caristu Triggers an Emergency Pack => No
2024-02-01 07:15 caristu File Added: expected.png
2024-02-01 07:21 caristu Proposed Solution updated
2024-02-01 07:22 caristu Proposed Solution updated
2024-02-01 07:22 caristu File Added: iconClass.diff
2024-02-01 07:25 caristu Regression date => 2023-11-13
2024-02-01 07:25 caristu Regression introduced by commit => https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/72fca1cdb2100a3d1c55f8cc2e4b7e9b9f652b55 [^]
2024-02-01 07:26 caristu Relationship added caused by 0053821
2024-02-01 07:27 caristu Proposed Solution updated
2024-02-01 16:17 caristu Status new => acknowledged
2024-02-01 16:17 caristu Status acknowledged => scheduled
2024-02-14 17:48 hgbot Note Added: 0160752
2024-02-14 17:51 hgbot Note Added: 0160754
2024-02-16 09:13 hgbot Note Added: 0160826
2024-02-16 09:13 hgbot Note Added: 0160830
2024-02-16 09:13 hgbot Note Added: 0160831
2024-02-16 09:13 hgbot Resolution open => fixed
2024-02-16 09:13 hgbot Status scheduled => closed
2024-02-16 09:13 hgbot Note Added: 0160832
2024-02-16 09:13 hgbot Fixed in Version => 24Q2
2024-02-16 09:13 hgbot Note Added: 0160833


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker