Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0054536POS2Corepublic2024-02-01 07:152024-02-16 09:13
Reportercaristu 
Assigned ToTriage Platform Base 
PriorityurgentSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version24Q2 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date2023-11-13
Regression introduced in release
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/72fca1cdb2100a3d1c55f8cc2e4b7e9b9f652b55 [^]
Triggers an Emergency PackNo
Summary0054536: Wrong icon is displayed for return reasons
DescriptionWrong icon is displayed for return reasons, see current vs expected attached images.
Steps To Reproduce1) Login in the POS
2) Create a new ticket adding a new line
3) Return the line, note that next to the return reason input, the expected icon is not displayed
Proposed SolutionSee the attached patch. This allows to set the configured icon as it was done before. But note that this solution may be limited now because it does not allow to configure the icon at input level, i.e., the same icon is applied to all the inputs of the same user action.

Together with this, there are different user actions using a wrong property to configure the icon. See for example here[1]. content.InputIconClass must be replaced with content.iconClass

[1] https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/blob/master/web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/ReturnLine.js#L36 [^]
Additional Information
TagsNo tags attached.
Relationships
depends on backport 005454724Q1 closed Triage Platform Base Wrong icon is displayed for return reasons 
caused by feature request 0053821 closed Triage Platform Base Rename reasons infrastructure API to not use reasons but inputs in the names 
Attached Filespng current.png (8,406) 2024-02-01 07:15
https://issues.openbravo.com/file_download.php?file_id=19424&type=bug
png

png expected.png (8,690) 2024-02-01 07:15
https://issues.openbravo.com/file_download.php?file_id=19425&type=bug
png

diff iconClass.diff (1,169) 2024-02-01 07:22
https://issues.openbravo.com/file_download.php?file_id=19426&type=bug
Issue History
Date ModifiedUsernameFieldChange
2024-02-01 07:15caristuNew Issue
2024-02-01 07:15caristuAssigned To => Triage Platform Base
2024-02-01 07:15caristuFile Added: current.png
2024-02-01 07:15caristuTriggers an Emergency Pack => No
2024-02-01 07:15caristuFile Added: expected.png
2024-02-01 07:21caristuProposed Solution updated
2024-02-01 07:22caristuProposed Solution updated
2024-02-01 07:22caristuFile Added: iconClass.diff
2024-02-01 07:25caristuRegression date => 2023-11-13
2024-02-01 07:25caristuRegression introduced by commit => https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/72fca1cdb2100a3d1c55f8cc2e4b7e9b9f652b55 [^]
2024-02-01 07:26caristuRelationship addedcaused by 0053821
2024-02-01 07:27caristuProposed Solution updated
2024-02-01 16:17caristuStatusnew => acknowledged
2024-02-01 16:17caristuStatusacknowledged => scheduled
2024-02-14 17:48hgbotNote Added: 0160752
2024-02-14 17:51hgbotNote Added: 0160754
2024-02-16 09:13hgbotNote Added: 0160826
2024-02-16 09:13hgbotNote Added: 0160830
2024-02-16 09:13hgbotNote Added: 0160831
2024-02-16 09:13hgbotResolutionopen => fixed
2024-02-16 09:13hgbotStatusscheduled => closed
2024-02-16 09:13hgbotNote Added: 0160832
2024-02-16 09:13hgbotFixed in Version => 24Q2
2024-02-16 09:13hgbotNote Added: 0160833

Notes
(0160752)
hgbot   
2024-02-14 17:48   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1370 [^]
(0160754)
hgbot   
2024-02-14 17:51   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2426 [^]
(0160826)
hgbot   
2024-02-16 09:13   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 0cacd9d67478f77d512434398515c9af29dbeee8
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 16-02-2024 08:13:06
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/0cacd9d67478f77d512434398515c9af29dbeee8 [^]

related to BUG-54536: use the correct property to set the icon

 Some user actions were using a wrong property to set the icon of their
inputs

---
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/ReturnLine.js
---
(0160830)
hgbot   
2024-02-16 09:13   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 0be4a02c7e57f9f7046fbf9a17b71a2bec6ea50f
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 16-02-2024 08:13:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/0be4a02c7e57f9f7046fbf9a17b71a2bec6ea50f [^]

related to BUG-54536: use the correct property to set the icon

 Some user actions were using a wrong property to set the icon of their
inputs

---
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/ReturnBlindTicket.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/ReturnLine.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/ReturnVerifiedTicket.js
---
(0160831)
hgbot   
2024-02-16 09:13   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2426 [^]
(0160832)
hgbot   
2024-02-16 09:13   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1370 [^]
(0160833)
hgbot   
2024-02-16 09:13   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: b50ec990e4415e6b4a690c49722771c661400f5a
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 16-02-2024 08:13:23
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/b50ec990e4415e6b4a690c49722771c661400f5a [^]

fixes BUG-54536: fix ability to define the input icon

---
M web-jspack/org.openbravo.core2/src/components/ComboBox/ComboBox.jsx
M web-jspack/org.openbravo.core2/src/components/InputAndApprovalDialog/__test__/InputAndApprovalDialog.test.jsx
M web-jspack/org.openbravo.core2/src/core/security/requestInputAndApproval.js
---