0054547: Wrong icon is displayed for return reasons

Openbravo Issue Tracking System - POS2

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0054547

POS2

Core

public

2024-02-01 07:15

2024-02-16 09:13

Reporter

caristu

Assigned To

Triage Platform Base

Priority

urgent

Severity

minor

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

24Q1

Fixed in Version

24Q1

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

2023-11-13

Regression introduced in release

Regression introduced by commit

https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/72fca1cdb2100a3d1c55f8cc2e4b7e9b9f652b55 [^]

Triggers an Emergency Pack

Summary

0054547: Wrong icon is displayed for return reasons

Description

Wrong icon is displayed for return reasons, see current vs expected attached images.

Steps To Reproduce

1) Login in the POS
2) Create a new ticket adding a new line
3) Return the line, note that next to the return reason input, the expected icon is not displayed

Proposed Solution

See the attached patch. This allows to set the configured icon as it was done before. But note that this solution may be limited now because it does not allow to configure the icon at input level, i.e., the same icon is applied to all the inputs of the same user action.

Together with this, there are different user actions using a wrong property to configure the icon. See for example here[1]. content.InputIconClass must be replaced with content.iconClass

[1] https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/blob/master/web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/ReturnLine.js#L36 [^]

Additional Information