Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0052489 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [POS2] Restaurants | critical | always | 2023-05-10 15:55 | 2023-05-23 19:15 | |||
| Reporter | nicola_uva | View Status | public | |||||
| Assigned To | javierRodriguez | |||||||
| Priority | immediate | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | 23Q1.3 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0052489: Menu [Tax calculation] - Not possible to finalize a ticket paid partially nor do reverse payment | |||||||
| Description | Tax calculation error on Menu.Is not possible to finalize a ticket paid partially nor do reverse payment | |||||||
| Steps To Reproduce | 1) Login https://livebuilds.openbravo.com/retail_pos2_modules_pgsql/web/pos/?terminal=VBS-2 [^] 2) select schema "Restaurant" 3) add to the ticketthe menu "Simple menu" 4) finalize the payment 5)open the ticket paid in (5) 6) click on review payments -> then a) try to reverse payment b) try to pay pending amount by cash 7) Dialog is showed saying tax not found(see image attached) -> ERROR | |||||||
| Proposed Solution | In: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/blob/master/web/org.openbravo.retail.posterminal/app/model/business-object/ticket/TicketUtils.js#L616 [^] Change followinf line: ticketTaxRules = this.ticket.receiptTaxes.map(receiptTax => taxRules.find(taxRule => taxRule.id === receiptTax.taxid)); To something like this: ticketTaxRules = taxRules.filter(rule -> condition1 OR condition2) Where: condition1: rule id matches ticket receiptTaxes taxid (current condition) condition2: rule is bom and rule.taxCategory matches with the tax category of any ticket line | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0149983) hgbot (developer) 2023-05-19 13:37 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1203 [^] |
|
(0150162) hgbot (developer) 2023-05-23 19:15 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: 793498476f814d09b92424eba0e0beb0729a4d04 Author: Javier RodrÃguez Regueiro <javier.rodriguez@openbravo.com> Date: 23-05-2023 17:15:56 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/793498476f814d09b92424eba0e0beb0729a4d04 [^] Fixed ISSUE-52489: [23Q1] Improve condition to add taxes in booked tickets --- M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/TicketUtils.js --- |
|
(0150163) hgbot (developer) 2023-05-23 19:15 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1203 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2023-05-19 08:42 | guilleaer | Type | defect => backport |
| 2023-05-19 08:42 | guilleaer | Target Version | pi => 23Q1.3 |
| 2023-05-19 13:37 | hgbot | Note Added: 0149983 | |
| 2023-05-23 19:15 | hgbot | Resolution | open => fixed |
| 2023-05-23 19:15 | hgbot | Status | scheduled => closed |
| 2023-05-23 19:15 | hgbot | Fixed in Version | => RR23Q1.3 |
| 2023-05-23 19:15 | hgbot | Note Added: 0150162 | |
| 2023-05-23 19:15 | hgbot | Note Added: 0150163 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |