0052489: Menu [Tax calculation] - Not possible to finalize a ticket paid partially nor do reverse payment

Openbravo Issue Tracking System - POS2

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0052489

POS2

Restaurants

public

2023-05-10 15:55

2023-05-23 19:15

Reporter

nicola_uva

Assigned To

javierRodriguez

Priority

immediate

Severity

critical

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

23Q1.3

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0052489: Menu [Tax calculation] - Not possible to finalize a ticket paid partially nor do reverse payment

Description

Tax calculation error on Menu.Is not possible to finalize a ticket paid partially nor do reverse payment

Steps To Reproduce

1) Login https://livebuilds.openbravo.com/retail_pos2_modules_pgsql/web/pos/?terminal=VBS-2 [^]
2) select schema "Restaurant"
3) add to the ticketthe menu "Simple menu"
4) finalize the payment
5)open the ticket paid in (5)
6) click on review payments -> then
a) try to reverse payment
b) try to pay pending amount by cash
7) Dialog is showed saying tax not found(see image attached) -> ERROR

Proposed Solution

In:
https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/blob/master/web/org.openbravo.retail.posterminal/app/model/business-object/ticket/TicketUtils.js#L616 [^]

Change followinf line:
ticketTaxRules = this.ticket.receiptTaxes.map(receiptTax => taxRules.find(taxRule => taxRule.id === receiptTax.taxid));

To something like this:
ticketTaxRules = taxRules.filter(rule -> condition1 OR condition2)

Where:
condition1: rule id matches ticket receiptTaxes taxid (current condition)
condition2: rule is bom and rule.taxCategory matches with the tax category of any ticket line

Additional Information