Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0052411
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] Restaurantscriticalalways2023-05-10 15:552024-02-15 16:16
Reporternicola_uvaView Statuspublic 
Assigned TojavierRodriguez 
PriorityimmediateResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Versionpi
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0052411: Menu [Tax calculation] - Not possible to finalize a ticket paid partially nor do reverse payment

DescriptionTax calculation error on Menu.Is not possible to finalize a ticket paid partially nor do reverse payment
Steps To Reproduce1) Login https://livebuilds.openbravo.com/retail_pos2_modules_pgsql/web/pos/?terminal=VBS-2 [^]
2) select schema "Restaurant"
3) add to the ticketthe menu "Simple menu"
4) finalize the payment
5)open the ticket paid in (5)
6) click on review payments -> then
 a) try to reverse payment
 b) try to pay pending amount by cash
7) Dialog is showed saying tax not found(see image attached) -> ERROR
Proposed SolutionIn:
https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/blob/master/web/org.openbravo.retail.posterminal/app/model/business-object/ticket/TicketUtils.js#L616 [^]

Change followinf line:
ticketTaxRules = this.ticket.receiptTaxes.map(receiptTax => taxRules.find(taxRule => taxRule.id === receiptTax.taxid));

To something like this:
ticketTaxRules = taxRules.filter(rule -> condition1 OR condition2)

Where:
condition1: rule id matches ticket receiptTaxes taxid (current condition)
condition2: rule is bom and rule.taxCategory matches with the tax category of any ticket line
TagsNo tags attached.
Attached Filespng file icon Screenshot from 2023-05-10 15-55-52.png [^] (184,869 bytes) 2023-05-10 15:56

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 005248823Q2.1 closedjavierRodriguez Menu [Tax calculation] - Not possible to finalize a ticket paid partially nor do reverse payment 
depends on backport 005248923Q1.3 closedjavierRodriguez Menu [Tax calculation] - Not possible to finalize a ticket paid partially nor do reverse payment 
related to defect 0052531 closedjavierRodriguez Wrong productBOM calculation with menus in loaded ticket 

-  Notes
(0149896)
hgbot (developer)
2023-05-17 16:34

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1195 [^]
(0149962)
hgbot (developer)
2023-05-19 08:38

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1195 [^]
(0149963)
hgbot (developer)
2023-05-19 08:38

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: f6b8d571e768b44912f6bccbbd0f945680be2b64
Author: Javier Rodríguez Regueiro <javier.rodriguez@openbravo.com>
Date: 19-05-2023 06:38:39
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/f6b8d571e768b44912f6bccbbd0f945680be2b64 [^]

Fixed ISSUE-52411: Improve condition to add taxes in booked tickets

---
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/TicketUtils.js
---
(0160808)
Andreaa23 (reporter)
2024-02-15 16:16

 Examine the tax calculation logic in your system to identify any errors or inconsistencies. Ensure that the https://wordhurdle.co [^] tax calculations are accurate and align with the applicable tax regulations.

- Issue History
Date Modified Username Field Change
2023-05-10 15:55 nicola_uva New Issue
2023-05-10 15:55 nicola_uva Assigned To => Triage Omni OMS
2023-05-10 15:55 nicola_uva Triggers an Emergency Pack => No
2023-05-10 15:56 nicola_uva File Added: Screenshot from 2023-05-10 15-55-52.png
2023-05-10 17:08 aferraz Assigned To Triage Omni OMS => radhakrishnan
2023-05-10 20:05 guilleaer Steps to Reproduce Updated View Revisions
2023-05-11 13:43 radhakrishnan Status new => scheduled
2023-05-15 12:35 aferraz Proposed Solution updated
2023-05-15 12:42 aferraz Assigned To radhakrishnan => javierRodriguez
2023-05-17 16:34 hgbot Note Added: 0149896
2023-05-19 08:38 hgbot Note Added: 0149962
2023-05-19 08:38 hgbot Resolution open => fixed
2023-05-19 08:38 hgbot Status scheduled => closed
2023-05-19 08:38 hgbot Fixed in Version => RR23Q3
2023-05-19 08:38 hgbot Note Added: 0149963
2023-05-19 08:42 guilleaer Status closed => new
2023-05-19 08:42 guilleaer Resolution fixed => open
2023-05-19 08:42 guilleaer Fixed in Version RR23Q3 =>
2023-05-19 08:42 guilleaer Status new => scheduled
2023-05-19 08:42 guilleaer Status scheduled => resolved
2023-05-19 08:42 guilleaer Resolution open => fixed
2023-05-19 08:42 guilleaer Status resolved => closed
2023-05-23 13:44 aferraz Relationship added related to 0052531
2024-02-15 16:16 Andreaa23 Note Added: 0160808

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker