Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0052224 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Gift cards and gift vouchers | critical | have not tried | 2023-04-25 12:00 | 2023-04-26 06:46 | |||
| Reporter | guilleaer | View Status | public | |||||
| Assigned To | hcurbelo | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | RR23Q3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | marvintm | |||||||
| OBNetwork customer | No | |||||||
| Support ticket | ||||||||
| Regression level | Production - QA Approved | |||||||
| Regression date | 2023-01-27 | |||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/f7860454aa84bf073f34ebd22e5b8d151b732e95 [^] | |||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0052224: Issue prepaid order from POS2 generates and EWI if gift card module is installed | |||||||
| Description | Issue prepaid order from POS2 generates and EWI if gift card module is installed | |||||||
| Steps To Reproduce | Configure POS2 to use prepayments Create an order to pickup in store Select a customer complete the order with a prepayment Open the order and pay it completely Open de order and issue the order org.codehaus.jettison.json.JSONException: JSONObject["created"] is not a number. at org.codehaus.jettison.json.JSONObject.getDouble(JSONObject.java:405) at org.codehaus.jettison.json.JSONObject.getLong(JSONObject.java:475) at org.openbravo.retail.giftcards.hooks.OrderLoaderHookGiftCard.exec(OrderLoaderHookGiftCard.java:45) at org.openbravo.retail.giftcards.hooks.OrderLoaderHookGiftCard$Proxy$_$$_WeldClientProxy.exec(Unknown Source) at org.openbravo.retail.posterminal.OrderLoader.executeHooks(OrderLoader.java:834) at org.openbravo.retail.posterminal.OrderLoader.saveRecord(OrderLoader.java:624) | |||||||
| Proposed Solution | diff --git a/src/org/openbravo/retail/giftcards/hooks/OrderLoaderHookGiftCard.java b/src/org/openbravo/retail/giftcards/hooks/OrderLoaderHookGiftCard.java index 018021e..1edc565 100644 --- a/src/org/openbravo/retail/giftcards/hooks/OrderLoaderHookGiftCard.java +++ b/src/org/openbravo/retail/giftcards/hooks/OrderLoaderHookGiftCard.java @@ -42,7 +42,7 @@ public class OrderLoaderHookGiftCard extends OrderLoaderPaymentHook { public void exec(JSONObject jsonorder, Order order, ShipmentInOut shipment, Invoice invoice) throws Exception { // Date Time Long Value from Order Creation - Long localCreationDate = jsonorder.getLong("created"); + Long localCreationDate = jsonorder.optLong("created", new Date().getTime()); | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0148877) hgbot (developer) 2023-04-26 06:46 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^] Changeset: 5517639c27f982bde72120a99f43e8ed55bd49d5 Author: HECTOR CURBELO BARRIOS <HECTOR.CURBELO@SMFCONSULTING.ES> Date: 26-04-2023 04:46:16 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/5517639c27f982bde72120a99f43e8ed55bd49d5 [^] Fixed ISSUE-52224: Open order and issue the order when order is to pickup in store --- M src/org/openbravo/retail/giftcards/hooks/OrderLoaderHookGiftCard.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2023-04-25 12:00 | guilleaer | New Issue | |
| 2023-04-25 12:00 | guilleaer | Assigned To | => Retail |
| 2023-04-25 12:00 | guilleaer | OBNetwork customer | => No |
| 2023-04-25 12:00 | guilleaer | Regression level | => Production - QA Approved |
| 2023-04-25 12:00 | guilleaer | Regression date | => 2023-01-27 |
| 2023-04-25 12:00 | guilleaer | Regression introduced by commit | => https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/f7860454aa84bf073f34ebd22e5b8d151b732e95 [^] |
| 2023-04-25 12:00 | guilleaer | Triggers an Emergency Pack | => No |
| 2023-04-25 12:00 | guilleaer | Assigned To | Retail => hcurbelo |
| 2023-04-25 12:13 | guilleaer | Status | new => scheduled |
| 2023-04-25 12:33 | guilleaer | Steps to Reproduce Updated | View Revisions |
| 2023-04-26 06:46 | hgbot | Resolution | open => fixed |
| 2023-04-26 06:46 | hgbot | Status | scheduled => resolved |
| 2023-04-26 06:46 | hgbot | Note Added: 0148877 | |
| 2023-04-26 06:46 | marvintm | Review Assigned To | => marvintm |
| 2023-04-26 06:46 | marvintm | Status | resolved => closed |
| 2023-04-26 06:46 | marvintm | Fixed in Version | => RR23Q3 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |