0052224: Issue prepaid order from POS2 generates and EWI if gift card module is installed

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0052224

Retail Modules

Gift cards and gift vouchers

public

2023-04-25 12:00

2023-04-26 06:46

Reporter

guilleaer

Assigned To

hcurbelo

Priority

normal

Severity

critical

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

RR23Q3

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

Support ticket

Regression level

Production - QA Approved

Regression date

2023-01-27

Regression introduced in release

Regression introduced by commit

https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/f7860454aa84bf073f34ebd22e5b8d151b732e95 [^]

Triggers an Emergency Pack

Summary

0052224: Issue prepaid order from POS2 generates and EWI if gift card module is installed

Description

Issue prepaid order from POS2 generates and EWI if gift card module is installed

Steps To Reproduce

Configure POS2 to use prepayments
Create an order to pickup in store
Select a customer
complete the order with a prepayment
Open the order and pay it completely
Open de order and issue the order

org.codehaus.jettison.json.JSONException: JSONObject["created"] is not a number.
    at org.codehaus.jettison.json.JSONObject.getDouble(JSONObject.java:405)
    at org.codehaus.jettison.json.JSONObject.getLong(JSONObject.java:475)
    at org.openbravo.retail.giftcards.hooks.OrderLoaderHookGiftCard.exec(OrderLoaderHookGiftCard.java:45)
    at org.openbravo.retail.giftcards.hooks.OrderLoaderHookGiftCard$Proxy$_$$_WeldClientProxy.exec(Unknown Source)
    at org.openbravo.retail.posterminal.OrderLoader.executeHooks(OrderLoader.java:834)
    at org.openbravo.retail.posterminal.OrderLoader.saveRecord(OrderLoader.java:624)

Proposed Solution

diff --git a/src/org/openbravo/retail/giftcards/hooks/OrderLoaderHookGiftCard.java b/src/org/openbravo/retail/giftcards/hooks/OrderLoaderHookGiftCard.java
index 018021e..1edc565 100644
--- a/src/org/openbravo/retail/giftcards/hooks/OrderLoaderHookGiftCard.java
+++ b/src/org/openbravo/retail/giftcards/hooks/OrderLoaderHookGiftCard.java
@@ -42,7 +42,7 @@ public class OrderLoaderHookGiftCard extends OrderLoaderPaymentHook {
   public void exec(JSONObject jsonorder, Order order, ShipmentInOut shipment, Invoice invoice)
       throws Exception {
     // Date Time Long Value from Order Creation
- Long localCreationDate = jsonorder.getLong("created");
+ Long localCreationDate = jsonorder.optLong("created", new Date().getTime());

Additional Information