Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0052225 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [Retail Modules] Gift cards and gift vouchers | critical | have not tried | 2023-04-25 12:00 | 2023-04-26 06:47 | |||
| Reporter | guilleaer | View Status | public | |||||
| Assigned To | hcurbelo | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | RR23Q2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | RR23Q2 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | marvintm | |||||||
| OBNetwork customer | No | |||||||
| Support ticket | ||||||||
| Regression level | Production - QA Approved | |||||||
| Regression date | 2023-01-27 | |||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/f7860454aa84bf073f34ebd22e5b8d151b732e95 [^] | |||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0052225: Issue prepaid order from POS2 generates and EWI if gift card module is installed | |||||||
| Description | Issue prepaid order from POS2 generates and EWI if gift card module is installed | |||||||
| Steps To Reproduce | Configure POS2 to use prepayments Create an order to pickup in store Select a customer complete the order with a prepayment Open the order and pay it completely Open de order and issue the order EWI is generated (null pointer exception)(Created does not exist) | |||||||
| Proposed Solution | diff --git a/src/org/openbravo/retail/giftcards/hooks/OrderLoaderHookGiftCard.java b/src/org/openbravo/retail/giftcards/hooks/OrderLoaderHookGiftCard.java index 018021e..1edc565 100644 --- a/src/org/openbravo/retail/giftcards/hooks/OrderLoaderHookGiftCard.java +++ b/src/org/openbravo/retail/giftcards/hooks/OrderLoaderHookGiftCard.java @@ -42,7 +42,7 @@ public class OrderLoaderHookGiftCard extends OrderLoaderPaymentHook { public void exec(JSONObject jsonorder, Order order, ShipmentInOut shipment, Invoice invoice) throws Exception { // Date Time Long Value from Order Creation - Long localCreationDate = jsonorder.getLong("created"); + Long localCreationDate = jsonorder.optLong("created", new Date().getTime()); | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0148878) hgbot (developer) 2023-04-26 06:47 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^] Changeset: b3d375d38b46c6762b2ff79492d93772af7b8087 Author: HECTOR CURBELO BARRIOS <HECTOR.CURBELO@SMFCONSULTING.ES> Date: 25-04-2023 17:24:28 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/b3d375d38b46c6762b2ff79492d93772af7b8087 [^] Fixed ISSUE-52225: Open order and issue the order when order is to pickup in store --- M src/org/openbravo/retail/giftcards/hooks/OrderLoaderHookGiftCard.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2023-04-25 12:13 | guilleaer | Type | defect => backport |
| 2023-04-25 12:13 | guilleaer | Target Version | => RR23Q2 |
| 2023-04-26 06:47 | hgbot | Resolution | open => fixed |
| 2023-04-26 06:47 | hgbot | Status | scheduled => resolved |
| 2023-04-26 06:47 | hgbot | Note Added: 0148878 | |
| 2023-04-26 06:47 | marvintm | Review Assigned To | => marvintm |
| 2023-04-26 06:47 | marvintm | Status | resolved => closed |
| 2023-04-26 06:47 | marvintm | Fixed in Version | => RR23Q2 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |