Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0051599 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [POS2] Core | major | have not tried | 2023-02-14 15:53 | 2023-05-03 13:28 | |||
| Reporter | AugustoMauch | View Status | public | |||||
| Assigned To | AugustoMauch | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 23Q1.2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | 23Q1.2 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | Packaging and release | |||||||
| Regression date | 2022-11-08 | |||||||
| Regression introduced in release | main | |||||||
| Regression introduced by commit | https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/6d5485e031a5f1b887abb62d565bd98eeb5a5b54 [^] | |||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0051599: Some terminal log messages are lost when logging out | |||||||
| Description | In this commit [1] we made a change to move terminal log messages from memory to IndexedDB. The problem is that some properties that are usually added to the payload when the terminalLogGenerateMessage state action is executed, but that are not being passed when invoking directly the utility action. [1] https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/6d5485e031a5f1b887abb62d565bd98eeb5a5b54 [^] | |||||||
| Steps To Reproduce | Can be reproduced in livebuilds: - Open POS2: https://livebuilds.openbravo.com/retail_pos2_pgsql/web/pos/?terminal=VBS-2 [^] - Log in, create a ticket, and do a cashup. This will generate terminal log messages - Log in to ensure all messages are sent to the backend - Check in the log that some errors have been logged in the console and as a result some messages are not saved in the terminal log table: https://livebuilds.openbravo.com/logs/retail_pos2_pgsql_openbravo.log [^] 2023-02-14 08:54:10,592 [Import Entry - 2] ERROR org.openbravo.mobile.core.terminallog.StoreTerminalLogEventInDatabase - Could not save UserEvent log with info: {"events":"[{\"d\":1676364824165,\"o\":false,\"n\":\"OBC2_Logout\",\"e\":\"action\",\"c\":\"79C6A4513DBF8E2AE20633A77A614DC4\",\"i\":\"skipConfirmation:true - userActionsInProgress: []\",\"t\":\"as\"},{\"d\":1676364824180,\"o\":false,\"n\":\"OBPOS2_ResetProductSearch\",\"e\":\"action\",\"c\":\"79C6A4513DBF8E2AE20633A77A614DC4\",\"i\":\"userActionsInProgress: [\\\"OBC2_Logout\\\"]\",\"t\":\"as\"},{\"d\":1676364824189,\"o\":false,\"n\":\"OBPOS2_ResetProductSearch\",\"e\":\"action\",\"c\":\"79C6A4513DBF8E2AE20633A77A614DC4\",\"i\":\"userActionsInProgress: [\\\"OBC2_Logout\\\",\\\"OBPOS2_ResetProductSearch\\\"]\",\"t\":\"afs\"}]","extraProperties":{"ignoreForSessionTimeout":true}} org.codehaus.jettison.json.JSONException: JSONObject["terminal"] not found. at org.codehaus.jettison.json.JSONObject.get(JSONObject.java:360) ~[jettison-1.3-patched.jar:?] at org.codehaus.jettison.json.JSONObject.getString(JSONObject.java:487) ~[jettison-1.3-patched.jar:?] ... | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0149152) hgbot (developer) 2023-05-02 16:43 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1072 [^] |
|
(0149203) hgbot (developer) 2023-05-03 13:28 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1072 [^] |
|
(0149204) hgbot (developer) 2023-05-03 13:28 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^] Changeset: b0eef675d5afdf40f98d5357f18e325e60b292e8 Author: Augusto Mauch <augusto.mauch@openbravo.com> Date: 03-05-2023 13:24:52 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/b0eef675d5afdf40f98d5357f18e325e60b292e8 [^] Fixes ISSUE-51599: Adds missing properties to terminal log messages Some mandatory terminal log properties were not being included in the call to terminalLogGenerateMessage. Those properties are usually included in an actionPreparation of TerminalLog. But as the utility function is directly invoked those properties must be entered manually, so a new actionPreparation has been added for clearSession state action to include the missing properties. --- M web-jspack/org.openbravo.core2/src/model/session/Session.js M web-jspack/org.openbravo.core2/src/model/session/__test__/ClearSession-actionPreparation.test.js M web-jspack/org.openbravo.core2/src/model/session/actions/ClearSessionActionPreparation.js --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2023-02-14 15:53 | AugustoMauch | Type | defect => backport |
| 2023-02-14 15:53 | AugustoMauch | Target Version | => 23Q1 |
| 2023-02-22 11:41 | marvintm | Target Version | 23Q1 => 23Q1.1 |
| 2023-03-28 12:52 | AugustoMauch | Target Version | 23Q1.1 => 23Q1.2 |
| 2023-05-02 16:43 | hgbot | Note Added: 0149152 | |
| 2023-05-03 13:28 | hgbot | Resolution | open => fixed |
| 2023-05-03 13:28 | hgbot | Status | scheduled => closed |
| 2023-05-03 13:28 | hgbot | Fixed in Version | => 23Q1.2 |
| 2023-05-03 13:28 | hgbot | Note Added: 0149204 | |
| 2023-05-03 13:28 | hgbot | Note Added: 0149203 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |